Red Hat Bugzilla – Bug 473591
Review Request: iFuse - Mount Apple iPhone and iPod touch devices
Last modified: 2008-12-18 12:36:02 EST
SPEC: http://pbrobinson.fedorapeople.org/ifuse.spec SRPM: http://pbrobinson.fedorapeople.org/ifuse-0.1.0-1.fc10.src.rpm A fuse filesystem for mounting iPhone and iPod touch devices
Updated spec for git packaging guidelines SPEC: http://pbrobinson.fedorapeople.org/ifuse.spec SRPM: http://pbrobinson.fedorapeople.org/ifuse-0.1.0-2.d159256.fc10.src.rpm
Improved and simplified the git package creation. SRPM: http://pbrobinson.fedorapeople.org/ifuse-0.1.0-3.20081201gitd159256.fc10.src.rpm
Updated package: SPEC: http://pbrobinson.fedorapeople.org/ifuse.spec SRPM: http://pbrobinson.fedorapeople.org/ifuse-0.1.0-4.20081214gitb0412bf.fc10.src.rpm
ifuse.src: W: mixed-use-of-spaces-and-tabs (spaces: line 10, tab: line 18) ifuse.x86_64: W: incoherent-version-in-changelog 0.1.0-4 ['0.1.0-4.20081214gitb0412bf.fc11', '0.1.0-4.20081214gitb0412bf']
- MUST: A package must own all directories that it creates. If it does not create a directory that it uses, then it should require a package which does create that directory. You should add 'Requires: hal' because you place a file in %{_datadir}/hal/fdi/information/20thirdparty
Looks good to me other than the above. When those are fixed, approved.
Are we suppose to put the full build string in the changelog. I've only put the initial rev number, I've seen both done. There's a new version with the rest fixed here http://pbrobinson.fedorapeople.org/ifuse-0.1.0-5.20081214gitb0412bf.fc10.src.rpm
Allegedly rpmlint will let you omit %{dist} from the changelog but nothing else. It's not entirely clear that the packaging guidelines are so strict. https://fedoraproject.org/wiki/PackagingGuidelines#Changelogs doesn't go into detail. Personally, I think it's more readable as you had it before.
I agree, I've seen ones with just the build like I had, and with the git ammended. I think its more readable and it seems there's a mix. Thanks.
New Package CVS Request ======================= Package Name: ifuse Short Description: Mount Apple iPhone and iPod touch devices Owners: pbrobinson Branches: F-9 F-10
cvs done.
Committed to cvs, build and landed in rawhide