Spec URL: http://ianweller.fedorapeople.org/SRPMS/terminator/0.11-1/terminator.spec SRPM URL: http://ianweller.fedorapeople.org/SRPMS/terminator/0.11-1/terminator-0.11-1.fc9.noarch.rpm Description: Multiple GNOME terminals in one window. This is a project to produce an efficient way of filling a large area of screen space with terminals. This is done by splitting the window into a resizeable grid of terminals. As such, you can produce a very flexible arrangements of terminals for different tasks.
*** Bug 462173 has been marked as a duplicate of this bug. ***
(Heads up -- we're missing a few BuildRequires. Fixing.)
Spec URL: http://ianweller.fedorapeople.org/SRPMS/terminator/0.11-2/terminator.spec SRPM URL: http://ianweller.fedorapeople.org/SRPMS/terminator/0.11-2/terminator-0.11-2.fc9.src.rpm * Mon Dec 01 2008 Ian Weller <ianweller> 0.11-2 - Add BuildRequires: gettext - Fix installation of .desktop file - terminator-0.11-desktop.patch: Remove useless things Move to same category as gnome-terminal - Uses spaces instead of tabs in the specfile because I can't stand tabs
Shouldn't this spec include gettext?
Steven, the newest one does.
what the eta of this review ?
Spoke with reviewer on IRC... Spec URL: http://ianweller.fedorapeople.org/SRPMS/terminator/0.11-3/terminator.spec SRPM URL: http://ianweller.fedorapeople.org/SRPMS/terminator/0.11-3/terminator-0.11-3.fc9.src.rpm * Mon Dec 08 2008 Ian Weller <ianweller> 0.11-3 - Patch version in terminatorlib/verison.py to the one we think it is - Fix License tag - Update post and postun scripts with one line
Package Review ============== Key: - = N/A x = Check ! = Problem ? = Not evaluated === REQUIRED ITEMS === [x] Package is named according to the Package Naming Guidelines. [x] Spec file name must match the base package %{name}, in the format %{name}.spec. [x] Package meets the Packaging Guidelines. [x] Package successfully compiles and builds into binary rpms on at least one supported architecture. Tested on: devel/x86_64 [x] Rpmlint output: source RPM: empty binary RPM:empty [x] Package is not relocatable. [x] Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x] License field in the package spec file matches the actual license. License: GPLv2 [x] If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x] Spec file is legible and written in American English. [x] Sources used to build the package matches the upstream source, as provided in the spec URL. SHA1SUM of package: f78024065afb9a30041a693a40387e68771cec01 terminator_0.11.tar.gz [x] All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x] The spec file handles locales properly. [-] ldconfig called in %post and %postun if required. [x] Package must own all directories that it creates. [x] Package requires other packages for directories it uses. [x] Package does not contain duplicates in %files. [x] Permissions on files are set properly. [x] Package has a %clean section, which contains rm -rf $RPM_BUILD_ROOT. [x] Package consistently uses macros. [x] Package contains code, or permissable content. [-] Large documentation files are in a -doc subpackage, if required. [x] Package uses nothing in %doc for runtime. [-] Header files in -devel subpackage, if present. [-] Static libraries in -devel subpackage, if present. [-] Package requires pkgconfig, if .pc files are present. [-] Development .so files in -devel subpackage, if present. [-] Fully versioned dependency in subpackages, if present. [x] Package does not contain any libtool archives (.la). [x] Package contains a properly installed %{name}.desktop file if it is a GUI application. [x] Package does not own files or directories owned by other packages. === SUGGESTED ITEMS === [x] Latest version is packaged. [x] Package does not include license text files separate from upstream. [-] Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x] Reviewer should test that the package builds in mock. Tested on: f10/x86_64 [-] Package should compile and build into binary rpms on all supported architectures. Tested on: noarch-package [x] Package functions as described. [-] Scriptlets must be sane, if used. [-] The placement of pkgconfig(.pc) files is correct. [-] File based requires are sane.
New Package CVS Request ======================= Package Name: terminator Short Description: Store and run multiple GNOME terminals in one window Owners: ianweller Branches: F-9 F-10 InitialCC:
CVS Done
terminator-0.11-3.fc9 has been submitted as an update for Fedora 9. http://admin.fedoraproject.org/updates/terminator-0.11-3.fc9
terminator-0.11-3.fc10 has been submitted as an update for Fedora 10. http://admin.fedoraproject.org/updates/terminator-0.11-3.fc10
terminator-0.11-3.fc10 has been pushed to the Fedora 10 stable repository. If problems still persist, please make note of it in this bug report.
terminator-0.11-3.fc9 has been pushed to the Fedora 9 stable repository. If problems still persist, please make note of it in this bug report.
Package Change Request ======================= Package Name: terminator Owners: dmaphy jokajak Branches: el5 el6
Two issues: We need an ack from the current maintainer here; you are submitting a branch request and making someone else own it. Such requests should generally come from the person who will be the owner of the branch. The request is invalid; please follow the template at https://fedoraproject.org/wiki/Package_SCM_admin_requests verbatim. Please fix and re-raise the fedora-cvs flag.
Package Change Request ====================== Package Name: terminator New Branches: el5 el6 Owners: dmaphy jokajak I am the current owner of the terminator package in Fedora. I wrote with Josh via mail before he requested this change here. Reason for this request is, that we'd like to maintain terminator for EPEL as well. Please list Josh as Co-Maintainer, if possible. Sorry for the confusion. :)
(In reply to comment #17) > Package Change Request > ====================== > Package Name: terminator > New Branches: el5 el6 > Owners: dmaphy jokajak > > I am the current owner of the terminator package in Fedora. I wrote with Josh > via mail before he requested this change here. Reason for this request is, that > we'd like to maintain terminator for EPEL as well. Please list Josh as > Co-Maintainer, if possible. Sorry for the confusion. :) I was just overzealous. :) Thanks!
Git done (by process-git-requests).