Bug 474138 - internal-error in get_depends for a group (yumBackend)
Summary: internal-error in get_depends for a group (yumBackend)
Keywords:
Status: CLOSED NEXTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: PackageKit
Version: 10
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Richard Hughes
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2008-12-02 12:57 UTC by Michal Schmidt
Modified: 2009-01-14 13:31 UTC (History)
5 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2009-01-14 13:31:02 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)
excerpt from PackageKit log (22.76 KB, text/plain)
2008-12-02 13:00 UTC, Michal Schmidt
no flags Details
patch to fix get_depends on a group (567 bytes, patch)
2008-12-02 13:04 UTC, Michal Schmidt
no flags Details | Diff
what's in git (828 bytes, patch)
2008-12-02 13:26 UTC, Richard Hughes
no flags Details | Diff

Description Michal Schmidt 2008-12-02 12:57:54 UTC
Description of problem:
An internal error happens when trying to install a package group. 

Version-Release number of selected component (if applicable):
PackageKit-glib-0.3.11-3.fc10.x86_64
PackageKit-0.3.11-3.fc10.x86_64
PackageKit-udev-helper-0.3.11-3.fc10.x86_64
PackageKit-yum-plugin-0.3.11-3.fc10.x86_64
gnome-packagekit-0.3.11-3.fc10.x86_64
PackageKit-yum-0.3.11-3.fc10.x86_64

How reproducible:
always

Steps to Reproduce:
1. run gpk-application
2. in Package Collections select a previously uninstalled group (in my case it was development-tools)
3. click Apply
  
Actual results:
The group installs, but an internal error can be seen in the log.

Expected results:
Internal errors should never happen.

Additional info:
I'll attach a log and a patch.
The reason I looked in the log was that a friend of mine reported problems with installation of groups (PK was forever in the state of "waiting for other actions to finish"). Though I can't reproduce his problem, I suspect the internal error could be related.

Comment 1 Michal Schmidt 2008-12-02 13:00:22 UTC
Created attachment 325368 [details]
excerpt from PackageKit log

Scroll to the end to see the traceback.

Also notice lots of suspicious messages like:
invalid command 'Package gcc-4.3.2-7.x86_64 already installed and latest version'

Comment 2 Michal Schmidt 2008-12-02 13:04:49 UTC
Created attachment 325369 [details]
patch to fix get_depends on a group

Fix an internal error when get_depends is called on a group. self._findPackage() returns None for groups, so we can't remove that from the deps_list.

With this patch, gpk-application's behaviour changes a bit. Before it installs the group, it now lists the packages it is going to need and asks for confirmation. It seems to me like the correct behaviour.

Comment 3 Richard Hughes 2008-12-02 13:26:06 UTC
Created attachment 325370 [details]
what's in git

I've applied this very similar patch as it's the same as other parts of that file. The new behaviour was the intended behaviour, so I don't think that's a regression. Thanks for your help debugging this.


Note You need to log in before you can comment on or make changes to this bug.