Spec URL: http://www.auroralinux.org/people/spot/review/new/SolarModel.spec SRPM URL: http://www.auroralinux.org/people/spot/review/new/SolarModel-2.1-1.fc11.src.rpm Description: Solar Model provides realtime modeling of the solar system. It allows the user to navigate in space, to control time counting (speed-up time flow) and estimate real movement of space bodies like planets, dwarf planets and moons; estimate its nowadays positions in space. You may select two possible views: Solar System view or Milky Way galaxy view. It also allows the user to bind the camera to space objects (for example, you can look from the Moon onto Earth in real time flow).
Well done! * SPEC file is clean, legible. RPMlint produces no errors and warnings. (I think "Realtime" (in Summary) is correctly spelled "Real-time" in American English, but I'm not sure since I'm not a native speaker.) * Built in fedora-5-i386-epel mock (irrlicht packages pulled in manually) successfully with after a tiny 32bit-specific fix applied (I assume x86_64 builds fine). Anyways, BRs are connect. To build this on i386 a small change is needed, since the length of a light year won't fit in a 32bit doubleword (sorry about the light breaks, but it's trivial to apply this by hand anyways): diff -up SolarModel_src/GameMeasurer.cpp.int SolarModel_src/GameMeasurer.cpp --- SolarModel_src/GameMeasurer.cpp.int 2008-12-04 21:03:05.000000000 +0100 +++ SolarModel_src/GameMeasurer.cpp 2008-12-04 21:11:32.000000000 +0100 @@ -313,7 +313,7 @@ core::stringw GameMeasurer::GetDistanceA distanceKM/9460730472581.0f); swprintf(s, (sizeof(s)/sizeof(s[0])), L"%.0lf km%s%s", - distanceKM, distanceKM>149598?au:L"", distanceKM>9460730473?ly:L""); + distanceKM, distanceKM>149598?au:L"", distanceKM>9460730473LL?ly:L""); } return core::stringw(s); It won't block the approval, since at the packages are required to build on at least one architecture, and I don't see why won't this build on x86_64. APPROVED
Also -- now I realize this doesn't create a Desktop Entry. Please install a .desktop file with this package. Thanks!
Here is a new SRPM/SPEC: New SRPM: http://www.auroralinux.org/people/spot/review/new/SolarModel-2.1-2.fc11.src.rpm New SPEC: http://www.auroralinux.org/people/spot/review/new/SolarModel.spec Please note that this package depends on irrlicht (bz 474603).
New Package CVS Request ======================= Package Name: SolarModel Short Description: Real-time 3D Solar System simulation Owners: spot Branches: F-9 F-10 devel InitialCC: ... and it's done.
Built for F-9, F-10, rawhide.