Bug 474965 - Review Request: php-pear-Date-Holidays-USA - Driver based class to calculate holidays in USA
Summary: Review Request: php-pear-Date-Holidays-USA - Driver based class to calculate ...
Keywords:
Status: CLOSED NEXTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Jason Tibbitts
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2008-12-06 03:52 UTC by Christopher Stone
Modified: 2008-12-09 11:39 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2008-12-09 11:31:13 UTC
tibbs: fedora-review+
kevin: fedora-cvs+


Attachments (Terms of Use)

Description Christopher Stone 2008-12-06 03:52:07 UTC
Spec URL: http://xulchris.fedorapeople.org/packages/php-pear-Date-Holidays-USA.spec
SRPM URL: http://xulchris.fedorapeople.org/packages/php-pear-Date-Holidays-USA-0.1.1-1.fc10.src.rpm

Description:
Date_Holidays helps you calculate the dates and titles of holidays and other
special celebrations.  This is the driver for calculating holidays in USA.

Comment 1 Jason Tibbitts 2008-12-06 23:47:27 UTC
It's been a while since I looked at a PHP module.

rpmlint says:
  php-pear-Date-Holidays-USA.noarch: W: no-documentation
which is not a problem.

Everything else looks fine.

* source files match upstream.  sha256sum:
   5191c518642aaa2b7a8ba52ee69b156668f5570a909cc4e0a228650b7956ff37  
   Date_Holidays_USA-0.1.1.tgz
* package meets naming and versioning guidelines.
* specfile is properly named, is cleanly written and uses macros consistently.
* summary is OK.
* description is OK.
* dist tag is present.
* build root is OK.
* license field matches the actual license.
* license is open source-compatible.
* license text not included upstream.
* latest version is being packaged.
* BuildRequires are proper.
* %clean is present.
* package builds in mock (rawhide, x86_64).
* package installs properly.
* rpmlint has acceptable complaints.
* final provides and requires are sane:
   php-pear(Date_Holidays_USA) = 0.1.1
   php-pear-Date-Holidays-USA = 0.1.1-1.fc11
  =
   /bin/sh
   /usr/bin/pear
   php-pear(Date_Holidays) >= 0.18.0
   php-pear(PEAR)

* owns the directories it creates.
* doesn't own any directories it shouldn't.
* no duplicates in %files.
* file permissions are appropriate.
* no generically named files.
* scriptlets are OK (pear module registration).
* code, not content.

APPROVED

Comment 2 Christopher Stone 2008-12-07 00:52:29 UTC
New Package CVS Request
=======================
Package Name: php-pear-Date-Holidays-USA
Short Description: Driver based class to calculate holidays in USA
Owners: xulchris
Branches: F-8 F-9 F-10 EL-5
InitialCC:

Comment 3 Kevin Fenzi 2008-12-07 03:34:16 UTC
We no longer accept F-8 branch requests. 

cvs done except for F-8 branch.

Comment 4 Fedora Update System 2008-12-07 22:14:37 UTC
php-pear-Date-Holidays-USA-0.1.1-1.fc10 has been submitted as an update for Fedora 10.
http://admin.fedoraproject.org/updates/php-pear-Date-Holidays-USA-0.1.1-1.fc10

Comment 5 Fedora Update System 2008-12-07 22:15:30 UTC
php-pear-Date-Holidays-USA-0.1.1-1.fc9 has been submitted as an update for Fedora 9.
http://admin.fedoraproject.org/updates/php-pear-Date-Holidays-USA-0.1.1-1.fc9

Comment 6 Christopher Stone 2008-12-07 22:16:38 UTC
Successfully built and pushed on all platforms.  Thanks for the review! :D

Comment 7 Fedora Update System 2008-12-09 11:31:11 UTC
php-pear-Date-Holidays-USA-0.1.1-1.fc10 has been pushed to the Fedora 10 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 8 Fedora Update System 2008-12-09 11:39:11 UTC
php-pear-Date-Holidays-USA-0.1.1-1.fc9 has been pushed to the Fedora 9 stable repository.  If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.