Spec URL: http://red.fedorapeople.org/SRPMS/gdata-java.spec SRPM URL: http://red.fedorapeople.org/SRPMS/gdata-java-1.26.0-0.1.fc10.src.rpm Description: The client library provides tools and an abstraction layer, letting you easily construct queries and use response data without having to create HTTP requests or process HTTP responses by hand. Each client library provides classes that correspond to the elements and data types used by the Google Data APIs. Each client library also provides extensions for specific Google services that have Data APIs. This is a dependency needed for tvbrowser, for which a review request exists already. rpmlint on spec, srpm and noarch-rpms finishes checking without any warnings or errors. I'd still need a sponsor.
Successfully created a mock-(re)build of this version of this pkg.
(Removing NEEDSPONSOR)
Some comments: * Release number - As same as jcalendar, please fix release number. * Requires - Also fix Requires as same as jcalender. * About Patch0 and "-classpath /usr/share/java/javamail.jar" - I guess rather using sed with "build-classpath" (in jpackage-utils) is preferable: https://fedoraproject.org/wiki/Packaging/Java#build-classpath
Spec URL: http://red.fedorapeople.org/SRPMS/gdata-java.spec SRPM URL: http://red.fedorapeople.org/SRPMS/gdata-java-1.26.0-1.fc10.src.rpm New version including much of the experience I got when my jcalendar pkg was reviewed. This includes that the above has been addressed, except for the classpath thing into which I will look next.
To use classpath, an example can be: ------------------------------------------------------------------ %prep %setup -q -n gdata pushd java rm -rf lib/* classes doc pro=build-src/build.properties for jars in \ "servlet servletapi5" \ "mail javamail" \ "activation activation" do f=$(echo $jars | gawk '{print $1;}') g=$(echo $jars | gawk '{print $2;}') %{__sed} -i -e "/^${f}/s|=.*$|=$(build-classpath ${g})|" $pro done ...... %build ...... ...... javadoc -classpath $(build-classpath javamail):/etc/alternatives/java_sdk_openjdk/lib/tools.jar -d doc `find src -name '*.java'` ----------------------------------------------------------------- (I have not yet found how to find tools.jar using build-classpath, maybe it is impossible for current Fedora java structure?)
Spec URL: http://red.fedorapeople.org/SRPMS/gdata-java.spec SRPM URL: http://red.fedorapeople.org/SRPMS/gdata-java-1.26.0-2.fc11.src.rpm Thanks for the help :) Works perfectly :D Everything you mentioned should be addressed now. rpmlint is still clean.
Well, 18 hours ago new version seems released... Would you upgrade? Also, please put one line between each %changelog entry like below? ---------------------------------------------------------- * Thu Dec 18 2008 Sandro Mathys <red at fedoraproject.org> - 1.26.0-2 - The changes to the build.properties file are now applied with a for loop and sed instead of a patch - The paths to the 3rd-party libraries (i.e. currently only javamail.jar) for the javadoc generation are now looked up with build-classpath instead of being hardcoded * Tue Dec 16 2008 Sandro Mathys <red at fedoraproject.org> - 1.26.0-1 - initial build (thanks Rudolf 'che' Kastl for the help) ---------------------------------------------------------- This is useful on Fedora CVS system.
Spec URL: http://red.fedorapeople.org/SRPMS/gdata-java.spec SRPM URL: http://red.fedorapeople.org/SRPMS/gdata-java-1.28.0-1.fc11.src.rpm Rebuilt with the latest release. And a empty line between the %changelog entries.
Okay. ------------------------------------------------------- This package (gdata-java) is APPROVED by mtasaka -------------------------------------------------------
New Package CVS Request ======================= Package Name: gdata-java Short Description: Client libraries to write Google Data API client applications in Java Owners: red Branches: F-9 F-10 InitialCC:
cvs done.
ping?
gdata-java-1.28.0-1.fc9 has been submitted as an update for Fedora 9. http://admin.fedoraproject.org/updates/gdata-java-1.28.0-1.fc9
gdata-java-1.28.0-1.fc10 has been submitted as an update for Fedora 10. http://admin.fedoraproject.org/updates/gdata-java-1.28.0-1.fc10
Okay, thanks.
gdata-java-1.28.0-1.fc10 has been pushed to the Fedora 10 stable repository. If problems still persist, please make note of it in this bug report.
gdata-java-1.28.0-1.fc9 has been pushed to the Fedora 9 stable repository. If problems still persist, please make note of it in this bug report.