Bug 475082 - Review Request: guiloader - GuiXml Loader Library
Summary: Review Request: guiloader - GuiXml Loader Library
Keywords:
Status: CLOSED NEXTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Mamoru TASAKA
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 475107
TreeView+ depends on / blocked
 
Reported: 2008-12-07 15:54 UTC by Fabian Affolter
Modified: 2009-01-07 09:22 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2008-12-15 14:16:12 UTC
Type: ---
Embargoed:
mtasaka: fedora-review+
kevin: fedora-cvs+


Attachments (Terms of Use)

Description Fabian Affolter 2008-12-07 15:54:59 UTC
Spec URL: http://fab.fedorapeople.org/packages/SRPMS/guiloader.spec
SRPM URL: http://fab.fedorapeople.org/packages/SRPMS/guiloader-2.12.0-1.fc9.src.rpm

Project URL: http://crow-designer.sourceforge.net/

Description:
GuiLoader is a high-performance and compact GuiXml loader
library. This library allows GTK+ applications to create GUI widgets
and objects at run-time from GuiXml resource files. GuiLoader is
written in C language as a GObject subclass and has a trivial
language-independent API. GuiLoader was designed to be easily wrapped
for any language that has GTK+ bindings.

Koji scratch build:
http://koji.fedoraproject.org/koji/taskinfo?taskID=985300 

rpmlint output:
[fab@laptop024 i386]$ rpmlint guiloader*
3 packages and 0 specfiles checked; 0 errors, 0 warnings.

[fab@laptop024 SRPMS]$ rpmlint guiloader*
1 packages and 0 specfiles checked; 0 errors, 0 warnings.

This Review Request based on an old Review Request. -> https://bugzilla.redhat.com/show_bug.cgi?id=206122

As in https://bugzilla.redhat.com/show_bug.cgi?id=206134 suggested from the original owner of the Review Request of guiloader, this is the new Review Request to bring this into Fedora.

Comment 1 Mamoru TASAKA 2008-12-07 18:10:25 UTC
The latest seems 2.13.0.

Comment 2 Fabian Affolter 2008-12-07 20:08:12 UTC
I know, but 2.13.0 needs newer libraries than are available for Fedora 9.

Requested 'glib-2.0 >= 2.18' but version of GLib is 2.16.6
Requested 'gtk+-2.0 >= 2.14' but version of GTK+ is 2.12.12

Per example, glib2 in Fedora 10 is 2.19.2.

Comment 3 Mamoru TASAKA 2008-12-08 17:27:15 UTC
(In reply to comment #2)
> I know, but 2.13.0 needs newer libraries than are available for Fedora 9.
Ah, okay (but I recommand that for F-10+ you upgrade guiloader to 2.13.0)

By the way:
* Redundant (Build)Requires
  - Although configure.ac or .pc.in explicitly mention,
    glib2-devel is Required by gtk2-devel and
    "(Build)Requires: glib2-devel" is redundant.

I don't see other issues on this package.
---------------------------------------------------------------------
       This package (guiloader) is APPROVED by mtasaka
---------------------------------------------------------------------

Comment 4 Fabian Affolter 2008-12-10 19:20:55 UTC
Mamoru, thank you for your review and the hint about the redundant BR.  I missed that point. 

I will update the source for F10 and devel.

Comment 5 Fedora Update System 2008-12-10 21:32:22 UTC
guiloader-2.12.0-2.fc9 has been submitted as an update for Fedora 9.
http://admin.fedoraproject.org/updates/guiloader-2.12.0-2.fc9

Comment 6 Fedora Update System 2008-12-13 14:55:11 UTC
guiloader-2.12.0-2.fc9 has been pushed to the Fedora 9 testing repository.  If problems still persist, please make note of it in this bug report.
 If you want to test the update, you can install it with 
 su -c 'yum --enablerepo=updates-testing-newkey update guiloader'.  You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F9/FEDORA-2008-11197

Comment 7 Mamoru TASAKA 2008-12-15 05:47:19 UTC
Please also submit updates request for F-10.

Comment 8 Fedora Update System 2008-12-15 08:49:39 UTC
guiloader-2.13.0-1.fc10 has been submitted as an update for Fedora 10.
http://admin.fedoraproject.org/updates/guiloader-2.13.0-1.fc10

Comment 9 Mamoru TASAKA 2008-12-15 14:16:12 UTC
Okay, thanks.

Comment 10 Fabian Affolter 2008-12-15 21:58:07 UTC
Package Change Request
======================
Package Name: guiloader
Owners: fab
Updated Description: GuiXml Loader Library

Comment 11 Mamoru TASAKA 2008-12-16 15:31:28 UTC
Resetting CVS request as there is already guiloader module
on Fedora CVS.

Comment 12 Fabian Affolter 2008-12-16 19:24:51 UTC
It was a change request for the change of the name. Not a CVS Package request.

Comment 13 Fabian Affolter 2008-12-16 19:25:46 UTC
Not the name, the Description.

Comment 14 Mamoru TASAKA 2008-12-17 06:42:45 UTC
Ah, thanks

Comment 15 Kevin Fenzi 2008-12-18 00:30:34 UTC
cvs done.

Comment 16 Fedora Update System 2009-01-07 09:11:32 UTC
guiloader-2.13.0-1.fc10 has been pushed to the Fedora 10 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 17 Fedora Update System 2009-01-07 09:22:18 UTC
guiloader-2.12.0-2.fc9 has been pushed to the Fedora 9 stable repository.  If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.