Red Hat Bugzilla – Bug 475141
Review Request: python-imdb - Retrieve and manage the data of the IMDb movie database
Last modified: 2011-07-15 10:09:04 EDT
Spec URL: http://sindrepb.fedorapeople.org/packages/python-imdb.spec SRPM URL: http://sindrepb.fedorapeople.org/packages/python-imdb-3.8-1.fc10.src.rpm Description: IMDbPY is a Python package useful to retrieve and manage the data of the IMDb movie database about movies, people, characters and companies. IMDbPY is mainly a tool intended for programmers and developers, but some example scripts are included. This is a re-submit. Submitted for review and abandoned at #431154 Upstream name is IMDbPY, choosing python-imdb based on the name used when importing the module. See http://fedoraproject.org/wiki/Packaging/NamingGuidelines Upstream installs example scripts in bindir, as in the debian package I've chosen to move these to docdir as examples. rpmlint silent, buillds across arches in koji.
*** Bug 431154 has been marked as a duplicate of this bug. ***
Created attachment 327093 [details] [Review] See attached for my initial review. Thank you for submitting this package to Fedora, I was considering submitting it myself if no one else did.
Updated pacakge. - Add patch to use system BeautifulSoup - Add beautifulsoup requires - Fix build/install commands. - Fix bogus permission on cutils file Package now requires BeautifulSoup which is not in Fedora. See https://bugzilla.redhat.com/show_bug.cgi?id=477528 for review-request, which has been added as a dependency for this review. Updated srpm and spec: http://sindrepb.fedorapeople.org/packages/python-imdb.spec http://sindrepb.fedorapeople.org/packages/python-imdb-3.8-2.fc10.src.rpm
Er, sorry, I guess the setuptools line is only if it's an egg. If that's the case, keep it and add a BR on python-setuptools. If not, get rid of it. Other than that, looks good. Approved.
New Package CVS Request ======================= Package Name: python-imdb Short Description: Retrieve and manage the data of the IMDb movie database Owners: sindrepb Branches: F-9 F-10
cvs done.
Ping? You can close this bug once you've built python-imdb in rawhide.
Package Change Request ====================== Package Name: python-imdb New Branches: el6 Owners: limb
Git done (by process-git-requests).