Bug 475141 - Review Request: python-imdb - Retrieve and manage the data of the IMDb movie database
Summary: Review Request: python-imdb - Retrieve and manage the data of the IMDb movie ...
Keywords:
Status: CLOSED NEXTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Conrad Meyer
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
: 431154 (view as bug list)
Depends On: 477528
Blocks:
TreeView+ depends on / blocked
 
Reported: 2008-12-08 06:50 UTC by Sindre Pedersen Bjørdal
Modified: 2011-07-15 14:09 UTC (History)
5 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2009-04-01 15:45:49 UTC
Type: ---
cse.cem+redhatbugz: fedora-review+
gwync: fedora-cvs+


Attachments (Terms of Use)
[Review] (8.57 KB, text/plain)
2008-12-16 12:39 UTC, Conrad Meyer
no flags Details

Description Sindre Pedersen Bjørdal 2008-12-08 06:50:35 UTC
Spec URL: http://sindrepb.fedorapeople.org/packages/python-imdb.spec
SRPM URL: http://sindrepb.fedorapeople.org/packages/python-imdb-3.8-1.fc10.src.rpm

Description: 
IMDbPY is a Python package useful to retrieve and manage the data of
the IMDb movie database about movies, people, characters and companies.

IMDbPY is mainly a tool intended for programmers and developers, but
some example scripts are included.

This is a re-submit. Submitted for review and abandoned at #431154

Upstream name is IMDbPY, choosing python-imdb based on the name used when importing the module. See http://fedoraproject.org/wiki/Packaging/NamingGuidelines

Upstream installs example scripts in bindir, as in the debian package I've chosen to move these to docdir as examples. 

rpmlint silent, buillds across arches in koji.

Comment 1 Sindre Pedersen Bjørdal 2008-12-08 06:51:04 UTC
*** Bug 431154 has been marked as a duplicate of this bug. ***

Comment 2 Conrad Meyer 2008-12-16 12:39:54 UTC
Created attachment 327093 [details]
[Review]

See attached for my initial review. Thank you for submitting this package to Fedora, I was considering submitting it myself if no one else did.

Comment 3 Sindre Pedersen Bjørdal 2008-12-21 16:48:01 UTC
Updated pacakge. 

- Add patch to use system BeautifulSoup
- Add beautifulsoup requires
- Fix build/install commands.
- Fix bogus permission on cutils file

Package now requires BeautifulSoup which is not in Fedora. See https://bugzilla.redhat.com/show_bug.cgi?id=477528 for review-request, which has been added as a dependency for this review.

Updated srpm and spec:

http://sindrepb.fedorapeople.org/packages/python-imdb.spec
http://sindrepb.fedorapeople.org/packages/python-imdb-3.8-2.fc10.src.rpm

Comment 4 Conrad Meyer 2008-12-24 06:15:37 UTC
Er, sorry, I guess the setuptools line is only if it's an egg. If that's the case, keep it and add a BR on python-setuptools. If not, get rid of it.

Other than that, looks good. Approved.

Comment 5 Sindre Pedersen Bjørdal 2008-12-24 15:02:45 UTC
New Package CVS Request
=======================
Package Name: python-imdb
Short Description: Retrieve and manage the data of the IMDb movie database
Owners: sindrepb
Branches: F-9 F-10

Comment 6 Kevin Fenzi 2008-12-25 00:30:58 UTC
cvs done.

Comment 7 Conrad Meyer 2009-03-19 04:32:37 UTC
Ping? You can close this bug once you've built python-imdb in rawhide.

Comment 8 Gwyn Ciesla 2011-07-15 13:08:10 UTC
Package Change Request
======================
Package Name: python-imdb
New Branches: el6
Owners: limb

Comment 9 Gwyn Ciesla 2011-07-15 14:09:04 UTC
Git done (by process-git-requests).


Note You need to log in before you can comment on or make changes to this bug.