Spec URL: http://pastebin.ca/1279438 SRPM URL: http://www.metalinker.org/mirrors/metalink/metalink-0.3.5-1.fc10.src.rpm Description: Metalink is the main Metalink generation tool. It combines a list of mirrors (from stdin) and a number of files into one Metalink record (stdout). It can also be used to transform a MD5SUMS file into a metalink. Features currently include: - Hashing algorithms: md4 md5 sha1 sha256 sha384 sha512 rmd160 tiger crc32 ed2k gnunet - Generation of Metalink files from MD5SUMS lists Metalinks are XML files listing mirrors and checksums. Currently, Fedora uses MirrorManager to create Metalinks for files like ISOs. This app is a simple command line tool that can create them.
I believe you neglected to indicate that you need a sponsor.
A few other comments: The license on the most of the source files that I looked at indicate GPLv3 or later, though some indicate version 2 or later. Combined, these would simply be "GPLv3 or later", which would imply a Licence: tag of "GPLv3+". However, the program itself, in its help output, explicitly says "GPLv2". Upstream needs to clarify the situation. The %description should be trimmed a bit. Really only the first paragraph is appropriate for a package description, but it could also really use some definition of "metalink". rpmlint has one complaint: metalink.x86_64: W: spurious-executable-perm /usr/share/doc/metalink-0.3.5/example/gen.sh Generally documentation isn't executable, but it's not usually a review blocker unless the documentation carries additional dependencies that the base package doesn't. You should be OK. It would be really nice if this had a manpage.
Thanks for the comments, Jason. I will work on these issues with upstream. So, don't change the one thing rpmlint complains about? And yes, I do need a sponsor.
Well, for this package I think the license must be clarified before approved because: - some files are under GPLv3+ - README says it is under GPLv2 (unfortunately GPLv2+...) - GPLv2 and GPLv3+ are incompatible So from my viewpoint the current situation cannot be accepted.
(In reply to comment #4) > - README says it is under GPLv2 (unfortunately GPLv2+...) Should be read as "not GPLv2+"
Here is a new spec & source RPM. - license clarifications (GPLv3+) & man page upstream. - trimmed %description & added definition of metalink. - rpmlint complaint about script left as is. Spec URL: http://pastebin.ca/1300332 SRPM URL: http://www.metalinker.org/mirrors/metalink/metalink-0.3.6-1.fc10.src.rpm Description: a .metalink is an XML file that describes a download, and includes mirrors and checksum information. Metalink is the main Metalink generation tool. It combines a list of mirrors (from stdin) and a number of files into one Metalink record (stdout). It can also be used to transform a MD5SUMS file into a metalink.
Well, some notes for 0.3.6-1: * SourceURL - For sourceforge hosted tarball, please follow https://fedoraproject.org/wiki/Packaging/SourceURL#Sourceforge.net * BuildRequires - "BuildRequires: gcc-c++ libstdc++-devel make" are redundant. - Is "help2man" really used when rebuilding this srpm? * Timestamps - It is preferred to use ----------------------------------------------------------- make install DESTDIR=$RPM_BUILD_ROOT INSTALL="install -p" ----------------------------------------------------------- to keep timestamps on installed files. This method usually works for Makefiles based on recent autotools * %defattr - Now we recommend %defattr(-,root,root,-) * rpmlint issue ----------------------------------------------------------- metalink.src: W: mixed-use-of-spaces-and-tabs (spaces: line 5, tab: line 1) metalink.src: E: description-line-too-long a .metalink is an XML file that describes a download, and includes mirrors and checksum information. metalink.i386: W: spurious-executable-perm /usr/share/doc/metalink-0.3.6/example/gen.sh ----------------------------------------------------------- - Please use spaces or tabs for indention, not both, for cosmetic issue. - Cut one line in two lines or so when it exceeds 79 characters. - Usually I suggest that all files marked as %doc should have 0644 permission.
Thanks for the notes! I've fixed everything except for: * rpmlint issue ----------------------------------------------------------- metalink.i386: W: spurious-executable-perm /usr/share/doc/metalink-0.3.6/example/gen.sh ----------------------------------------------------------- - Usually I suggest that all files marked as %doc should have 0644 permission. I am trying %attr(644,root,root) %{_defaultdocdir}/%{name}-%{version}/example/gen.sh and %doc %attr(644,root,root) example/gen.sh Nothing seems to work. What am I doing wrong?
I have not checked your srpm yet, however: (In reply to comment #8) > * rpmlint issue > ----------------------------------------------------------- > metalink.i386: W: spurious-executable-perm > /usr/share/doc/metalink-0.3.6/example/gen.sh > ----------------------------------------------------------- > - Usually I suggest that all files marked as %doc should have > 0644 permission. > > I am trying > %attr(644,root,root) %{_defaultdocdir}/%{name}-%{version}/example/gen.sh > and > %doc %attr(644,root,root) example/gen.sh > Nothing seems to work. at %prep: chmod 0644 example/gen.sh will do.
(In reply to comment #9) > I have not checked your srpm yet, however: Sorry, the srpm would not build & I was waiting to fix that final issue. Spec URL: http://pastebin.ca/1302623 SRPM URL: http://www.metalinker.org/mirrors/metalink/metalink-0.3.6-2.fc10.src.rpm > at %prep: > chmod 0644 example/gen.sh > will do. Aha, that did it!
Assigning. * A very minor issue - 0.3.6-2 %changelog entry contains ------------------------------------------------------------ - New version, 0.3.6-1 (not -2) ------------------------------------------------------------ Now I think this package can be approved, however as this is NEEDSPONSOR ticket, I will discuss with Christoph.
Thank you. Apparently I updated the spec but didn't rebuild the srpm. SRPM URL: http://www.metalinker.org/mirrors/metalink/metalink-0.3.6-2.fc10.src.rpm
Okay, then I will wait for gget review request (for sponsorship issue)
Removing the blocker on bug # 177841 because I'm going to sponsor Ant. Mamoru, can you approve the package then?
(In reply to comment #14) > Removing the blocker on bug # 177841 because I'm going to sponsor Ant Thank you. Now I re-reviewed this package and it is still okay. ---------------------------------------------------------- This package (metalink) is APPROVED by mtasaka ----------------------------------------------------------
New Package CVS Request ======================= Package Name: metalink Short Description: A command line Metalink Generator. Owners: ant Branches: F-9 F-10 F-11 InitialCC:
cvs done.
metalink-0.3.6-2.fc9 has been submitted as an update for Fedora 9. http://admin.fedoraproject.org/updates/metalink-0.3.6-2.fc9
metalink-0.3.6-2.fc10 has been submitted as an update for Fedora 10. http://admin.fedoraproject.org/updates/metalink-0.3.6-2.fc10
metalink-0.3.6-2.fc9 has been pushed to the Fedora 9 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing-newkey update metalink'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F9/FEDORA-2009-2197
metalink-0.3.6-2.fc10 has been pushed to the Fedora 10 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update metalink'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F10/FEDORA-2009-2205
Now closing.
metalink-0.3.6-2.fc10 has been pushed to the Fedora 10 stable repository. If problems still persist, please make note of it in this bug report.
metalink-0.3.6-2.fc9 has been pushed to the Fedora 9 stable repository. If problems still persist, please make note of it in this bug report.