Bug 475149 - audit: fix kstrdup() error check
audit: fix kstrdup() error check
Product: Red Hat Enterprise Linux 5
Classification: Red Hat
Component: kernel (Show other bugs)
All Linux
low Severity medium
: rc
: ---
Assigned To: Alexander Viro
Red Hat Kernel QE team
Depends On:
  Show dependency treegraph
Reported: 2008-12-08 02:36 EST by Alexander Viro
Modified: 2009-09-03 09:42 EDT (History)
3 users (show)

See Also:
Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Last Closed: 2009-09-02 04:54:11 EDT
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---

Attachments (Terms of Use)

  None (edit)
Description Alexander Viro 2008-12-08 02:36:38 EST
on failure kstrdup() returns NULL, not ERR_PTR(...).  That makes the check in audit_dupe_selinux_field() useless - it won't trigger as expected on allocation failure.  That had been spotted and fixed in mainline two years ago; unfortunately, it hadn't been applied in rhel5.  Note: the same problem (with the same fix) exists in all 5.* branches.
Comment 1 RHEL Product and Program Management 2009-01-27 15:38:25 EST
This request was evaluated by Red Hat Product Management for inclusion in a Red
Hat Enterprise Linux maintenance release.  Product Management has requested
further review of this request by Red Hat Engineering, for potential
inclusion in a Red Hat Enterprise Linux Update release for currently deployed
products.  This request is not yet committed for inclusion in an Update
Comment 2 RHEL Product and Program Management 2009-02-16 10:44:14 EST
Updating PM score.
Comment 3 Don Zickus 2009-02-23 15:03:04 EST
in kernel-2.6.18-132.el5
You can download this test kernel from http://people.redhat.com/dzickus/el5

Please do NOT transition this bugzilla state to VERIFIED until our QE team
has sent specific instructions indicating when to do so.  However feel free
to provide a comment indicating that this fix has been verified.
Comment 7 errata-xmlrpc 2009-09-02 04:54:11 EDT
An advisory has been issued which should help the problem
described in this bug report. This report is therefore being
closed with a resolution of ERRATA. For more information
on therefore solution and/or where to find the updated files,
please follow the link below. You may reopen this bug report
if the solution does not work for you.


Note You need to log in before you can comment on or make changes to this bug.