Spec URL: http://cwickert.fedorapeople.org/review/menu-cache.spec SRPM URL: http://cwickert.fedorapeople.org/review/menu-cache-0.2.2-1.fc11.src.rpm Description: Menu-cache is a caching mechanism for freedesktop.org compatible menus to speed up parsing of the menu entries. It is currently used by some of components of the LXDE desktop environment such as LXPanel or LXLauncher.
Sebastian, I'm CC*ing you because the upcoming 0.4.0 version of your lxpanel package will need this. $ rpmlint /var/lib/mock/fedora-rawhide-i386/result/menu-cache-* menu-cache.i386: E: zero-length /usr/share/doc/menu-cache-0.2.2/ChangeLog menu-cache-devel.i386: W: no-documentation 4 packages and 0 specfiles checked; 1 errors, 1 warnings. PCman promised me to add a proper changelog in the next tarball, that's why I'm to lazy to remove it temporarily. ;)
(In reply to comment #1) > Sebastian, I'm CC*ing you because the upcoming 0.4.0 version of your lxpanel > package will need this. Yeah, I've already seen this in the cvs commits of lxpanel but haven't expected an update so soon. Thanks for the CC.
Package Review ============== Key: - = N/A x = Check ! = Problem ? = Not evaluated === REQUIRED ITEMS === [x] Package is named according to the Package Naming Guidelines. [x] Spec file name must match the base package %{name}, in the format %{name}.spec. [x] Package meets the Packaging Guidelines. [x] Package successfully compiles and builds into binary rpms on at least one supported architecture. Tested on: http://koji.fedoraproject.org/koji/taskinfo?taskID=1172968 [x] Rpmlint output: menu-cache.i386: E: zero-length /usr/share/doc/menu-cache-0.2.2/ChangeLog menu-cache-devel.i386: W: no-documentation [x] Package is not relocatable. [x] Buildroot is correct (%{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)) [!] Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [!] License field in the package spec file matches the actual license. License type: LGPLv2+ [-] If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x] Spec file is legible and written in American English. [x] Sources used to build the package matches the upstream source, as provided in the spec URL. MD5SUM this package : MD5SUM upstream package: [x] Package is not known to require ExcludeArch, OR: [x] All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [-] The spec file handles locales properly. [-] ldconfig called in %post and %postun if required. [x] Package must own all directories that it creates. [-] Package requires other packages for directories it uses. [x] Package does not contain duplicates in %files. [x] Permissions on files are set properly. [x] Package has a %clean section, which contains rm -rf %{buildroot} (or $RPM_BUILD_ROOT). [x] Package consistently uses macros. [x] Package contains code, or permissable content. [-] Large documentation files are in a -doc subpackage, if required. [x] Package uses nothing in %doc for runtime. [x] Header files in -devel subpackage, if present. [x] Static libraries in -devel subpackage, if present. [!] Package requires pkgconfig, if .pc files are present. [x] Development .so files in -devel subpackage, if present. [x] Fully versioned dependency in subpackages, if present. [x] Package does not contain any libtool archives (.la). [-] Package contains a properly installed %{name}.desktop file if it is a GUI application. [x] Package does not own files or directories owned by other packages. === SUGGESTED ITEMS === [x] Latest version is packaged. [-] Package does not include license text files separate from upstream. [-] Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x] Reviewer should test that the package builds in mock. Tested on: f11-i386 [x] Package should compile and build into binary rpms on all supported architectures. Tested on: http://koji.fedoraproject.org/koji/taskinfo?taskID=1172968 [x] Package functions as described. [-] Scriptlets must be sane, if used. [x] The placement of pkgconfig(.pc) files are correct. [-] File based requires are sane. === Issues === 1. most files in menu-cache-gen are licensed under LGPLv2+, so the License of the whole package should be LGPLv2+ 2. menu-cache-devel requires glib2-devel which requires pkgconfig. 3. There was no new release of menu-cache in two months. So the ChangeLog entry in %doc should be addded when it is really included in the package. === Final Notes === 1. As discussed in Jabber, fix the above items and the package is approved. ================ *** APPROVED *** ================
Thanks for the review. I will fix the issues you raised after import. New Package CVS Request ======================= Package Name: menu-cache Short Description: Caching mechanism for freedesktop.org compilant menus Owners: cwickert svahl Branches: F-10 InitialCC:
cvs done.
menu-cache-0.2.2-1.fc10 has been submitted as an update for Fedora 10. http://admin.fedoraproject.org/updates/menu-cache-0.2.2-1.fc10
menu-cache-0.2.2-1.fc10 has been pushed to the Fedora 10 stable repository. If problems still persist, please make note of it in this bug report.
Package Change Request ====================== Package Name: menu-cache New Branches: EL-4 EL-5 Owners: cwickert
(In reply to Kevin Fenzi from comment #9) > cvs done. Kevin, we need it for epel7 branch. Could you please create the epel7 branch? thanks
sorry, please ignore.
Clearning needinfo
we need this package for epel7 Package Change Request ====================== Package Name: menu-cache New Branches: EPEL7
Please request the branch in pkgdb.
Clearing needinfo.
closed it as it's done.