Red Hat Bugzilla – Bug 475926
Delete confirmation dialog nitpick
Last modified: 2010-03-16 13:16:38 EDT
User-Agent: Mozilla/4.0 (compatible; MSIE 7.0; Windows NT 5.1; .NET CLR 1.1.4322; .NET CLR 2.0.50727)
The delete confirmation dialog says, 'This will permanently delete the vm "$vm," are you sure?' How about this instead: 'Are you sure you want to delete the virtual machine "$vm"?' It seems that this would be helpful in mentally parsing that dialog.
Also, the buttons in the dialog are "Yes" and "No". They should be "Delete" and "Cancel", as per the GNOME HIG: http://library.gnome.org/devel/hig-book/stable/windows-alert.html.en
The text is addressed here: http://hg.et.redhat.com/cgi-bin/hg-virt.cgi/applications/virt-manager--devel/rev/e2056d9074e5
Cole Robinson had this to say about the buttons:
> This can hold off a bit. We need a revamped delete dialog anyways to
> optionally allow deleting the VM disk storage, so I'll incorporate this
> change when that work is done.
Yes, there is already a bug to track the enhanced delete dialog, bug 351681. We can close this as UPSTREAM, and I'll add the button recommendation to the other bug.