Spec URL: http://www.sugarlabs.org/~marco/gadget.spec SRPM URL: http://www.sugarlabs.org/~marco/gadget-0.0.3-1.fc10.src.rpm Description: Gadget is an XMPP server component written to scale Jabber server based collaborative activities via Telepathy Gabble.
Just two comments after a quick look at your spec file - COPYING is missing in %doc - in spec file is 'License: LGPLv2', COPYING says GPLv2, no licensing information in all the source files. This can become a blocker.
Marco, do you have an updated SPEC to correct the 2 points mentioned. Please update so the review can be completed. Thanks Steven
fwiw, the spec lives here now: http://people.sugarlabs.org/marcopg/gadget.spec
the missing gadget.init http://git.collabora.co.uk/?p=user/cassidy/gadget;a=blob;f=debian/gadget.init;h=cc4c76235d05e1ca3f1d13a29eba022c2ed2009c;hb=debian
SPEC: http://people.sugarlabs.org/erikos/gadget.spec SRPM: http://people.sugarlabs.org/erikos/gadget-0.0.3-2.fc10.src.rpm SOURCE1: http://people.sugarlabs.org/erikos/gadget.init BUILT proof: http://koji.fedoraproject.org/koji/taskinfo?taskID=1235255
rpmlint is fine as well - I only get this warning: [erikos@beet rpmbuild]$ rpmlint -iv RPMS/noarch/gadget-0.0.3-2.fc10.noarch.rpm gadget.noarch: I: checking gadget.noarch: W: service-default-enabled /etc/rc.d/init.d/gadget The service is enabled by default after "chkconfig --add"; for security reasons, most services should not be. Use "-" as the default runlevel in the init script's "chkconfig:" line and/or remove the "Default-Start:" LSB keyword to fix this if appropriate for this service.
MUST: rpmlint must be run on every package. - Checked spec file and src.rpm 0 errors, 1 warnings gadget.noarch: W: service-default-enabled /etc/rc.d/init.d/gadget The service is enabled by default after "chkconfig --add"; for security reasons, most services should not be. Use "-" as the default runlevel in the init script's "chkconfig:" line and/or remove the "Default-Start:" LSB keyword to fix this if appropriate for this service. MUST: The package must be named according to the Package Naming Guidelines OK MUST: The spec file name must match the base package %{name}, in the format %{name}.spec unless your package has an exemption. OK MUST: The package must meet the Packaging Guidelines ok MUST: The package must be licensed with a Fedora approved license and meet the Licensing Guidelines OK MUST: The License field in the package spec file must match the actual license. OK MUST: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package must be included in %doc OK MUST: The spec file must be written in American English. OK MUST: The spec file for the package MUST be legible. OK MUST: The sources used to build the package must match the upstream source, as provided in the spec URL. OK MUST: The package MUST successfully compile and build into binary rpms on at least one primary architecture. OK all archs MUST: If the package does not successfully compile, build or work on an architecture, then those architectures should be listed in the spec in ExcludeArch. OK MUST: All build dependencies must be listed in BuildRequires, except for any that are listed in the exceptions section of the Packaging Guidelines ; inclusion of those as BuildRequires is optional. Apply common sense. OK MUST: The spec file MUST handle locales properly. This is done by using the %find_lang macro. Using %{_datadir}/locale/* is strictly forbidden. OK MUST: Every binary RPM package (or subpackage) which stores shared library files (not just symlinks) in any of the dynamic linker's default paths, must call ldconfig in %post and %postun. OK MUST: If the package is designed to be relocatable, the packager must state this fact in the request for review, along with the rationalization for relocation of that specific package. Without this, use of Prefix: /usr is considered a blocker. OK MUST: A package must own all directories that it creates. If it does not create a directory that it uses, then it should require a package which does create that directory. OK MUST: A package must not contain any duplicate files in the %files listing. OK MUST: Permissions on files must be set properly. Executables should be set with executable permissions, for example. Every %files section must include a %defattr(...) line. OK MUST: Each package must have a %clean section, which contains rm -rf %{buildroot} (or $RPM_BUILD_ROOT). OK MUST: Each package must consistently use macros. OK MUST: The package must contain code, or permissable content. OK MUST: Large documentation files must go in a -doc subpackage. (The definition of large is left up to the packager's best judgement, but is not restricted to size. Large can refer to either size or quantity). OK MUST: If a package includes something as %doc, it must not affect the runtime of the application. To summarize: If it is in %doc, the program must run properly if it is not present. OK MUST: Header files must be in a -devel package. OK MUST: Static libraries must be in a -static package. OK MUST: Packages containing pkgconfig(.pc) files must 'Requires: pkgconfig' (for directory ownership and usability). OK MUST: If a package contains library files with a suffix (e.g. libfoo.so.1.1), then library files that end in .so (without suffix) must go in a -devel package. OK MUST: In the vast majority of cases, devel packages must require the base package using a fully versioned dependency: Requires: %{name} = %{version}-%{release} OK MUST: Packages must NOT contain any .la libtool archives, these must be removed in the spec if they are built. OK MUST: Packages containing GUI applications must include a %{name}.desktop file, and that file must be properly installed with desktop-file-install in the %install section. If you feel that your packaged GUI application does not need a .desktop file, you must put a comment in the spec file with your explanation. OK MUST: Packages must not own files or directories already owned by other packages. The rule of thumb here is that the first package to be installed should own the files or directories that other packages may rely upon. This means, for example, that no package in Fedora should ever share ownership with any of the files or directories owned by the filesystem or man package. If you feel that you have a good reason to own a file or directory that another package owns, then please present that at package review time. OK MUST: At the beginning of %install, each package MUST run rm -rf %{buildroot} (or $RPM_BUILD_ROOT). OK MUST: All filenames in rpm packages must be valid UTF-8. OK Approved
erikos, once you get this built for rawhide file a ticket with FESCO https://fedorahosted.org/fesco and ask if they can tag for f11-beta.
New Package CVS Request ======================= Package Name: gadget Short Description: XMPP server component to scale Jabber based collaboration Owners: erikos I only need a devel branch.
Steven, thanks very much for taking the time to review. I made experience with the FESCO request already - sounds good ;p
cvs done.
Package Change Request ====================== Package Name: gadget New Branches: f9 Owners: erikos bernie We need an F9 branch for the School Server spin
so, you want F-9, but not F-10? Thats going to be disruptive for people who install in F-9 and upgrade, or who want to use it in F-10. Would you consider both F-9 and F-10 branches?
(In reply to comment #14) > so, you want F-9, but not F-10? > Thats going to be disruptive for people who install in F-9 and upgrade, or who > want to use it in F-10. Would you consider both F-9 and F-10 branches? Oops, you're right Package Change Request ====================== Package Name: gadget New Branches: f9 f10 Owners: erikos bernie
Sorry for the delay. cvs done.