Red Hat Bugzilla – Bug 476056
Review Request: gnustep-back - The GNUstep backend library
Last modified: 2010-07-22 12:41:30 EDT
Spec URL: http://www.herr-schmitt.de/pub/gnustep-back/gnustep-back.spec SRPM URL: http://www.herr-schmitt.de/pub/gnustep-back/gnustep-back-0.14.0-1.fc10.src.rpm Description: This is a backend for the GNUstep gui Library which allows you to use the GNUstep gui Library on an X Windows System (other backends will be added later to allow you to use the GNUstep gui Library in other windowing environments). This package includes development headers too.
Based on the other GNUstep releated package reviews I have created a new release of the package: Spec URL: http://www.herr-schmitt.de/pub/gnustep-back/gnustep-back.spec SRPM URL: http://www.herr-schmitt.de/pub/gnustep-back/gnustep-back-0.16.0-2.fc11.src.rpm
Ping Michel
http://fedoraproject.org/wiki/Extras/Policy/StalledReviews Consider this to indicate that the review is stalled and that a response is needed soon. If there is no response in 1 week, we will move this back to NEW and someone else can review it.
Koji build: http://koji.fedoraproject.org/koji/taskinfo?taskID=2132999 rpmlint (SRPM): gnustep-back.src: W: spelling-error Summary(en_US) backend -> backed, back end, back-end gnustep-back.src: W: spelling-error %description -l en_US backend -> backed, back end, back-end gnustep-back.src: W: spelling-error %description -l en_US gui -> GUI, goo, gun gnustep-back.src: W: spelling-error %description -l en_US backends -> back ends, back-ends, backhands gnustep-back.src: W: invalid-url Source0: ftp://ftp.gnustep.org/pub/gnustep/core/gnustep-back-0.16.0.tar.gz <urlopen error ftp error: timed out> 1 packages and 0 specfiles checked; 0 errors, 5 warnings. rpmlint (RPMs): gnustep-back.x86_64: W: spelling-error Summary(en_US) backend -> backed, back end, back-end gnustep-back.x86_64: W: spelling-error %description -l en_US backend -> backed, back end, back-end gnustep-back.x86_64: W: spelling-error %description -l en_US gui -> GUI, goo, gun gnustep-back.x86_64: W: spelling-error %description -l en_US backends -> back ends, back-ends, backhands 2 packages and 0 specfiles checked; 0 errors, 4 warnings. ========================================================= REVIEW Component Status Remarks rpmlint NEEDFIX See spec language Package & spec names OK Fit for inclusion OK Code or content OK License acceptable OK License accurate NEEDFIX Old files (L)GPLv2+, some new files (L)GPLv3+. Change to LGPLv3+ and GPLv3+ and comment that only tools are GPLv3+ ? License included OK Spec language NEEDFIX I suggest switching to back-end(s) and GUI Source matches OK MD5: 31a16abe7c19914c6fe1300881f6c6ab Compiles OK Complete BRs OK Locale N/A ldconfig N/A no bundled libs OK Dir ownership NEEDFIX /usr/share/GNUstep/Documentation/Developer has no owner. Suggest adding to gnustep-filesystem No dup files NEEDFIX ANNOUNCE, NEWS, README should be removed from /usr/share/GNUstep/... -- INSTALL too as it's irrelevant to our users File perms OK UTF-8 files OK %clean OK rm on %install OK Consistent macros OK Large docs OK %doc unessential OK Headers in -devel N/A *.so.* -> *.so in -devel N/A Static in -static N/A -devel Req main N/A No .la N/A Desktop files N/A
I have update to 0.18 because this is the last stable release. Spec URL: http://www.herr-schmitt.de/pub/gnustep-back/gnustep-back.spec SRPM URL: http://www.herr-schmitt.de/pub/gnustep-back/gnustep-back-0.18.0-1.fc11.src.rpm
The new srpm does not build on F-13 -- try doing a Koji scratch build on the next update? $ koji build --scratch dist-f13 ./gnustep-back-*.src.rpm See build log: http://koji.fedoraproject.org/koji/taskinfo?taskID=2197946
Also, since the package needs updating anyway -- license field should be only "LGPLv3+ and GPLv3+", and put the note about tools as a comment above it. I believe license audits are done by automatically parsing the license fields, so we really don't want a license field failing rpmlint
There is a special issue with gnustep-back-0.18, because it use a feature which is provieded by gnustep-base-1.20. Unfortunately, I can't make an update of gnustep-base on F-13, because the so name of the library was changed. So I have added an addtional BR for gnustep-base-deve. Spec URL: http://www.herr-schmitt.de/pub/gnustep-back/gnustep-back.spec SRPM URL: http://www.herr-schmitt.de/pub/gnustep-back/gnustep-back-0.18.0-2.fc13.src.rpm
I have created a new package with make use of the new parallel build feature introduced in gnustep-make-2.4.0: Spec URL: http://www.herr-schmitt.de/pub/gnustep-back/gnustep-back.spec SRPM URL: http://www.herr-schmitt.de/pub/gnustep-back/gnustep-back-0.18.0-3.fc13.src.rpm
Hi Jochen, Could you build gnustep-make for F-13 (and preferably also F-12) and push them to the testing repository? Since I'm a comaintainer, I can do that too, but it's better if the person who writes the update also pushes it out.
Should be done.
Only two minor changes needed: - untabify line 24 - mark documentation files as %doc See below for details: #+TODO: TODO(t) WAIT(w@/!) FAIL(f@) | DONE(d) N/A(n) * TODO Review [87%] ** DONE Names [2/2] *** DONE Package name *** DONE Spec name ** DONE Meets [[http://fedoraproject.org/wiki/Packaging/Guidelines][guidelines]] ** DONE source files match upstream sha1sum: 7b6d46976bd56496d0715c4e150b85c924658b60 ** DONE License [3/3] *** DONE License is Fedora-approved *** DONE License field accurate *** DONE License included iff packaged by upstream ** DONE rpmlint [2/2] *** DONE on src.rpm minor glitch: gnustep-back.src:24: W: mixed-use-of-spaces-and-tabs (spaces: line 1, tab: line 24) if using Emacs, C-x h M-x untabify would convert all tabs to spaces *** DONE on x86_64.rpm $ rpmlint ~/Downloads/gnustep-back* 2 packages and 0 specfiles checked; 0 errors, 0 warnings. ** DONE Language & locale [3/3] *** DONE Spec in US English *** DONE Spec legible *** N/A Use %find_lang to handle locale files ** DONE Build [3/3] *** DONE Koji results http://koji.fedoraproject.org/koji/taskinfo?taskID=2311879 *** DONE BRs complete *** DONE Directory ownership ** TODO Spec inspection [7/8] *** N/A ldconfig for libraries *** DONE No duplicate files *** DONE File permissions *** DONE Filenames must be UTF-8 *** DONE Has %clean section (except F-13+: https://fedoraproject.org/wiki/Packaging/Guidelines#.25clean) *** DONE %buildroot cleaned on %install *** DONE Macro usage consistent *** TODO Documentation [2/3] **** N/A If large docs, separate -doc **** DONE %doc files are non-essential **** FAIL Documentation files tagged %doc - State "FAIL" from "TODO" [2010-07-11 Sun 22:06] \\ %{_datadir}/GNUstep/Documentation/Developer/Back/ should be marked as such
Should be fixed in: Spec URL: http://www.herr-schmitt.de/pub/gnustep-back/gnustep-back.spec SRPM URL: http://www.herr-schmitt.de/pub/gnustep-back/gnustep-back-0.18.0-4.fc13.src.rpm
Looks good. APPROVED
PS please request at least EL-6, and possibly EL-5 branches as well.
New Package CVS Request ======================= Package Name: gnustep-back Short Description: The GNUstep backend library Owners: s4504kr Branches: EL-6 InitialCC
CVS done (by process-cvs-requests.py).
Packages built for devel and EL-6