Bug 476181 - update to python-kerberos package broke freeipa
Summary: update to python-kerberos package broke freeipa
Keywords:
Status: CLOSED NEXTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: python-kerberos
Version: 10
Hardware: All
OS: Linux
high
high
Target Milestone: ---
Assignee: Rob Crittenden
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 476535
TreeView+ depends on / blocked
 
Reported: 2008-12-12 09:43 UTC by Alan Pevec
Modified: 2016-04-26 22:15 UTC (History)
4 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2008-12-18 00:36:31 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)
Rob's patch for python-kerberos-1.1 posted on ovirt-devel (3.43 KB, patch)
2008-12-12 09:44 UTC, Alan Pevec
no flags Details | Diff
Alternative patch (5.25 KB, patch)
2008-12-13 00:51 UTC, Simo Sorce
no flags Details | Diff
Slightly modified patch that accped named arguments (6.02 KB, patch)
2008-12-15 14:39 UTC, Simo Sorce
no flags Details | Diff

Description Alan Pevec 2008-12-12 09:43:08 UTC
Description of problem:
*From Perry Myers*
If I downgrade to python-kerberos-1.0-6.fc9.x86_64.rpm I can do:
    [root@management ~]# ipa-finduser foo
    No entries found for foo
But if I upgrade to python-kerberos-1.1-1.fc10.x86_64.rpm I get:
    [root@management ~]# ipa-finduser foo
    Did not receive Kerberos credentials.

*Reply from Rob Crittenden*
The problem is that PyKerberos doesn't support delegation. python-kerberos 1.0 had a patch which set the delegation flag on every request. A rather short-sighted fix, in retrospect.

A slightly better fix, which will also require a change in freeipa, is attached. This adds an optional, unnamed argument to authGSSClientInit() to request delegation. The new call signature looks like:

authGSSClientInit(service, False)

The fix for freeipa is to add a second argument, True, to krbtransport.py, ~line 37. Should look something like this, minus proper spacing:

   rc, vc = kerberos.authGSSClientInit(service, True)

Version-Release number of selected component (if applicable):
ipa-1.2.0-3.fc10
python-kerberos-1.1-1.fc10

Comment 1 Alan Pevec 2008-12-12 09:44:31 UTC
Created attachment 326716 [details]
Rob's patch for python-kerberos-1.1 posted on ovirt-devel

Comment 2 Alan Pevec 2008-12-12 13:21:17 UTC
scratch Koji builds for oVirt with the above patches:

* python-kerberos-1.1-1.1ovirt.fc10
http://koji.fedoraproject.org/koji/taskinfo?taskID=994768

* ipa-1.2.1-0.1ovirt.fc10
http://koji.fedoraproject.org/koji/taskinfo?taskID=994773

Comment 3 Simo Sorce 2008-12-13 00:51:26 UTC
Created attachment 326797 [details]
Alternative patch

I attached an alternative patch that exposes all GSS Flags.
I think this patch may have a better chance to get accepted upstream and will let us have more control on all flags in case we need to.

This patch will require a different change in krbtransport.py

 rc, vc = kerberos.authGSSClientInit(service, kerberos.GSS_C_MUTUAL_FLAG|
                                              kerberos.GSS_C_SEQUENCE_FLAG|
                                              kerberos.GSS_C_DELEG_FLAG)


I've tested this and it works fine in my F10

What do you think Rob ?

Comment 4 Rob Crittenden 2008-12-15 14:14:36 UTC
Looks good to me.

Comment 5 Simo Sorce 2008-12-15 14:39:09 UTC
Created attachment 326949 [details]
Slightly modified patch that accped named arguments

Same as my previous patch but this will accpet that arguments are passed with a name like: gssflags=kerberos.GSS_C_FOO_FLAG

Comment 6 Fedora Update System 2008-12-15 19:14:12 UTC
python-kerberos-1.1-3.fc10 has been submitted as an update for Fedora 10.
http://admin.fedoraproject.org/updates/python-kerberos-1.1-3.fc10

Comment 7 Fedora Update System 2008-12-15 19:16:46 UTC
python-kerberos-1.1-3.fc9 has been submitted as an update for Fedora 9.
http://admin.fedoraproject.org/updates/python-kerberos-1.1-3.fc9

Comment 8 Fedora Update System 2008-12-18 00:36:28 UTC
python-kerberos-1.1-3.fc10 has been pushed to the Fedora 10 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 9 Fedora Update System 2008-12-18 00:38:02 UTC
python-kerberos-1.1-3.fc9 has been pushed to the Fedora 9 stable repository.  If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.