Bug 476483 - Review Request: ghc-paths - library for information about ghc paths (renamed to ghc-ghc-paths)
Summary: Review Request: ghc-paths - library for information about ghc paths (renamed ...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Jason Tibbitts
QA Contact: Fedora Extras Quality Assurance
URL: http://hackage.haskell.org/cgi-bin/ha...
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2008-12-15 06:31 UTC by Jens Petersen
Modified: 2014-11-12 23:15 UTC (History)
3 users (show)

Fixed In Version: ghc-ghc-paths-0.1.0.9-1.el7
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2008-12-23 01:55:17 UTC
Type: ---
j: fedora-review+
gwync: fedora-cvs+


Attachments (Terms of Use)

Description Jens Petersen 2008-12-15 06:31:54 UTC
Spec URL: http://petersen.fedorapeople.org/ghc-paths/ghc-paths.spec
SRPM URL: http://petersen.fedorapeople.org/ghc-paths/ghc-paths-0.1.0.5-1.fc10.src.rpm
Description:
Knowledge of GHC's installation directories.

Needed by recent haddock to build.

Comment 1 Jason Tibbitts 2008-12-17 01:42:23 UTC
Builds fine; rpmlint says:
  ghc-paths-prof.x86_64: W: no-documentation
which is true, and not a problem.

  ghc-paths.x86_64: W: devel-file-in-non-devel-package 
   /usr/lib64/ghc-6.10.1/ghc-paths-0.1.0.5/libHSghc-paths-0.1.0.5.a
  ghc-paths-prof.x86_64: W: devel-file-in-non-devel-package 
   /usr/lib64/ghc-6.10.1/ghc-paths-0.1.0.5/libHSghc-paths-0.1.0.5_p.a
which are normal for Haskell packages.

The only real complaint I have is that the module description doesn't make a whole lot of sense.  I guess it must make sense if you understand Haskell (which I don't); that's not really unheard of when it comes to specialized modules for various languages, so I'm not going to worry about it.  Maybe you can think of something more sensible.

* source files match upstream.  sha256sum:
  ea9e97425894e3dbd7915e00e107e2e7fc07b6e8293fd2dd66a813f0673cba10  
   ghc-paths-0.1.0.5.tar.gz
* package meets naming and versioning guidelines.
* specfile is properly named, is cleanly written and uses macros consistently.
* dist tag is present.
* build root is OK.
* license field matches the actual license.
* license is open source-compatible.
* license text included in package.
* latest version is being packaged.
* BuildRequires are proper.
* %clean is present.
* package builds in mock (rawhide, x86_64).
* package installs properly.
* rpmlint has acceptable complaints.
* final provides and requires are sane:
  ghc-paths-0.1.0.5-1.fc11.x86_64.rpm
   ghc-paths-devel = 0.1.0.5-1.fc11
   ghc-paths = 0.1.0.5-1.fc11
   ghc-paths(x86-64) = 0.1.0.5-1.fc11
  =
   /bin/sh
   ghc = 6.10.1

  ghc-paths-prof-0.1.0.5-1.fc11.x86_64.rpm
   ghc-paths-prof = 0.1.0.5-1.fc11
   ghc-paths-prof(x86-64) = 0.1.0.5-1.fc11
  =
   ghc-paths = 0.1.0.5-1.fc11
   ghc-prof = 6.10.1

* owns the directories it creates.
* doesn't own any directories it shouldn't.
* no duplicates in %files.
* file permissions are appropriate.
* no generically named files
* scriptlets OK (ghc package registration and documentation indexing)
* code, not content.
* documentation is small, so no -doc subpackage is necessary.
* %docs are not necessary for the proper functioning of the package.

APPROVED

The package review process needs reviewers!  If you haven't done any package
reviews recently, please consider doing one.

Comment 2 Jens Petersen 2008-12-22 05:38:48 UTC
Thanks for the review. :)  I will improvement the description of the package when importing.


New Package CVS Request
=======================
Package Name: ghc-paths
Short Description: Interface to ghc's install directories
Owners: petersen
Branches: F-10
InitialCC: haskell-sig

Comment 3 Jens Petersen 2008-12-23 01:33:40 UTC
cvs admin done

Comment 4 Jens Petersen 2008-12-23 01:55:17 UTC
Package imported and built ghc-paths-0.1.0.5-2.fc11.

Comment 5 Jens Petersen 2009-03-09 02:59:28 UTC
My "bad" but this package should be renamed to ghc-ghc-paths since the Haskell library itself is called ghc-paths.
Renaming will keep cabal2spec-diff happy and make it easier to keep the package in sync with the templates.


New Package CVS Request
=======================
Package Name: ghc-ghc-paths
Short Description: Interface to ghc's install directories
Owners: petersen
Branches: F-10
InitialCC: haskell-sig

Comment 6 Jens Petersen 2009-03-09 03:12:47 UTC
cvs done

Comment 7 Jens Petersen 2014-10-23 03:56:55 UTC
Package Change Request
======================
Package Name: ghc-ghc-paths
New Branches: epel7 el6
Owners: petersen
InitialCC: haskell-sig

Comment 8 Gwyn Ciesla 2014-10-23 12:14:38 UTC
Git done (by process-git-requests).

Comment 9 Fedora Update System 2014-10-24 09:50:05 UTC
ghc-ghc-paths-0.1.0.9-1.el7 has been submitted as an update for Fedora EPEL 7.
https://admin.fedoraproject.org/updates/ghc-ghc-paths-0.1.0.9-1.el7

Comment 10 Fedora Update System 2014-11-12 23:15:15 UTC
ghc-ghc-paths-0.1.0.9-1.el7 has been pushed to the Fedora EPEL 7 stable repository.


Note You need to log in before you can comment on or make changes to this bug.