Spec URL: http://konradm.fedorapeople.org/fedora/SPECS/python-zdaemon.spec SRPM URL: http://konradm.fedorapeople.org/fedora/SRPMS/python-zdaemon-2.0.2-1.fc9.src.rpm Description: Daemon process control library and tools for Unix-bases systems.
Version 2.0.4 was released 2.0.4 (2009-04-20) * Version 2.0.3 broke support for relative paths to the socket (-s option and socket-name parameter), now relative paths work again as in version 2.0.2. * Fixed change log format, made table of contents nicer. * Fixed author's email address. * Removed zpkg stuff.
Bumped to 2.0.4, thanks: http://konradm.fedorapeople.org/fedora/SPECS/python-zdaemon.spec http://konradm.fedorapeople.org/fedora/SRPMS/python-zdaemon-2.0.4-1.fc10.src.rpm
Sorry, I will do the review in the next 12 hours.
Package Review ============== Package: Key: - = N/A x = Check ! = Problem ? = Not evaluated === REQUIRED ITEMS === [x] Package is named according to the Package Naming Guidelines [x] Spec file name must match the base package %{name}, in the format %{name}.spec [x] Package meets the Packaging Guidelines [x] Rpmlint output: Source RPM: [fab@laptop24 SRPMS]$ rpmlint python-zdaemon-2.0.4-1.fc10.src.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. Binary RPM(s): [fab@laptop24 noarch]$ rpmlint python-zdaemon-2.0.4-1.fc10.noarch.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. [x] Package is not relocatable [x] Buildroot is correct master : %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n) spec file: %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n) [x] Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x] License field in the package spec file matches the actual license License type: ZPLv2.1 [x] If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc [x] Spec file is legible and written in American English [x] Sources used to build the package matches the upstream source, as provided in the spec URL Upstream source: 7d358297df480abe93b6565fc0213c34 Build source: 7d358297df480abe93b6565fc0213c34 [x] Package is not known to require ExcludeArch [x] Architecture independent packages have: BuildArch: noarch [!] All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [-] The spec file handles locales properly. %find_lang used for locales [x] %{optflags} or RPM_OPT_FLAGS are honoured [-] ldconfig called in %post and %postun if required [x] %install starts with rm -rf %{buildroot} or $RPM_BUILD_ROOT [x] Package must own all directories that it creates [x] Package requires other packages for directories it uses [x] Package does not own files or directories owned by other packages [x] Package does not contain duplicates in %files [x] Permissions on files are set properly. %defattr(-,root,root,-) is in every %files section [x] Package uses nothing in %doc for runtime [x] Package has a %clean section, which contains rm -rf %{buildroot} or $RPM_BUILD_ROOT [x] Package consistently uses macros [x] Package contains code, or permissable content [x] Included filenames are in UTF-8 [-] Large documentation files are in a -doc subpackage, if required [-] Header files (.h) in -devel subpackage, if present [-] Fully versioned dependency in subpackage, if present [-] Static libraries (.a) in -static subpackage, if present [-] Package requires pkgconfig, if .pc files are present [-] Development .so files in -devel subpackage, if present [-] Package does not contain any libtool archives (.la) [-] -debuginfo subpackage is present and looks complete [x] No pre-built binaries (.a, .so*, executable) [-] Package contains a properly installed .desktop file if it is a GUI application [-] Follows desktop entry spec [-] Valid .desktop Name [-] Valid .desktop GenericName [-] Valid .desktop Categories [-] Valid .desktop StartupNotify [-] .desktop file installed with desktop-file-install in %install === SUGGESTED ITEMS === [-] Timestamps preserved with cp and install [-] Uses parallel make (%{?_smp_mflags}) [x] Latest version is packaged [x] Package does not include license text files separate from upstream [-] Description and summary sections in the package spec file contains translations for supported Non-English languages, if available [?] Reviewer should test that the package builds in mock Tested on: F10/i386 [!] Package should compile and build into binary RPMs on all supported architectures. Tested: hhttp://koji.fedoraproject.org/koji/taskinfo?taskID=1340824 [?] Package functions as described [-] Scriptlets must be sane, if used [-] The placement of pkgconfig(.pc) files is correct [-] File based requires are sane [x] Changelog in allowed format I guess that at the moment not all dependencies are available in F10, F11, and rawhide.
So nothing to fix except finish getting the dependencies in, it looks like? Thanks very much for the reviews!
Any progress with the dependencies?
python-ZConfig has been imported but not built yet; that was blocked on the zope-testing / zope-filesystem conflict, which has been fixed. I'll build it now.
The other dependencies are in Fedora and built.
python-ZConfig is built; everything should be ready.
Scratch build failed: http://koji.fedoraproject.org/koji/taskinfo?taskID=1457973
It's wired...I'm still not able to build this package on koji. http://koji.fedoraproject.org/koji/taskinfo?taskID=1709529
Ok, I will take a look later today.
Hm, weird, it's building ok locally. Maybe a missing BuildRequires.
Ok, I have it working here, however: when I build in mock, /usr/bin/zdaemon doesn't get created. When I build with plain rpmbuild, it does. So, I still have to figure out this, then I'll post a new spec/srpm.
With BuildRequires: python-setuptools it works: http://koji.fedoraproject.org/koji/taskinfo?taskID=1750614
No, it doesn't. Notice how nothing is installed to /usr/bin?
Oops, misread the build.log.
New SPEC/SRPM: http://konradm.fedorapeople.org/fedora/SPECS/python-zdaemon.spec http://konradm.fedorapeople.org/fedora/SRPMS/python-zdaemon-2.0.4-2.fc11.src.rpm
Looks good, package APPROVED
Thanks much New Package CVS Request ======================= Package Name: python-zdaemon Short Description: Python Daemon Process Control Library Owners: konradm Branches: F-12 F-11 InitialCC:
cvs done.
http://koji.fedoraproject.org/koji/taskinfo?taskID=1890575 Imported and built for rawhide.