Hide Forgot
Spec URL: http://www.scrye.com/~kevin/fedora/libspiro/libspiro.spec SRPM URL: http://www.scrye.com/~kevin/fedora/libspiro/libspiro-20071029-1.fc11.src.rpm Description: This library will take an array of spiro control points and convert them into a series of bézier splines which can then be used in the myriad of ways the world has come to use béziers. Notes: - Both fontforge and inkscape can use this library. Testing with either recompiled with this library enabled welcome.
Well, there is not much to complain about. The package is in very good condition. Just two tiny remarks: * rpmlint says: libspiro-devel.x86_64: W: no-documentation At the least the license file can go in the %doc of this subpackage. I also think that the README* files would suit the devel subpackage better. * I suggest you to make use of the %{name} and %{version} macros.
Well, you can do these changes before you commit. No need to recycle the review process since these are very minor issues. ------------------------------------------- This package (libspiro) is APPROVED by oget -------------------------------------------
>* rpmlint says: > libspiro-devel.x86_64: W: no-documentation >At the least the license file can go in the %doc of this subpackage. I also >think that the README* files would suit the devel subpackage better. ok. I can put them in both... not a big deal. >* I suggest you to make use of the %{name} and %{version} macros. Sure. Good idea. Thanks! New Package CVS Request ======================= Package Name: libspiro Short Description: Library to simplify the drawing of beautiful curves Owners: kevin Branches: devel InitialCC: Lubomir: If you would like to co-maintain this as your inkscape can use it, feel free to request in pkgdb and I will be happy to approve you.
cvs done.
Thanks for the review! Built in rawhide...closing this now.
Package Change Request ====================== Package Name: libspiro New Branches: F-9 F-10 Owners: kevin nphilipp