Bug 476776 - Review Request: python-shove - Common object storage frontend.
Summary: Review Request: python-shove - Common object storage frontend.
Keywords:
Status: CLOSED NEXTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Dave Cantrell
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2008-12-17 02:32 UTC by Luke Macken
Modified: 2016-09-20 02:39 UTC (History)
4 users (show)

Fixed In Version: 0.1.3-2.fc9
Clone Of:
Environment:
Last Closed: 2009-02-24 20:46:30 UTC
Type: ---
Embargoed:
jkeating: fedora-review+
kevin: fedora-cvs+


Attachments (Terms of Use)

Description Luke Macken 2008-12-17 02:32:48 UTC
Spec URL: http://lmacken.fedorapeople.org/rpms/python-shove.spec
SRPM URL: http://lmacken.fedorapeople.org/rpms/python-shove-0.1.3-1.fc10.src.rpm
Description:
Common object storage frontend that supports dictionary-style access, object serialization and compression, and multiple storage and caching backends.

Currently supported storage backends are:

        * Amazon S3 Web Service
        * Berkeley Source Database
        * Filesystem
        * Firebird
        * FTP
        * DBM
        * Durus
        * Memory
        * Microsoft SQL Server
        * MySQL
        * Oracle
        * PostgreSQL
        * SQLite
        * Subversion
        * Zope Object Database (ZODB)

Currently supported caching backends are:

        * Filesystem
        * Firebird
        * memcached
        * Memory
        * Microsoft SQL Server
        * MySQL
        * Oracle
        * PostgreSQL
        * SQLite

Comment 1 Jesse Keating 2008-12-17 22:32:35 UTC
Taking review.

Comment 2 Jesse Keating 2008-12-17 22:43:55 UTC
- Patch should have a comment, and info about upstream status
- Mixed use of $RPM_BUILD_ROOT and %{buildroot}
- Builds OK in mock
- rpmlint output:
python-shove.noarch: W: summary-ended-with-dot Common object storage frontend.
python-shove.noarch: E: description-line-too-long Common object storage frontend that supports dictionary-style access, object serialization and compression, and multiple storage and caching backends.
python-shove.noarch: W: non-standard-group Development/Library


- upstream source matches
- All things in store/tests/ are unlicensed.

-- Summary --
Fix up the rpmlint stuff
ask upstream about license on tests/
Fix macro usage to be consistant
Add comment on the patch.

Comment 3 Luke Macken 2009-01-06 22:20:35 UTC
http://lmacken.fedorapeople.org/rpms/python-shove-0.1.3-2.fc10.src.rpm
http://lmacken.fedorapeople.org/rpms/python-shove.spec

* Tue Jan 06 2009 Luke Macken <lmacken> 0.1.3-2
- Use consistent macros
- Add comment about patch
- Make rpmlint happy

Comment 4 Jesse Keating 2009-01-14 00:18:04 UTC
Looks good now.  Approving.

Comment 5 Luke Macken 2009-02-09 17:09:20 UTC
New Package CVS Request
=======================
Package Name: python-shove
Short Description: Common object storage frontend
Owners: lmacken
Branches: F-9 F-10 EL-4 EL-5

Comment 6 Kevin Fenzi 2009-02-10 22:05:39 UTC
cvs done.

Comment 7 Fedora Update System 2009-02-24 05:24:09 UTC
python-shove-0.1.3-2.fc10 has been submitted as an update for Fedora 10.
http://admin.fedoraproject.org/updates/python-shove-0.1.3-2.fc10

Comment 8 Fedora Update System 2009-02-24 05:24:14 UTC
python-shove-0.1.3-2.fc9 has been submitted as an update for Fedora 9.
http://admin.fedoraproject.org/updates/python-shove-0.1.3-2.fc9

Comment 9 Fedora Update System 2009-02-24 20:46:26 UTC
python-shove-0.1.3-2.fc10 has been pushed to the Fedora 10 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 10 Fedora Update System 2009-02-24 20:48:48 UTC
python-shove-0.1.3-2.fc9 has been pushed to the Fedora 9 stable repository.  If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.