Spec URL: http://akurtakov.fedorapeople.org/eclipse-cmakeed.spec SRPM URL: http://akurtakov.fedorapeople.org/eclipse-cmakeed-1.1.0-0.1.rc5.fc10.src.rpm Description: The CMakeEd plug-in provides an editor for CMake files. The plug-in registers an editor for files named CMakeLists.txt and *.cmake.
Spec URL: http://akurtakov.fedorapeople.org/eclipse-cmakeed.spec SRPM URL: http://akurtakov.fedorapeople.org/eclipse-cmakeed-1.1.0-1.fc10.src.rpm Update to 1.1.0 final.
Here's the review for this one. * The prebuilt binaries need removed in %prep ./com.cthing.cmakeed.site/plugins/com.cthing.cmakeed.core_1.0.1.jar ./com.cthing.cmakeed.site/plugins/com.cthing.cmakeed.ui_1.0.1.jar ./com.cthing.cmakeed.site/features/com.cthing.cmakeed.feature_1.0.1.jar * I believe that ./com.cthing.cmakeed.ui/doc/* should go to %doc. These don't end up in the RPM otherwise, right? * Please make the description span across 80 columns. It'll look nicer. * Macros should be used consistently. You use %{buildroot} and $RPM_BUILD_ROOT mixed. This needs corrected. You should also use %{__install} for consistency. * Please make use of the %{version} macro, e.g. in Source0 * Latest version must be packaged. Please update to 1.1.1 * There is no license file in the sources. The upstream should be notified to include a license file.
Spec URL: http://akurtakov.fedorapeople.org/eclipse-cmakeed.spec SRPM URL: http://akurtakov.fedorapeople.org/eclipse-cmakeed-1.1.2-1.fc10.src.rpm (In reply to comment #2) > Here's the review for this one. > > * The prebuilt binaries need removed in %prep > ./com.cthing.cmakeed.site/plugins/com.cthing.cmakeed.core_1.0.1.jar > ./com.cthing.cmakeed.site/plugins/com.cthing.cmakeed.ui_1.0.1.jar > ./com.cthing.cmakeed.site/features/com.cthing.cmakeed.feature_1.0.1.jar > Fixed. > * I believe that > ./com.cthing.cmakeed.ui/doc/* > should go to %doc. These don't end up in the RPM otherwise, right? No. This is documentation that is part of com.cting.cmakeed.ui_*.jar and is the documentation shown inside the editor. > > * Please make the description span across 80 columns. It'll look nicer. Fixed. > > * Macros should be used consistently. You use %{buildroot} and $RPM_BUILD_ROOT > mixed. This needs corrected. You should also use %{__install} for consistency. Fixed. > > * Please make use of the %{version} macro, e.g. in Source0 Fixed. > > * Latest version must be packaged. Please update to 1.1.1 Fixed. Updated to version 1.1.2. > > * There is no license file in the sources. The upstream should be notified to > include a license file. Fixed. Upstream released new version with License.html in it for us.
Thanks. Good to go. -------------------------------------------------- This package (eclipse-cmakeed) is APPROVED by oget --------------------------------------------------
New Package CVS Request ======================= Package Name: eclipse-cmakeed Short Description: CMake Editor plug-in for Eclipse Owners: akurtakov Branches: InitialCC:
cvs done.
Builded in rawhide.