Spec URL: http://paragn.fedorapeople.org/wordxtr/wordxtr.spec SRPM URL: http://paragn.fedorapeople.org/wordxtr/wordxtr-0.0.1-1.fc10.src.rpm Description: This package will help you to create hunspell dictionary for given input language and plain text unicode data files.
This package was reviewed during an active conversion via IRC, so I must mention that the problems mentioned inside were fixed in real time Package Review ============== Key: - = N/A x = Check ! = Problem ? = Not evaluated === REQUIRED ITEMS === [x] Package is named according to the Package Naming Guidelines. [x] Spec file name must match the base package %{name}, in the format %{name}.spec. [x] Package meets the Packaging Guidelines. [x] Package successfully compiles and builds into binary rpms on at least one supported architecture. Tested on: devel/x86_64 [x] Rpmlint output: source RPM: wordxtr.src: W: summary-ended-with-dot Create hunspell dictionary from given plain text input data files. wordxtr.src: E: description-line-too-long This package will help you to create hunspell dictionary for given input language => fixed in next release binary RPM: wordxtr.noarch: E: devel-dependency hunspell-devel => this is needed as such (for the wordlist2hunspell provided by hunspell-devel) wordxtr.noarch: W: summary-ended-with-dot Create hunspell dictionary from given plain text input data files. wordxtr.noarch: E: description-line-too-long This package will help you to create hunspell dictionary for given input language => fixed in next release [x] Package is not relocatable. [x] Buildroot is correct (%{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)) [x] Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x] License field in the package spec file matches the actual license. License type: [x] If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x] Spec file is legible and written in American English. [x] Sources used to build the package match the upstream source, as provided in the spec URL. SHA1SUM of package: ce5a9692f6357648a1de6856d34edb21ad77d168 wordxtr-0.0.1.tar.gz [x] Package is not known to require ExcludeArch. [x] All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [-] The spec file handles locales properly. [-] ldconfig called in %post and %postun if required. [x] Package must own all directories that it creates. [x] Package requires other packages for directories it uses. [x] Package does not contain duplicates in %files. [x] Permissions on files are set properly. [x] Package has a %clean section, which contains rm -rf $RPM_BUILD_ROOT. [x] Package consistently uses macros. [x] Package contains code, or permissable content. [-] Large documentation files are in a -doc subpackage, if required. [x] Package uses nothing in %doc for runtime. [-] Header files in -devel subpackage, if present. [-] Static libraries in -devel subpackage, if present. [-] Package requires pkgconfig, if .pc files are present. [-] Development .so files in -devel subpackage, if present. [-] Fully versioned dependency in subpackages, if present. [x] Package does not contain any libtool archives (.la). [-] Package contains a properly installed %{name}.desktop file if it is a GUI application. [x] Package does not own files or directories owned by other packages. [!] Final provides and requires are sane. * Duplicate BuildRequires: python-devel (by python-setuptools) => also fixed in next release === SUGGESTED ITEMS === [x] Latest version is packaged. [x] Package does not include license text files separate from upstream. [-] Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x] Reviewer should test that the package builds in mock. Tested on: devel/x86_64 [?] Package should compile and build into binary rpms on all supported architectures. Not tested but as it is a simple python script, it should work on all arch [x] Package functions as described. [-] Scriptlets must be sane, if used. [-] The placement of pkgconfig(.pc) files is correct. [-] File based requires are sane. [-] %check is present and the test passes. === Final Notes === All issues were fixed during the interactive conversation via IRC ================ *** APPROVED *** ================
Thanks for quick review. New Package CVS Request ======================= Package Name: wordxtr Short Description: hunspell dictionary creator Owners: pnemade Branches: F-10 EL-5 InitialCC:
cvs done
wordxtr-0.0.1-1.fc10 has been submitted as an update for Fedora 10. http://admin.fedoraproject.org/updates/wordxtr-0.0.1-1.fc10
wordxtr-0.0.1-1.fc10 has been pushed to the Fedora 10 stable repository. If problems still persist, please make note of it in this bug report.