Spec URL: http://chitlesh.fedorapeople.org/RPMS/perl-Hardware-Verilog-Parser.spec SRPM URL: http://chitlesh.fedorapeople.org/RPMS/perl-Hardware-Verilog-Parser-0.13-1.fc10.src.rpm Description: This module defines the complete grammar needed to parse any Verilog code. By overloading this grammar, it is possible to easily create perl scripts which run through Verilog code and perform specific functions.
Review: + package builds in mock (rawhide i386). koji build= >http://koji.fedoraproject.org/koji/taskinfo?taskID=1020609 + rpmlint is silent for SRPM and for RPM. + source files match upstream url 13e484832847e133675160862b43d933 Hardware-Verilog-Parser-0.13.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc is present. + BuildRequires are proper. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no headers or static libraries. + no .pc file present. + no -devel subpackage + no .la files. + no translations are available + Does owns the directories it creates. + no scriptlets present. + no duplicates in %files. + file permissions are appropriate. + make test outputs 1..1 ok 1 + Package perl-Hardware-Verilog-Parser-0.13-1.fc11 -> Provides: perl(Hardware::Verilog::Hierarchy) = 0.03 perl(Hardware::Verilog::Parser) = 0.13 perl(Hardware::Verilog::StdLogic) = 0.03 perl(Parse::RecDescent::PrecompiledParser) perl(PrecompiledParser) Requires: /usr/bin/perl perl >= 1:5 perl(Benchmark) perl(Data::Dumper) perl(Hardware::Verilog::Hierarchy) perl(Hardware::Verilog::Parser) perl(Hardware::Verilog::StdLogic) perl(Parse::RecDescent) perl(PrecompiledParser) perl(strict) perl(vars) Suggestions:- 1) I think this package should own %{perl_vendorlib}/Hardware/ also. ==> Can be fixed by mkdir in %install as mkdir -p $RPM_BUILD_ROOT%{perl_vendorlib}/Hardware APPROVED.
New Package CVS Request ======================= Package Name: perl-Hardware-Verilog-Parser Short Description: Complete grammar for parsing Verilog code using perl Owner: chitlesh Branches: F-9 F-10 EL-5
cvs done.
perl-Hardware-Verilog-Parser-0.13-1.fc10, perl-ModelSim-List-0.06-1.fc10, perl-Perlilog-0.3-1.fc10 has been pushed to the Fedora 10 stable repository. If problems still persist, please make note of it in this bug report.