Spec URL: http://mtasaka.fedorapeople.org/Review_request/rubygem-nokogiri/rubygem-nokogiri.spec SRPM URL: http://mtasaka.fedorapeople.org/Review_request/rubygem-nokogiri/rubygem-nokogiri-1.1.0-1.fc.src.rpm Koji scratch build - For dist-f11: http://koji.fedoraproject.org/koji/taskinfo?taskID=1020864 - For dist-f10: http://koji.fedoraproject.org/koji/taskinfo?taskID=1020868 Description: Nokogiri parses and searches XML/HTML very quickly, and also has correctly implemented CSS3 selector support as well as XPath support. Nokogiri also features an Hpricot compatibility layer to help ease the change to using correct CSS and XPath. Note: This RubyGem based rpm creates arch-dependent binary rpms. The following guideline [1] was approved by FPC/FESCo [2][3] and should be applied to this package. [1] https://fedoraproject.org/wiki/PackagingDrafts/RubyGem_with_C_code_spot [2] http://fedoraproject.org/wiki/Packaging/Minutes/20081209 [3] https://www.redhat.com/archives/fedora-devel-list/2008-December/msg02221.html
http://mtasaka.fedorapeople.org/Review_request/rubygem-nokogiri/rubygem-nokogiri.spec http://mtasaka.fedorapeople.org/Review_request/rubygem-nokogiri/rubygem-nokogiri-1.1.1-1.fc.src.rpm * Thu Jan 15 2009 Mamoru Tasaka <mtasaka.u-tokyo.ac.jp> - 1.1.1-1 - 1.1.1 For F-11: http://koji.fedoraproject.org/koji/taskinfo?taskID=1055417 For F-10: http://koji.fedoraproject.org/koji/taskinfo?taskID=1055424
No license file is included in the .gem. Can you ask the upstream to put a COPYING or LICENSE file into the gem? Not a negative on the review, but a suggestion for upstream if you could pass it along. In the spec the file hoe.rb is deleted. Is this package dependant on hoe? You should add rubygem(hoe) as a dependency. The install target directory used is the relative path "./" rather than %{buildroot} macro. Please fix that. Perhaps I'm misreading, but I don't see where the RPM claims to own %{geminstdir}, instead it just lists the contents of that directory. Can you make it more explicit? For the subpackage ruby-nokogiri, the Requires: does not match the packaging guidelines: the guideline says the non-gem should require "rubygem(%{name})", but the spec file has "%{name}". Please fix that.
Thank you for initial comments. (In reply to comment #2) > No license file is included in the .gem. Can you ask the upstream to put a > COPYING or LICENSE file into the gem? Not a negative on the review, but a > suggestion for upstream if you could pass it along. - The license clause is included in README{,.ja}.txt. > In the spec the file hoe.rb is deleted. Is this package dependant on hoe? You > should add rubygem(hoe) as a dependency. - No. This is (hoe.rb) only needed for Rakefile and so not needed at runtime. > The install target directory used is the relative path "./" rather than > %{buildroot} macro. Please fix that. - In this case (i.e. in the case rubygem creates C module) the way of packaging gem into rpm is different. Actually I wrote the packaging draft and it was accepted by FPC/FESCo. Please refer to my first comment on this bug. > > Perhaps I'm misreading, but I don't see where the RPM claims to own > %{geminstdir}, instead it just lists the contents of that directory. Can you > make it more explicit? - Well, I already write this explicitly. ------------------------------------------------------------- %files %defattr(-,root, root,-) %{ruby_sitearch}/%{gemname}/ %dir %{geminstdir}/ <------------------------------- %doc %{geminstdir}/[A-Z]* %{geminstdir}/[a-l]*/ ------------------------------------------------------------- > For the subpackage ruby-nokogiri, the Requires: does not match the packaging > guidelines: the guideline says the non-gem should require "rubygem(%{name})", > but the spec file has "%{name}". Please fix that. - "Requires %{name} = %{version}-%{release}" will pull in rubygem(%{gemname}), and this dependency is more strict than "Requires: rubygem(%{gemname})", so this should be okay.
APPROVED by Darryl Pierce (dpierce)
Thank you! New Package CVS Request ======================= Package Name: rubygem-nokogiri Short Description: An HTML, XML, SAX, and Reader parser Owners: mtasaka Branches: F-10 F-9 InitialCC: (nobody)
cvs done.
Rebuilt on all branches, submitted push request for F-10/9, closing. Thank you for reviewing and CVS procedure.
Package Change Request ====================== Package Name: rubygem-nokogiri New Branches: EL-4 EL-5 Owners: tremble
@ Mark It seems that you are not in Fedora's packager group. Any person who wants to maintain packages on Fedora/EPEL must be in this group and to get yourself added in package group, you must get sponsored first: http://fedoraproject.org/wiki/PackageMaintainers/HowToGetSponsored
To CVS admins: Mark is now sponsored by me. As I have no intention to maintain packages on EPEL, I am happy with that Mark will maintain this on EPEL.
Package Change Request ====================== Package Name: rubygem-nokogiri New Branches: epel7 Owners: jstribny humaton
Branch exist.