Spec URL: http://avi.alkalay.net/software/id3mtag/ SRPM URL: http://avi.alkalay.net/software/id3mtag/ Description: ID3 mass tagger is a tool for manipulating id3 and id3v2 tags in multiple files. It can generate tag fields from the filename and other variables, and/or rename files, using an intuitive syntax.
The rpmlint output... [fab@laptop024 i386]$ rpmlint id3mtag* id3mtag.i386: W: invalid-license Two-clause BSD id3mtag-debuginfo.i386: E: empty-debuginfo-package id3mtag-debuginfo.i386: W: invalid-license Two-clause BSD 2 packages and 0 specfiles checked; 1 errors, 2 warnings. [fab@laptop024 SRPMS]$ rpmlint id3mtag-0.78-1.fc9.src.rpm id3mtag.src: W: invalid-license Two-clause BSD 1 packages and 0 specfiles checked; 0 errors, 1 warnings. For more details check https://fedoraproject.org/wiki/Licensing Some comments on your spec file - CHANGES, COPYING, and so on should be placed in the %files section %doc CHANGES COPYING %doc %{_docdir}/%{name} looks a bit unusual - Don't mix $RPM_BUILD_ROOT and %{buildroot} https://fedoraproject.org/wiki/Packaging/Guidelines#Using_.25.7Bbuildroot.7D_and_.25.7Boptflags.7D_vs_.24RPM_BUILD_ROOT_and_.24RPM_OPT_FLAGS - Is 'Prefix: %{_usr}' really needed? https://fedoraproject.org/wiki/Packaging/Guidelines#Relocatable_packages - Remove the 'fc9' in the changelog entry '...com> - 0.78-1' https://fedoraproject.org/wiki/Packaging/Guidelines#Changelogs - %{?_smp_mflags} and %{optflags} are not honored in the %build section
All fixed. Please recheck updates at http://avi.alkalay.net/software/id3mtag/
Two other small things - BuildRoot tag doesn't match the guidelines https://fedoraproject.org/wiki/Packaging/Guidelines#BuildRoot_tag - the manpage should not have %doc I will try to make an informal review today. I'm not a sponsor but I can help you to make some progress with this package till a sponsor will take care of it.
ping?
Are you still interested in maintaining this package?
I will close this bug as NOTABUG if no response is received from the reporter within ONE WEEK.
Once closing. If someone wants to import this package into Fedora, please file a new review request and mark this bug as a duplicate of the new one. Thank you!
*** This bug has been marked as a duplicate of bug 594064 ***