Spec URL: http://fab.fedorapeople.org/packages/SRPMS/fswebcam.spec SRPM URL: http://fab.fedorapeople.org/packages/SRPMS/fswebcam-20070108-3.fc9.src.rpm Project URL: http://www.firestorm.cx/fswebcam/ Description: A tiny and flexible webcam program for capturing images from a V4L1/V4L2 device, and overlaying a caption or image. Koji scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=1022775 rpmlint output: [fab@laptop024 i386]$ rpmlint fswebcam* 2 packages and 0 specfiles checked; 0 errors, 0 warnings. [fab@laptop024 SRPMS]$ rpmlint fswebcam-20070108-3.fc9.src.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. This review request based on https://bugzilla.redhat.com/show_bug.cgi?id=222009
*** Bug 222009 has been marked as a duplicate of this bug. ***
Package Review ============== Key: - = N/A x = Check ! = Problem ? = Not evaluated === REQUIRED ITEMS === [x] Package is named according to the Package Naming Guidelines. [x] Spec file name must match the base package %{name}, in the format %{name}.spec. [x] Package meets the Packaging Guidelines. [x] Package successfully compiles and builds into binary rpms on at least one supported architecture. Tested on: devel/x86_64 [x] Rpmlint output: source RPM: empty binary RPM:empty [x] Package is not relocatable. [x] Buildroot is correct (%{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)) [x] Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x] License field in the package spec file matches the actual license. License type:GPLv2 [x] If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x] Spec file is legible and written in American English. [x] Sources used to build the package match the upstream source, as provided in the spec URL. SHA1SUM of package: 69df690a91dd5902b5fe3d6b5c6a140fe242f002 fswebcam-20070108.tar.gz [x] Package is not known to require ExcludeArch. [x] All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [-] The spec file handles locales properly. [-] ldconfig called in %post and %postun if required. [x] Package must own all directories that it creates. [x] Package does not contain duplicates in %files. [x] Permissions on files are set properly. [x] Package has a %clean section, which contains rm -rf %{buildroot}. [x] Package consistently uses macros. [x] Package contains code, or permissable content. [-] Large documentation files are in a -doc subpackage, if required. [x] Package uses nothing in %doc for runtime. [-] Header files in -devel subpackage, if present. [-] Static libraries in -devel subpackage, if present. [-] Package requires pkgconfig, if .pc files are present. [-] Development .so files in -devel subpackage, if present. [-] Fully versioned dependency in subpackages, if present. [x] Package does not contain any libtool archives (.la). [-] Package contains a properly installed %{name}.desktop file if it is a GUI application. [x] Package does not own files or directories owned by other packages. [x] Final provides and requires are sane. === SUGGESTED ITEMS === [x] Latest version is packaged. [x] Package does not include license text files separate from upstream. [-] Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x] Reviewer should test that the package builds in mock. Tested on: devel/x86_64 + koji scratch build [x] Package should compile and build into binary rpms on all supported architectures. Tested on: koji scratch build [?] Package functions as described. [-] Scriptlets must be sane, if used. [-] The placement of pkgconfig(.pc) files is correct. [-] File based requires are sane. [-] %check is present and the test passes. ================ *** APPROVED *** ================
New Package CVS Request ======================= Package Name: fswebcam Short Description: Tiny and flexible webcam program Owners: fab Branches: F-9 F-10 InitialCC:
cvs done.
Thanks guys for the cvs and the review.
fswebcam-20070108-3.fc10 has been submitted as an update for Fedora 10. http://admin.fedoraproject.org/updates/fswebcam-20070108-3.fc10
fswebcam-20070108-3.fc9 has been submitted as an update for Fedora 9. http://admin.fedoraproject.org/updates/fswebcam-20070108-3.fc9
fswebcam-20070108-3.fc9 has been pushed to the Fedora 9 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing-newkey update fswebcam'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F9/FEDORA-2008-11852
fswebcam-20070108-3.fc10 has been pushed to the Fedora 10 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update fswebcam'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F10/FEDORA-2008-11864
I've tested the x86_64 and ppc packages, both work as expected. I'm getting a "500 Internal error" on the fedoraproject.org site when I try to submit feedback.
fswebcam-20070108-3.fc9 has been pushed to the Fedora 9 stable repository. If problems still persist, please make note of it in this bug report.
fswebcam-20070108-3.fc10 has been pushed to the Fedora 10 stable repository. If problems still persist, please make note of it in this bug report.