Spec URL: http://chitlesh.fedorapeople.org/RPMS/perl-Verilog-CodeGen.spec SRPM URL: http://chitlesh.fedorapeople.org/RPMS/perl-Verilog-CodeGen-0.9.4-1.fc10.src.rpm Description: Provides an object-oriented environment to generate Verilog code for modules and testbenches. The Verilog::CodeGen module provides two functions, one to create a code template and another to create a Perl module which contains the device library. This module , DeviceLibs::YourDesign, provides the class methods and contains the objects for every Verilog module; the objects are created based on a fixed template. The purpose of this module is to allow the generation of customized Verilog modules. A Verilog module can have a large number of parameters like input and output bus width, buffer depth, signal delay etc. The code generator allows to create an object that will generate the Verilog module code for arbitraty values of the parameters.
Review: + package builds in mock (rawhide i386). koji Build => http://koji.fedoraproject.org/koji/taskinfo?taskID=1024296 + rpmlint is silent for SRPM and for RPM. + source files match upstream url 6f036f2906bd0993b02792cacb09f309 Verilog-CodeGen-0.9.4.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc is present. + BuildRequires are proper. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no headers or static libraries. + no .pc file present. + no -devel subpackage + no .la files. + no translations are available + Does owns the directories it creates. + no scriptlets present. + no duplicates in %files. + file permissions are appropriate. + make test gave ok 1 ok 2 ok 3 + Package perl-Verilog-CodeGen-0.9.4-1.fc11 => Provides: perl(DeviceLibs::DesignName) perl(Verilog::CodeGen) perl(Verilog::CodeGen::Gui) Requires: perl(Cwd) perl(DeviceLibs::DesignName) perl(Verilog::CodeGen) perl(lib) perl(sigtrap) perl(strict) perl(vars) As this package don't have any BR on perl-verilog and perl-Verilog-Readmem, I reviewed this package easily. But I prefer to wait to approve this till reviews 476386 and 476364 will get finished and built in rawhide at least.
APPROVED. Tested by installing perl-Verilog and perl-Verilog-Readmem
Unowned directory: %{perl_vendorlib}/Verilog All perl modules must own all directories they use under %{perl_vendorlib}.
I confused over this in SPEC # owns directory : %%{perl_vendorlib}/Verilog/ Requires: perl-Verilog-Readmem But anyway you are right. perl packages must own all directories they use under %{perl_vendorlib}. Chitlesh, 1) drop following lines from spec # owns directory : %%{perl_vendorlib}/Verilog/ Requires: perl-Verilog-Readmem 2) change %files to only %doc Changes README %{perl_vendorlib}/* %{_mandir}/man3/*
so you prefer 2 packages owning the same directory ? in this case: perl-Verilog-Readmem already owns %%{perl_vendorlib}/Verilog
(In reply to comment #5) > so you prefer 2 packages owning the same directory ? > > in this case: > perl-Verilog-Readmem already owns %%{perl_vendorlib}/Verilog Yes. Just check here http://fedoraproject.org/wiki/Packaging/Perl#Directory_Ownership
Ok, I will update it accordingly before committing New Package CVS Request ======================= Package Name: perl-Verilog-Codegen Short Description: Verilog code generator Branches: F-9 F-10 EL-5 Owner: chitlesh
cvs done.
FYI, this package failed my personal "use and test" test. It requires some fixes with respect to perl-Tk. Since no other package depends on it, I first focus on fixing some gcc4.4 bugs left which my comaintainers have not yet responded.
Kevin, were the cvs branches created ? Checking out module: 'perl-Verilog-CodeGen' cvs server: cannot find module `perl-Verilog-CodeGen' - ignored cvs [checkout aborted]: cannot expand modules ERROR: "perl-Verilog-CodeGen" module does not exist in cvs.
Strange. Try now, I think it's working... not sure what happened there. ;(
(In reply to comment #11) > Strange. Try now, I think it's working... not sure what happened there. ;( https://admin.fedoraproject.org/pkgdb/packages/index/perl-Verilog* lists perl-Verilog -- Verilog parsing routines perl-Verilog-Codegen -- Verilog code generator perl-Verilog-Readmem -- Parse Verilog $readmemh or $readmemb but doesn't list perl-Verilog-CodeGen (Note: *-CodeGen vs. *-Codegen)
Yes Ralf,I made a typo. Package CVS Change Request ======================= Package Name: perl-Verilog-CodeGen Short Description: Verilog code generator Branches: F-9 F-10 EL-5 Owner: chitlesh
perl-Verilog-CodeGen-0.9.4-1.fc9 has been submitted as an update for Fedora 9. http://admin.fedoraproject.org/updates/perl-Verilog-CodeGen-0.9.4-1.fc9
perl-Verilog-CodeGen-0.9.4-1.fc10 has been submitted as an update for Fedora 10. http://admin.fedoraproject.org/updates/perl-Verilog-CodeGen-0.9.4-1.fc10
perl-Verilog-CodeGen-0.9.4-1.fc9 has been pushed to the Fedora 9 stable repository. If problems still persist, please make note of it in this bug report.
perl-Verilog-CodeGen-0.9.4-1.fc10 has been pushed to the Fedora 10 stable repository. If problems still persist, please make note of it in this bug report.