Bug 478429 (tinc) - Review Request: tinc - A virtual private network daemon
Summary: Review Request: tinc - A virtual private network daemon
Keywords:
Status: CLOSED ERRATA
Alias: tinc
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Felix Kaechele
QA Contact: Fedora Extras Quality Assurance
URL: http://www.tinc-vpn.org/
Whiteboard:
Depends On:
Blocks: 1065582
TreeView+ depends on / blocked
 
Reported: 2008-12-29 21:56 UTC by Fabian Affolter
Modified: 2014-02-17 12:58 UTC (History)
7 users (show)

Fixed In Version: tinc-1.0.11-1.fc13
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2010-03-09 03:12:19 UTC
Type: ---
Embargoed:
felix: fedora-review+
gwync: fedora-cvs+


Attachments (Terms of Use)
m4 macro patch for tinc ppc (407 bytes, patch)
2009-04-17 20:01 UTC, Felix Kaechele
no flags Details | Diff

Description Fabian Affolter 2008-12-29 21:56:58 UTC
Spec URL: http://fab.fedorapeople.org/packages/SRPMS/tinc.spec
SRPM URL: http://fab.fedorapeople.org/packages/SRPMS/tinc-1.0.9-1.fc9.src.rpm

Project URL: http://www.tinc-vpn.org/

Description:
tinc is a Virtual Private Network (VPN) daemon that uses tunnelling
and encryption to create a secure private network between hosts on
the Internet. Because the tunnel appears to the IP level network
code as a normal network device, there is no need to adapt any
existing software. This tunnelling allows VPN sites to share
information with each other over the Internet without exposing any
information to others.

Koji scratch build:
http://koji.fedoraproject.org/koji/taskinfo?taskID=1025251

rpmlint output:
[fab@laptop024 i386]$ rpmlint tinc*
2 packages and 0 specfiles checked; 0 errors, 0 warnings.

[fab@laptop024 SRPMS]$ rpmlint tinc-1.0.9-1.fc9.src.rpm 
1 packages and 0 specfiles checked; 0 errors, 0 warnings.

This package fails at the moment on ppc.
-> configure: error: OpenSSL libraries not found.

All other archs all ok.

Comment 1 Till Maas 2009-01-02 21:30:44 UTC
(In reply to comment #0)

> This package fails at the moment on ppc.
> -> configure: error: OpenSSL libraries not found.

Is this a bug in the OpenSSL package? What is the plan to fix this?

Comment 2 Fabian Affolter 2009-01-10 22:23:36 UTC
First I though that this is only a temporary problem but it seams not.  I'm trying to figure out if it's a bug in the openssl package or one in tinc.

Comment 3 Fabian Affolter 2009-03-06 21:55:36 UTC
It's not a temporary issue.

Comment 4 Felix Kaechele 2009-04-10 20:47:12 UTC
Let's see what we can do here :)

Comment 5 Felix Kaechele 2009-04-17 20:01:30 UTC
Created attachment 340081 [details]
m4 macro patch for tinc ppc

tinc builds for me with this patch on ppc.
However you will need to BuildReq autoconf then and run autoreconf -f -i in %prep.
You should probably upstream this if possible. AFAIK SHA1_Init also indicates that openssl can be used with SHA1 stuff.

You may test yourself. If you don't have a ppc testmachine check https://fedoraproject.org/wiki/Test_Machine_Resources_For_Package_Maintainers

Comment 6 Fabian Affolter 2009-04-19 16:00:53 UTC
Thanks Felix for the patch.  Are you able to do a scratch build on koji?

Comment 7 Felix Kaechele 2009-04-19 16:23:31 UTC
There you go:
http://koji.fedoraproject.org/koji/taskinfo?taskID=1308030

However I changed the patch to already include the changes autoreconf -f -i generates. Because autoreconf depends on much more than just autoconf. As it would add a lot of additional BuildReqs I chose to patch the whole thing. Unfortunately the patch is 1.6M in size. So it would probably be the best to upstream it if possible (although I think that the problem might be Fedora specific).

Comment 8 Felix Kaechele 2009-06-21 11:20:10 UTC
Ping.

Comment 9 Fabian Affolter 2009-07-30 07:51:30 UTC
Thanks for your patience.  I guess that I will pick this up again soon.

Comment 10 Christoph Wickert 2009-10-17 21:49:00 UTC
Quiting from 

"If the package does not successfully compile, build or work on an architecture, then those architectures should be listed in the spec in ExcludeArch. Each architecture listed in ExcludeArch MUST have a bug filed in bugzilla, describing the reason that the package does not compile/build/work on that architecture. The bug number MUST be placed in a comment, next to the corresponding ExcludeArch line."

This means you'll need to file a bug against tinc (e. g. "tinc wont build on ppc") once the package is in bugzilla, let *that* bug block bug 179260 and add its # to the spec. If you use this review to block the tracker the bug will be closed when tinc is in the repos and not when the problem is really solved.

Removing the blocker on bug 179260 now.

Comment 11 Christoph Wickert 2009-10-19 17:48:10 UTC
BTW: tinc 1.0.10 is out.

Comment 12 Felix Kaechele 2009-12-11 03:13:38 UTC
Is there still something happening here? I'm working through my Bugzilla review queue right now. If you're not interested in this anymore I'd like to close this for now.

Comment 13 Fabian Affolter 2009-12-21 11:36:37 UTC
Sorry for my delay.

Here are the updated files:

Spec URL: http://fab.fedorapeople.org/packages/SRPMS/tinc.spec
SRPM URL: http://fab.fedorapeople.org/packages/SRPMS/tinc-1.0.11-1.fc12.src.rpm

Koji scratch build:
http://koji.fedoraproject.org/koji/taskinfo?taskID=1882856

Comment 14 Felix Kaechele 2010-01-05 13:03:34 UTC
[+] source files match upstream: sha256sum
add18b68710a08dd1d209f177154f9d8c7614031050abf16139dd9c3fc56be84  tinc-1.0.11.tar.gz
add18b68710a08dd1d209f177154f9d8c7614031050abf16139dd9c3fc56be84  ../SOURCES/tinc-1.0.11.tar.gz
[+] package meets naming and versioning guidelines.
[+] spec is properly named, cleanly written, and uses macros consistently.
[+] dist tag is present.
[+] build root is correct.
[+] license field matches the actual license.
[+] license is open source-compatible.
[+] license text included in package.
[+] latest version is being packaged.
[+] BuildRequires are proper.
[+] compiler flags are appropriate.
[+] %clean is present. 
[+] package builds in mock.
[+] package installs properly.
[+] debuginfo package looks complete.
[+] rpmlint is silent.
[+] final provides and requires are sane
[NA] %check is present and all tests pass:
[+] no shared libraries are added to the regular linker search paths.
[+] owns the directories it creates. 
[+] doesn't own any directories it shouldn't.
[+] no duplicates in %files.
[+] file permissions are appropriate.
[NA] scriptlets match those on ScriptletSnippets page.
[+] code, not content.
[+] documentation is small, so no -docs subpackage is necessary.
[+] %docs are not necessary for the proper functioning of the package.
[+] no headers.
[+] no pkgconfig files.
[+] no libtool .la droppings.
[N/A] desktop files valid and installed properly.

APPROVED!

Comment 15 Fabian Affolter 2010-02-09 09:33:19 UTC
Thanks for the review, Felix

Comment 16 Fabian Affolter 2010-02-09 09:41:41 UTC
New Package CVS Request
=======================
Package Name: tinc
Short Description: A virtual private network daemon
Owners: fab
Branches: F-11 F-12
InitialCC:

Comment 17 Jason Tibbitts 2010-02-09 21:02:34 UTC
CVS done (by process-cvs-requests.py).

Comment 18 Robert Townley 2010-02-11 21:21:55 UTC
(In reply to comment #16)
> New Package CVS Request
> =======================
> Package Name: tinc
> Short Description: A virtual private network daemon
> Owners: fab
> Branches: F-11 F-12
> InitialCC:    

Can we change Short Description
A peer-to-peer meshed virtual private network deamon.

Comment 19 Fabian Affolter 2010-02-18 13:28:16 UTC
Sure, I will change the description before CVS import.

Comment 20 Fedora Update System 2010-02-24 21:39:04 UTC
tinc-1.0.11-1.fc12 has been submitted as an update for Fedora 12.
http://admin.fedoraproject.org/updates/tinc-1.0.11-1.fc12

Comment 21 Fedora Update System 2010-02-24 21:39:11 UTC
tinc-1.0.11-1.fc11 has been submitted as an update for Fedora 11.
http://admin.fedoraproject.org/updates/tinc-1.0.11-1.fc11

Comment 22 Fedora Update System 2010-02-24 21:39:16 UTC
tinc-1.0.11-1.fc13 has been submitted as an update for Fedora 13.
http://admin.fedoraproject.org/updates/tinc-1.0.11-1.fc13

Comment 23 Fedora Update System 2010-02-24 21:40:06 UTC
tinc-1.0.11-1.fc12 has been submitted as an update for Fedora 12.
http://admin.fedoraproject.org/updates/tinc-1.0.11-1.fc12

Comment 24 Fedora Update System 2010-02-24 21:40:12 UTC
tinc-1.0.11-1.fc11 has been submitted as an update for Fedora 11.
http://admin.fedoraproject.org/updates/tinc-1.0.11-1.fc11

Comment 25 Fedora Update System 2010-02-24 21:40:26 UTC
tinc-1.0.11-1.fc13 has been submitted as an update for Fedora 13.
http://admin.fedoraproject.org/updates/tinc-1.0.11-1.fc13

Comment 26 Fedora Update System 2010-02-25 12:46:19 UTC
tinc-1.0.11-1.fc13 has been pushed to the Fedora 13 testing repository.  If problems still persist, please make note of it in this bug report.
 If you want to test the update, you can install it with 
 su -c 'yum --enablerepo=updates-testing update tinc'.  You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F13/FEDORA-2010-2855

Comment 27 Fedora Update System 2010-02-26 03:37:09 UTC
tinc-1.0.11-1.fc12 has been pushed to the Fedora 12 testing repository.  If problems still persist, please make note of it in this bug report.
 If you want to test the update, you can install it with 
 su -c 'yum --enablerepo=updates-testing update tinc'.  You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F12/FEDORA-2010-2910

Comment 28 Fedora Update System 2010-02-26 03:46:23 UTC
tinc-1.0.11-1.fc11 has been pushed to the Fedora 11 testing repository.  If problems still persist, please make note of it in this bug report.
 If you want to test the update, you can install it with 
 su -c 'yum --enablerepo=updates-testing update tinc'.  You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F11/FEDORA-2010-2961

Comment 29 Fedora Update System 2010-03-09 03:12:12 UTC
tinc-1.0.11-1.fc12 has been pushed to the Fedora 12 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 30 Fedora Update System 2010-03-09 03:25:05 UTC
tinc-1.0.11-1.fc11 has been pushed to the Fedora 11 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 31 Fedora Update System 2010-03-09 03:32:32 UTC
tinc-1.0.11-1.fc13 has been pushed to the Fedora 13 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 32 Fabian Affolter 2014-02-16 08:18:18 UTC
Package Change Request
======================
Package Name: tinc
New Branches: el5, el6, epel7
Owners: fab

Comment 33 Gwyn Ciesla 2014-02-17 12:58:32 UTC
Git done (by process-git-requests).


Note You need to log in before you can comment on or make changes to this bug.