Bug 478565 - Review Request: gupnp-igd - Library to handle UPnP IGD port mapping
Summary: Review Request: gupnp-igd - Library to handle UPnP IGD port mapping
Keywords:
Status: CLOSED NEXTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Denis Leroy
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2009-01-01 03:45 UTC by Brian Pepple
Modified: 2009-01-21 00:14 UTC (History)
3 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2009-01-21 00:14:30 UTC
Type: ---
Embargoed:
denis: fedora-review+
kevin: fedora-cvs+

Attachments (Terms of Use)

Description Brian Pepple 2009-01-01 03:45:20 UTC 
Spec URL: http://bpepple.fedorapeople.org/rpms/gupnp-igd.spec
SRPM URL: http://bpepple.fedorapeople.org/rpms/gupnp-igd-0.1.1-1.fc10.src.rpm
Description: gupnp-igd is a library to handle UPnP IGD port mapping.

Scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=1028365
Comment 1 Denis Leroy 2009-01-18 21:54:06 UTC 
* Package name OK
* Source md5sum correct
* License is LGPLv2+
* Package works (able to compile tests and examples)
* Buidls, BR and R are OK
* %files section OK

* rpmlint

  - mixed-use of-spaces-and-tabs : can be ignored
  - unused-direct-shlib-dependency : could use the --as-needed sed trick, but not a blocker


Warning:
 on Fedora branches <= 10, the devel package will Require gupnp-devel

Package is APPROVED.
Comment 2 Brian Pepple 2009-01-18 22:53:14 UTC 
(In reply to comment #1)
> Warning:
>  on Fedora branches <= 10, the devel package will Require gupnp-devel

Yeah, I'm not planning on adding this to any branches <= 10.  Thanks for the review.
Comment 3 Brian Pepple 2009-01-18 22:55:25 UTC 
New Package CVS Request
=======================
Package Name: gupnp-igd
Short Description: Library to handle UPnP IGD port mapping
Owners: bpepple
Branches: 
InitialCC:
Comment 4 Kevin Fenzi 2009-01-19 22:58:44 UTC 
cvs done.
Comment 5 Brian Pepple 2009-01-21 00:14:30 UTC 
Built for rawhide.  Denis, thanks again for review.
Note You need to log in before you can comment on or make changes to this bug.