Spec URL: http://fab.fedorapeople.org/packages/SRPMS/dateshift.spec SRPM URL: http://fab.fedorapeople.org/packages/SRPMS/dateshift-1.1-1.fc9.src.rpm Project URL: http://www.hornby.dsl.pipex.com/dateshift/ Description: Dateshift is a tool for shifting date/time. In particular it allows a process or set of process to run with a different clock setting, without having to change the system clock. This is useful because changing the system clock requires root privilege and is inconvenient on shared machines. Koji scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=1030082 rpmlint output: [fab@laptop024 i386]$ rpmlint dateshift* dateshift.i386: W: shared-lib-calls-exit /usr/lib/libdsintercept.so.0.0.0 exit dateshift-devel.i386: W: no-documentation 3 packages and 0 specfiles checked; 0 errors, 2 warnings. [fab@laptop024 SRPMS]$ rpmlint dateshift-1.1-1.fc9.src.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. I reported to upstream about the rpmlint warning. But so far I have no answer.
Review ======= Good: - rpmlint checks return: dateshift.x86_64: W: shared-lib-calls-exit /usr/lib64/libdsintercept.so.0.0.0 exit.5 dateshift-devel.x86_64: W: no-documentation You should continue trying to get upstream to resolve this, but I won't block this package review on it. - package meets naming guidelines - package meets packaging guidelines - spec file legible, in am. english - source matches upstream (0bcc71038686a1afdd0713b01eb81e7652634fa6) - license text in %doc - package compiles on devel (x86_64) - no missing BR - no unnecessary BR - no locales - not relocatable - owns all directories that it creates - no duplicate files - permissions ok - %clean ok - macro use consistent - code, not content - no need for -docs - nothing in %doc affects runtime - no need for .desktop file Bad: - License tag (GPLv2) is wrong. License tag should be GPLv2+. ***** Please fix the license tag before you commit to cvs, but this package is approved.
Thanks Tom for the review.
New Package CVS Request ======================= Package Name: dateshift Short Description: A date/time test tool Owners: fab Branches: F-9 F-10 InitialCC:
cvs done.
dateshift-1.1-2.fc10 has been pushed to the Fedora 10 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update dateshift'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F10/FEDORA-2009-0996
dateshift-1.1-2.fc9 has been pushed to the Fedora 9 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing-newkey update dateshift'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F9/FEDORA-2009-1024
Was pushed to stable https://admin.fedoraproject.org/updates/F9/FEDORA-2009-1024 https://admin.fedoraproject.org/updates/F10/FEDORA-2009-0996