Spec URL: http://mmahut.fedorapeople.org/reviews/cdk/cdk.spec SRPM URL: http://mmahut.fedorapeople.org/reviews/cdk/cdk-5.0.20081105-1.fc8.src.rpm Koji Build: http://koji.fedoraproject.org/koji/taskinfo?taskID=1031867 Description: Cdk stands for 'Curses Development Kit' and it currently contains 21 ready to use widgets which facilitate the speedy development of full screen curses programs. This little project of mine started as a test to see how compatible my Linux machine was to other UNIX breeds. While doing this I discovered Ncurses, and played with it. These widgets are the result of over a years worth of playing.
1.) Description is stupid. You see :) 2.) Too much documentation in main package %doc CHANGES COPYING EXPANDING INSTALL NOTES README TODO VERSION examples demos I think you can move at lease examples and demos (maybe todo, expanding, ...) to -devel subpackage. 3.) Why do you chmod a symlink? chmod +x $RPM_BUILD_ROOT%{_libdir}/*.so 4.) You don't know/decide if the manual gets compressed %{_mandir}/man3/*.gz Please remove the .gz from the end
1) Fixed. :) 2) Done. 3) Becuase of this rpmlint warning: cdk.i386: W: unstripped-binary-or-object /usr/lib/libcdk.so.5.0 4) Done. Spec URL: http://mmahut.fedorapeople.org/reviews/cdk/cdk.spec SRPM URL: http://mmahut.fedorapeople.org/reviews/cdk/cdk-5.0.20081105-1.fc8.src.rpm
Everything seems fine now; thanks! APPROVED
Thank you for the review Lubomir. New Package CVS Request ======================= Package Name: cdk Short Description: Curses Development Kit Owners: mmahut Branches: F-9 F-10 EL-5
cvs done.
Package Change Request ====================== Package Name: cdk New Branches: el6 epel7 Owners: cicku comaintainer here.
Git done (by process-git-requests).
cdk-5.0.20140118-1.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/cdk-5.0.20140118-1.el6
cdk-5.0.20140118-1.el6 has been pushed to the Fedora EPEL 6 stable repository.