Bug 479021 - Review Request: python-repoze-what-plugins-sql - The repoze.what SQL plugin
Summary: Review Request: python-repoze-what-plugins-sql - The repoze.what SQL plugin
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Tom "spot" Callaway
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 501576
TreeView+ depends on / blocked
 
Reported: 2009-01-06 15:34 UTC by Luke Macken
Modified: 2016-09-20 02:39 UTC (History)
6 users (show)

Fixed In Version: 1.0-0.5.rc1.fc11
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2009-09-30 01:40:23 UTC
tcallawa: fedora-review+
tcallawa: fedora-cvs+


Attachments (Terms of Use)

Description Luke Macken 2009-01-06 15:34:03 UTC
Spec URL: http://lmacken.fedorapeople.org/rpms/python-repoze-what-plugins-sql.spec
SRPM URL: http://lmacken.fedorapeople.org/rpms/python-repoze-what-plugins-sql-1.0-0.1.a4.r3024.fc10.src.rpm
Description:
This is an adapters and extras plugin for repoze.what.

The SQL plugin makes repoze.what support sources defined in SQLAlchemy-managed
databases by providing one group adapter, one permission adapter and one
utility to configure both in one go (optionally, when the group source and the
permission source have a relationship).

This plugin also defines repoze.what.plugins.quickstart.

Comment 1 Tom "spot" Callaway 2009-05-19 18:56:41 UTC
Please update this to 1.0rc1.

Comment 3 Luke Macken 2009-06-05 21:21:16 UTC
http://lmacken.fedorapeople.org/rpms/python-repoze-what-plugins-sql-1.0-0.3.rc1.fc10.src.rpm
http://lmacken.fedorapeople.org/rpms/python-repoze-what-plugins-sql.spec

* Fri Jun 05 2009 Luke Macken <lmacken@redhat.com> - 1.0-0.3.rc1
- Patch our setup.py to use our own setuptools package

Comment 4 Tom "spot" Callaway 2009-07-02 15:14:17 UTC
Good:

- rpmlint checks return nothing
- package meets naming guidelines
- package meets packaging guidelines
- license (BSD) OK, matches source
- spec file legible, in am. english
- source matches upstream (89fb0bf9da58087dfe8b2bd882c1bfec3a512cf6)
- package compiles on devel (noarch)
- no missing BR
- no unnecessary BR
- no locales
- not relocatable
- owns all directories that it creates
- no duplicate files
- permissions ok
- %clean ok
- macro use consistent
- code, not content
- no need for -docs
- nothing in %doc affects runtime
- no need for .desktop file 

APPROVED.

Comment 5 Luke Macken 2009-07-10 15:02:50 UTC
New Package CVS Request
=======================
Package Name: python-repoze-what-plugins-sql
Short Description: The repoze.what SQL plugin
Owners: lmacken
Branches: F-10 F-11 EL-5

Comment 6 Tom "spot" Callaway 2009-07-10 15:08:31 UTC
cvs done

Comment 7 Brennan Ashton 2009-07-26 18:49:32 UTC
can this please get pushed into testing

Comment 9 Fedora Update System 2009-08-10 17:24:32 UTC
python-repoze-what-plugins-sql-1.0-0.5.rc1.fc11 has been submitted as an update for Fedora 11.
http://admin.fedoraproject.org/updates/python-repoze-what-plugins-sql-1.0-0.5.rc1.fc11

Comment 10 Fedora Update System 2009-08-11 22:38:45 UTC
python-repoze-what-plugins-sql-1.0-0.5.rc1.fc11 has been pushed to the Fedora 11 testing repository.  If problems still persist, please make note of it in this bug report.
 If you want to test the update, you can install it with 
 su -c 'yum --enablerepo=updates-testing update python-repoze-what-plugins-sql'.  You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F11/FEDORA-2009-8493

Comment 11 Nils Philippsen 2009-09-23 21:33:22 UTC
(In reply to comment #8)
> Waiting for
> https://admin.fedoraproject.org/updates/python-repoze-what-1.0.8-2.fc10  

Just going through some of the TG2 related reviews: both this and https://admin.fedoraproject.org/updates/python-repoze-what-1.0.8-2.fc11 have been in stable for a while, maybe this package can be built and pushed too?

BTW, the spec file BRs python-nose twice.

Comment 12 Fedora Update System 2009-09-30 01:40:06 UTC
python-repoze-what-plugins-sql-1.0-0.5.rc1.fc11 has been pushed to the Fedora 11 stable repository.  If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.