Spec URL: ftp://downloads.tuxfamily.org/morg/files/fedora/Music_Organizer-2.5.1-1.spec SRPM URL: ftp://downloads.tuxfamily.org/morg/files/fedora/Music_Organizer-2.5.1-1-2.5.1-1.fc9.src.rpm Description: Music Organizer is a multi-platform program that manage mp3, ogg, flac and mp4 files. For mp3, it recogonize both id3V2 and id3V1 tags and edit them separatly. It can also organize your files i.e. create a tree from tags and puts them smartly into those. musicorganizer generate tags from files name, generate files name from the tags and let you listen your music whith your favourite player.Music Organizer use taglib to read tags and wxWidgets for the GUI. Website: http://www.musicorganizer.org
Just some comment on your spec file - The name of the spec file don't match guidelines https://fedoraproject.org/wiki/Packaging/NamingGuidelines#Spec_file_name - The summary needs to be improved. It's not necessary to repeat the package name. - The license is wrong, check source header -> GPLv2+ - Your description looks very ugly. - Please preserve the time stamps in the install section if it's possible make DESTDIR=%{buildroot} INSTALL="install -p" install - There are translations... https://fedoraproject.org/wiki/Packaging/Guidelines#Handling_Locale_Files - AUTHORS, COPYING, and so on must be include as %doc. https://fedoraproject.org/wiki/PackageMaintainers/CreatingPackageHowTo#.25files_prefixes - You must install /verify the .desktop file https://fedoraproject.org/wiki/Packaging/Guidelines#Desktop_files - You must use macros in the %files section https://fedoraproject.org/wiki/PackageMaintainers/CreatingPackageHowTo#Macros - Stuff from the doc directory in the source should marked as %doc in the package. - You should add a proper changelog entry. https://fedoraproject.org/wiki/Packaging/Guidelines#Changelogs From my point of view this package should be named as 'musicorganizer'. The Mac version is called 'MusicOrganizer', the Debian version 'musicorganizer', and the Windows package 'Music.Organizer'.
Any progress on this?
Is this review dead?
It's not dead I just didn't have any time to deal with this the last few month, I will try to find time do the modifications in the next weeks ( April or May more exactly).
and?
Camille, are you still interested to maintain this package in Fedora?
I will mark this as dead in some days.