Bug 479678 - RHEL4 kvm virtio: parted support for virtio block devices
Summary: RHEL4 kvm virtio: parted support for virtio block devices
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat Enterprise Linux 4
Classification: Red Hat
Component: parted
Version: 4.8
Hardware: All
OS: Linux
low
medium
Target Milestone: rc
: ---
Assignee: Joel Andres Granados
QA Contact: Alexander Todorov
URL:
Whiteboard:
Depends On:
Blocks: 446215
TreeView+ depends on / blocked
 
Reported: 2009-01-12 13:41 UTC by Chris Lalancette
Modified: 2009-05-18 20:17 UTC (History)
1 user (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2009-05-18 20:17:12 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)
Patch to add a new PED_VIRTIO_DISK type to parted (2.37 KB, patch)
2009-01-12 13:45 UTC, Chris Lalancette
no flags Details | Diff


Links
System ID Private Priority Status Summary Last Updated
Red Hat Product Errata RHEA-2009:0979 0 normal SHIPPED_LIVE parted enhancement update 2009-05-18 13:44:38 UTC

Description Chris Lalancette 2009-01-12 13:41:04 UTC
When doing testing of the anaconda patches for RHEL-4 virtio, I found that virtio disks do not properly re-scan the partition table after changing it.  This is because a virtio disk shows up as "unknown" in RHEL-4 parted, and subsequently parted decides not to do the rescan.  The solution here will probably be to introduce a new VIRTIO disk type to RHEL-4 virtio so it will properly re-scan the disk.

Comment 1 Chris Lalancette 2009-01-12 13:45:29 UTC
Created attachment 328734 [details]
Patch to add a new PED_VIRTIO_DISK type to parted

With this patch in place, along with all of the other dependent patches hanging off of BZ 446215, I was able to successfully install a RHEL-4 guest to an unpartitioned raw disk over virtio devices.

This patch is a little bit ugly in that it uses fopen("/proc/devices") to do it's work, but I don't have a better way to accomplish that at present; virtio_blk devices are allocated dynamically, so we can't do a simple test.

Note that this patch is not in upstream parted; there, if an "unknown" disk comes up, it runs the partition re-scan unconditionally, so it is not needed.  Given the age of RHEL-4's parted, though, I thought it would be safer to introduce a new PED_VIRTIO_DISK type instead.

Comment 2 RHEL Program Management 2009-01-12 14:25:11 UTC
This request was evaluated by Red Hat Product Management for
inclusion, but this component is not scheduled to be updated in
the current Red Hat Enterprise Linux release. If you would like
this request to be reviewed for the next minor release, ask your
support representative to set the next rhel-x.y flag to "?".

Comment 5 Joel Andres Granados 2009-01-14 17:01:48 UTC
This should be available on parted-1.6.19-23.EL.

Comment 8 Alexander Todorov 2009-02-11 10:06:26 UTC
Install with:
# qemu-kvm -drive file=/root/kvm.img,if=virtio,boot=on -net nic,model=virtio,macaddr=00:16:41:E4:1D:FF,vlan=0 -net tap,script=/etc/qemu-ifup,vlan=0,ifname=vnet0 -m 512 -cdrom /root/boot.iso -boot d


Default partitioning, default package set - PASS

Disk is seen as /dev/vda. I'm moving this one to VERIFIED. Please move back to ON_QA if more testing is needed.

Comment 10 errata-xmlrpc 2009-05-18 20:17:12 UTC
An advisory has been issued which should help the problem
described in this bug report. This report is therefore being
closed with a resolution of ERRATA. For more information
on therefore solution and/or where to find the updated files,
please follow the link below. You may reopen this bug report
if the solution does not work for you.

http://rhn.redhat.com/errata/RHEA-2009-0979.html


Note You need to log in before you can comment on or make changes to this bug.