Red Hat Bugzilla – Bug 479711
Review Request: perl-Time-Duration-Parse - Parse string that represents time duration
Last modified: 2009-01-14 18:17:24 EST
Spec URL: http://fedorapeople.org/~cweyl/review/perl-Time-Duration-Parse.spec SRPM URL: http://fedorapeople.org/~cweyl/review/perl-Time-Duration-Parse-0.06-1.fc10.src.rpm Description: Time::Duration::Parse is a module to parse human readable duration strings like _2 minutes and 3 seconds_ to seconds. It does the opposite of duration_exact() in Time::Duration and is roundtrip safe. So, the following is always true. Koji build: http://koji.fedoraproject.org/koji/taskinfo?taskID=1047036
Review: + package builds in mock (rawhide i386). koji Build => http://koji.fedoraproject.org/koji/taskinfo?taskID=1047036 + rpmlint is silent for SRPM and for RPM. + source files match upstream url a23b7ca50a909df57e484cf39a3fa414 Time-Duration-Parse-0.06.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc is present. + BuildRequires are proper. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no headers or static libraries. + no .pc file present. + no -devel subpackage + no .la files. + no translations are available + Does owns the directories it creates. + no scriptlets present. + no duplicates in %files. + file permissions are appropriate. + make test gave All tests successful. Files=3, Tests=2038, 1 wallclock secs ( 0.41 usr 0.03 sys + 1.16 cusr 0.04 csys = 1.64 CPU) + Package perl-Time-Duration-Parse-0.06-1.fc11 => Provides: perl(Time::Duration::Parse) = 0.06 Requires: perl(Carp) perl(Exporter::Lite) perl(strict) APPROVED.
New Package CVS Request ======================= Package Name: perl-Time-Duration-Parse Short Description: Parse string that represents time duration Owners: cweyl Branches: F-9 F-10 devel InitialCC: perl-sig
cvs done.
Thanks for the review! :-)