Created attachment 328927 [details] the rpm file Cycle through a collection of pictures. Will display image captions (IPTC,Jpeg Comment, EXIF) if available. The spec file: ----------------------------------------------------- Name: gdesklet-slideshow Version: 0.9 Release: 1%{?dist} Summary: Cycle through a collection of pictures Group: User Interface/Desktops License: GPL+ URL: http://www.gdesklets.de Source0: http://http://www.gdesklets.de/files/desklets/SlideShow/SlideShow-%{version}.tar.gz Source1: http://www.gdesklets.de/files/controls/ImageSlideShow/ImageSlideShow-0.8.tar.gz BuildRoot: %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n) BuildArch: noarch %define _appname SlideShow %define _ctrlname ImageSlideShow BuildRequires: python Requires: gdesklets Requires: python-imaging %description Cycle through a collection of pictures. Will display image captions (IPTC,Jpeg Comment, EXIF) if available. %prep %setup -q -n %{_appname} tar -xf %{SOURCE1} -C ../ %build %install rm -rf $RPM_BUILD_ROOT #need to install the control first mkdir -p $RPM_BUILD_ROOT/%{_datadir}/gdesklets/Controls/ImageSlideShow/ install -p -m644 ../ImageSlideShow/* $RPM_BUILD_ROOT/%{_datadir}/gdesklets/Controls/ImageSlideShow/. #add shebang and execution mode find $RPM_BUILD_ROOT/%{_datadir}/gdesklets/Controls/ImageSlideShow/. \( -name "*.py" \) -exec sed -i '1i\#!/usr/bin/python' {} \; find $RPM_BUILD_ROOT/%{_datadir}/gdesklets/Controls/ImageSlideShow/. \( -name "*.py" \) | xargs chmod a+x #install the display now mkdir -p $RPM_BUILD_ROOT/%{_datadir}/gdesklets/Displays/SlideShow/ cp -rp * $RPM_BUILD_ROOT/%{_datadir}/gdesklets/Displays/SlideShow/. %clean rm -rf $RPM_BUILD_ROOT %files %defattr(-,root,root,-) %doc LICENSE #%{_datadir}/gdesklets/ %{_datadir}/gdesklets/Controls/ImageSlideShow/ %{_datadir}/gdesklets/Displays/SlideShow/ %changelog * Mon Jan 12 2009 Jonathan MERCIER <bioinfornatics> - 0.9-1 - Initial Packaging for Fedora ----------------------------------------------------- rpmlint issue: $ rpmlint ../RPMS/noarch/SlideShow-0.9-1.fc10.noarch.rpm Error: no installed packages by name ../RPMS/noarch/SlideShow-0.9-1.fc10.noarch.rpm 0 packages and 0 specfiles checked; 0 errors, 0 warnings. $ rpmlint ../SRPMS/SlideShow-0.9-1.fc10.src.rpm Error: no installed packages by name ../SRPMS/SlideShow-0.9-1.fc10.src.rpm 0 packages and 0 specfiles checked; 0 errors, 0 warnings.
Created attachment 328928 [details] The spec file
Created attachment 328929 [details] The src.rpm file
The new spec file: ----------------------------------------------------- Name: gdesklet-slideshow Version: 0.9 Release: 1%{?dist} Summary: Cycle through a collection of pictures Group: User Interface/Desktops License: GPL+ URL: http://www.gdesklets.de Source0: http://http://www.gdesklets.de/files/desklets/SlideShow/SlideShow-%{version}.tar.gz Source1: http://www.gdesklets.de/files/controls/ImageSlideShow/ImageSlideShow-0.8.tar.gz BuildRoot: %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n) BuildArch: noarch %define _appname SlideShow %define _ctrlname ImageSlideShow BuildRequires: python Requires: gdesklets Requires: python-imaging %description Cycle through a collection of pictures. Will display image captions (IPTC,Jpeg Comment, EXIF) if available. %prep %setup -q -n %{_appname} tar -xf %{SOURCE1} -C ../ %build %install rm -rf $RPM_BUILD_ROOT #need to install the control first mkdir -p $RPM_BUILD_ROOT/%{_datadir}/gdesklets/Controls/%{_ctrlname}/ install -p -m644 ../%{_ctrlname}/* $RPM_BUILD_ROOT/%{_datadir}/gdesklets/Controls/%{_ctrlname}/. #add shebang and execution mode find $RPM_BUILD_ROOT/%{_datadir}/gdesklets/Controls/%{_ctrlname}/. \( -name "*.py" \) -exec sed -i '1i\#!/usr/bin/python' {} \; find $RPM_BUILD_ROOT/%{_datadir}/gdesklets/Controls/%{_ctrlname}/. \( -name "*.py" \) | xargs chmod a+x #install the display now mkdir -p $RPM_BUILD_ROOT/%{_datadir}/gdesklets/Displays/%{_appname}/ cp -rp * $RPM_BUILD_ROOT/%{_datadir}/gdesklets/Displays/%{_appname}/. %clean rm -rf $RPM_BUILD_ROOT %files %defattr(-,root,root,-) %doc LICENSE #%{_datadir}/gdesklets/ %dir %{_datadir}/gdesklets/Controls/%{_ctrlname} %dir %{_datadir}/gdesklets/Displays/%{_appname} %{_datadir}/gdesklets/Controls/%{_ctrlname}/* %{_datadir}/gdesklets/Displays/%{_appname}/* %changelog * Mon Jan 12 2009 Jonathan MERCIER <bioinfornatics> - 0.9-1 - Initial Packaging for Fedora ----------------------------------------------------- rpmlint: $ rpmlint rpmbuild/RPMS/noarch/gdesklet-slideshow-0.9-1.fc10.noarch.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. $ rpmlint rpmbuild/SRPMS/gdesklet-slideshow-0.9-1.fc10.src.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. $ rpmlint rpmbuild/SPECS/gdesklet-slideshow.spec 0 packages and 1 specfiles checked; 0 errors, 0 warnings. -----------------------------------------------------
Created attachment 328981 [details] SPEC file
Created attachment 328982 [details] The src.rpm file
Created attachment 328983 [details] the rpm file
Easy install on f10: $ su -m -c 'wget http://bioinformatiques.free.fr/gdesklet-slideshow-0.9-1.fc10.noarch.rpm && yum --nogpgcheck localinstall gdesklet-slideshow-0.9-1.fc10.noarch.rpm' Easy install on F9: su -m -c 'wget http://bioinformatiques.free.fr/gdesklet-slideshow-0.9-1.fc9.noarch.rpm && yum --nogpgcheck localinstall gdesklet-slideshow-0.9-1.fc9.noarch.rpm'
Why don't you simply act like everyone else and provide the URL for spec and src.rpm in the bug number, instead of providing them over and over again as attachments in bugzilla ? At first I assumed that you do not have a place to host the files, but comment #7 proves that you obviously do.
rpm and src.rpm for F9: http://bioinformatiques.free.fr/gdesklet-slideshow-0.9-1.fc9.noarch.rpm http://bioinformatiques.free.fr/gdesklet-slideshow-0.9-1.fc9.src.rpm ----------------------------------------------------- rpm and src.rpm for F10: http://bioinformatiques.free.fr/gdesklet-slideshow-0.9-1.fc10.noarch.rpm http://bioinformatiques.free.fr/gdesklet-slideshow-0.9-1.fc10.src.rpm
And here the spec file: http://bioinformatiques.free.fr/gdesklet-slideshow.spec
So a few comments: 1. License type per the source is GPLv2+ not GPL+ 2. Source0 has two 'http://' in the listing 3. This is a gui application and yet there is no .desktop file see: http://fedoraproject.org/wiki/Packaging/Guidelines#desktop The package appears to build fine in mock rpmlint output below: [ke4qqq@nalleyt61 noarch]$ rpmlint gdesklet-slideshow-0.9-1.fc10.noarch.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. [ke4qqq@nalleyt61 SRPMS]$ rpmlint gdesklet-slideshow-0.9-1.fc10.src.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. [ke4qqq@nalleyt61 SPECS]$ rpmlint gdesklet-slideshow.spec 0 packages and 1 specfiles checked; 0 errors, 0 warnings. While working on this review I looked for your fas account and don't see one with your name or your email address as listed in this bug. If you don't have one, you'll need to get one, and that probably means you need to set this bug to block the fe-needsponsor bug so that you can be sponsored as a packager.
1 and 2/ The new spec file are update. The new src.rpm file are update And the new rpm file update rpmlint rpmbuild/SPECS/gdesklet-slideshow.spec 0 packages and 1 specfiles checked; 0 errors, 0 warnings. rpmlint rpmbuild/RPMS/noarch/gdesklet-slideshow-0.9-1.fc10.noarch.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. rpmlint rpmbuild/SRPMS/gdesklet-slideshow-0.9-1.fc10.src.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. 3/ this is not a GUI but a plugin for gdesklet so they are not .desktop file
rpm and src.rpm for F9: http://bioinformatiques.free.fr/gdesklet-slideshow-0.9-2.fc9.noarch.rpm http://bioinformatiques.free.fr/gdesklet-slideshow-0.9-2.fc9.src.rpm ----------------------------------------------------- rpm and src.rpm for F10: http://bioinformatiques.free.fr/gdesklet-slideshow-0.9-2.fc10.noarch.rpm http://bioinformatiques.free.fr/gdesklet-slideshow-0.9-2.fc10.src.rpm The spec file http://bioinformatiques.free.fr/gdesklet-slideshow.spec
The original %files section was fine: > %{_datadir}/gdesklets/Controls/ImageSlideShow/ > %{_datadir}/gdesklets/Displays/SlideShow/ Why did you change it...? > %dir %{_datadir}/gdesklets/Controls/%{_ctrlname} > %dir %{_datadir}/gdesklets/Displays/%{_appname} > %{_datadir}/gdesklets/Controls/%{_ctrlname}/* > %{_datadir}/gdesklets/Displays/%{_appname}/* Both are equivalent. > %setup -q -n %{_appname} > tar -xf %{SOURCE1} -C ../ The way the two tarballs are extracted is strange. Sure, you can do it like that, but having to deal with the "../" in subsequent commands decreases the readability of the spec file. I strongly encourage you to use %setup -q -c %{name}-%{version} -a1 to extract both tarballs into the same root directory, and then either use your two macros %_appname and %_ctrlname when accessing files or entering directories. The LICENSE, MANIFEST, README and "todo" files are installed in addition to %doc, and it is important to note that the LICENSE file must not be removed from /usr/share/gdesklets/Displays/SlideShow/LICENSE - or else it cannot be displayed by the desklet. Opening "Configure desklet" and selecting a folder from which to load images always displays an error dialog: | The folder contents could not be displayed | | Operation not supported It seems it always starts in the root directory due to that.
In first, thanks for you answer. 1/ Why did you change it...? > %dir %{_datadir}/gdesklets/Controls/%{_ctrlname} > %dir %{_datadir}/gdesklets/Displays/%{_appname} > %{_datadir}/gdesklets/Controls/%{_ctrlname}/* > %{_datadir}/gdesklets/Displays/%{_appname}/* -------------------------------------------- someone on IRC #fedora-fr say is better. i have upadte the spec file: > %{_datadir}/gdesklets/Controls/ImageSlideShow/ > %{_datadir}/gdesklets/Displays/SlideShow/ 2/ > %setup -q -n %{_appname} > tar -xf %{SOURCE1} -C ../ -------------------------------------------- it's ok, i use %setup -q -c %{name}-%{version} -a1 3/ The LICENSE, MANIFEST, README and "todo" files are installed in addition to %doc, and it is important to note that the LICENSE file must not be removed from /usr/share/gdesklets/Displays/SlideShow/LICENSE - or else it cannot be displayed by the desklet. -------------------------------------------- ok, it's done 4/ Opening "Configure desklet" and selecting a folder from which to load images always displays an error dialog: | The folder contents could not be displayed | | Operation not supported It seems it always starts in the root directory due to that. -------------------------------------------- yes i have the same error, i did'nt find the source code who make this error! 5/ they are no directory image i have see in Display/SideShow.script line 259: Prefs.image_directory.value= value[:value.rfind( "/" )] if you change the value by: Prefs.image_directory.value= "/home/user/images" is better. but where put os.environ ['HOME']? 6/ i have update spec rpm and src rpm http://bioinformatiques.free.fr/SlideShow-0.9-3.fc10.noarch.rpm http://bioinformatiques.free.fr/SlideShow-0.9-3.fc10.src.rpm http://bioinformatiques.free.fr/SlideShow.spec 7/ rpmlint: $ rpmlint rpmbuild/SRPMS/SlideShow-0.9-3.fc10.src.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. $ rpmlint rpmbuild/RPMS/noarch/SlideShow-0.9-3.fc10.noarch.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. $ rpmlint rpmbuild/SPECS/SlideShow.spec 0 packages and 1 specfiles checked; 0 errors, 0 warnings.
Maybe the gdesklets maintainer can comment on this? Bottom of comment 14 is some oddity in Fedora's gdesklets package. It is reproducible with the "Calendar" v0.62 Display in F10 "gdesklets" package. Steps to reproduce: 1. Run "Calendar" desklet from date/time category. 2. Right-click on desklet display for "Configure desklet" pop-up menu. 3. Click "Open" button next to "Month image" input field. Result: An error dialog on top of the file manager is displayed: | The folder contents could not be displayed | | Operation not supported [ OK ] It looks like a bug in gdesklets or an API incompatibility.
i have found this file: /usr/lib64/gdesklets/Controls/URI/__init__py this file is call for openning a file
(In reply to comment #16) > Maybe the gdesklets maintainer can comment on this? > > Bottom of comment 14 is some oddity in Fedora's gdesklets package. It is > reproducible with the "Calendar" v0.62 Display in F10 "gdesklets" package. > Steps to reproduce: > > 1. Run "Calendar" desklet from date/time category. > 2. Right-click on desklet display for "Configure desklet" pop-up menu. > 3. Click "Open" button next to "Month image" input field. > > Result: An error dialog on top of the file manager is displayed: > > | The folder contents could not be displayed > | > | Operation not supported [ OK ] > > It looks like a bug in gdesklets or an API incompatibility. I confirmed the bug that affect other desklets with image path and submitted it to upstream. https://bugs.launchpad.net/fedora/+source/gdesklets/+bug/323347
(In reply to comment #18) > (In reply to comment #16) > > Maybe the gdesklets maintainer can comment on this? > > > > Bottom of comment 14 is some oddity in Fedora's gdesklets package. It is > > reproducible with the "Calendar" v0.62 Display in F10 "gdesklets" package. > > Steps to reproduce: > > > > 1. Run "Calendar" desklet from date/time category. > > 2. Right-click on desklet display for "Configure desklet" pop-up menu. > > 3. Click "Open" button next to "Month image" input field. > > > > Result: An error dialog on top of the file manager is displayed: > > > > | The folder contents could not be displayed > > | > > | Operation not supported [ OK ] > > > > It looks like a bug in gdesklets or an API incompatibility. > > I confirmed the bug that affect other desklets with image path and submitted it > to upstream. > https://bugs.launchpad.net/fedora/+source/gdesklets/+bug/323347 Then the package it's ok?
Yes, the package is fine
Make sure to change Summary in something like: A slideshow of collection for gdesklets. Also get a Fedora accound, a sponsor to get approval.
Information is on https://fedoraproject.org/wiki/PackageMaintainers
ok i have update the summary. but i have a little problem with release 3 gdesklet do'nt add the control then the desklet do'nt work???
(In reply to comment #23) > ok i have update the summary. > but i have a little problem with release 3 gdesklet do'nt add the control then > the desklet do'nt work??? no it's good, is me :p ____________________________________________________________ rpmlint: $ rpmlint rpmbuild/SPECS/SlideShow.spec 0 packages and 1 specfiles checked; 0 errors, 0 warnings. $ rpmlint rpmbuild/SRPMS/SlideShow-0.9-4.fc10.src.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. $ rpmlint rpmbuild/RPMS/noarch/SlideShow-0.9-4.fc10.noarch.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. ____________________________________________________________ I have update spec rpm and src rpm http://bioinformatiques.free.fr/SlideShow-0.9-4.fc10.noarch.rpm http://bioinformatiques.free.fr/SlideShow-0.9-4.fc10.src.rpm http://bioinformatiques.free.fr/SlideShow.spec
(In reply to comment #22) > Information is on https://fedoraproject.org/wiki/PackageMaintainers ok, i read all the document i am at : koji build --scratch dist-f10 rpmbuild/SRPMS/SlideShow-0.9-4.fc10.src.rpm Uploading srpm: rpmbuild/SRPMS/SlideShow-0.9-4.fc10.src.rpm [====================================] 100% 00:00:04 143.64 KiB 28.83 KiB/sec Created task: 1096424 Task info: http://koji.fedoraproject.org/koji/taskinfo?taskID=1096424 Watching tasks (this may be safely interrupted)... 1096424 build (dist-f10, SlideShow-0.9-4.fc10.src.rpm): open (xenbuilder2.fedora.redhat.com) 1096425 buildArch (SlideShow-0.9-4.fc10.src.rpm, noarch): free 1096425 buildArch (SlideShow-0.9-4.fc10.src.rpm, noarch): free -> open (ppc10.fedora.phx.redhat.com) 1096425 buildArch (SlideShow-0.9-4.fc10.src.rpm, noarch): open (ppc10.fedora.phx.redhat.com) -> closed 0 free 1 open 1 done 0 failed 1096424 build (dist-f10, SlideShow-0.9-4.fc10.src.rpm): open (xenbuilder2.fedora.redhat.com) -> closed 0 free 0 open 2 done 0 failed 1096424 build (dist-f10, SlideShow-0.9-4.fc10.src.rpm) completed successfully
Next step is to find a sponsor.
where i can i find a sponsor? i have creat some package: Review Request: SPE - Stani's Python Editor: https://bugzilla.redhat.com/show_bug.cgi?id=481022 A collection of quotes in French for gdesklets: https://bugzilla.redhat.com/show_bug.cgi?id=483403 Modern background: https://bugzilla.redhat.com/show_bug.cgi?id=483498
(In reply to comment #27) > where i can i find a sponsor? > i have creat some package: > Review Request: SPE - Stani's Python Editor: > https://bugzilla.redhat.com/show_bug.cgi?id=481022 https://admin.fedoraproject.org/accounts/group/members/packager/*/sponsor You should be able to see them with your Fedora account.
I change the name of rpm SlideShow to gdesklet-SlideShow rpmlint issue: _____________________________________________________ $ rpmlint rpmbuild/SPECS/gdesklet-SlideShow.spec 0 packages and 1 specfiles checked; 0 errors, 0 warnings. $ rpmlint rpmbuild/SRPMS/gdesklet-SlideShow-0.9-5.fc10.src.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. $ rpmlint rpmbuild/RPMS/noarch/gdesklet-SlideShow-0.9-5.fc10.noarch.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. _____________________________________________________ http://bioinformatiques.free.fr/gdesklet-SlideShow-0.9-5.fc10.src.rpm http://bioinformatiques.free.fr/gdesklet-SlideShow-0.9-5.fc10.noarch.rpm http://bioinformatiques.free.fr/gdesklet-SlideShow.spec
(Removing NEEDSPONSOR)
New Package CVS Request ======================= Package Name: gdesklet-SlideShow Short Description: A slideshow of collection for gdesklets Owners: bioinfornatics Branches: F9 F10 InitialCC: bioinfornatics
I don't see fedora-review + here, and it's not clear to me who is reviewing this. Please wait until a reviewer marks it fedora-review + for requesting cvs.
Done, I oversight that fedora-review part so request for cvs can be proceeded.
maybe you could be a bit more extensive, Jonhatan has just been approved, seing some more review done is always interesting....
sorry for the waiting. the package is ready. i wait the cvs thanks
quote: mtasaka.u-tokyo.ac.jp 2009-02-05 13:43:29 EDT (-) [reply] ------- Well, - This package itself is now good - For your other review requests: - I suggets that gdesklets related packages should be renamed to gdesklets-XXXXXX (there are already gdesklets-goodweather, gdesklets-quote-of-the-day on Fedora. It seems that both of these were reviewed by me....) - I suggest that earth-and-moon rpm should be renamed to earth-and-moon-backgrounds (as other packages do). You can check how other packages are renamed by $ rpm -qf /usr/share/backgrounds/* (note: please post new srpms or your comments for this package on the corresponding review request, not on "this" review ticket) _______________________________________________________________________________ mtasaka say this but in https://bugzilla.redhat.com/show_bug.cgi?id=481022 when sponsorized me for another package
cvs done.