Red Hat Bugzilla – Bug 479991
"Solar" background theme broken wrt kde42
Last modified: 2009-01-24 04:05:28 EST
Seems the Solar background theme is indeed broken when used with kde-4.2. In my testing, it seems to have to do with the use of symlinks.
If I replace the symlinks with real images, it works.
Tried for advice on irc... nada, filed upstream bug.
Wallpapers are now separated into standalone components - so I think it's complete rewrite :( See http://websvn.kde.org/trunk/KDE/kdebase/workspace/plasma/design/wallpaper?revision=832566&view=markup.
Well, upstream says it's a feature - no symlinks outside wallpapers package (only inside). What now? Convince upstream it's a regression for us or patch it to support symlinks outside wallpapers package?
I'll explore the possibility of modifying solar-backgrounds and maybe using hardlinks or something similar.
Created attachment 329101 [details]
Ok, this is our "hyperextreme programming tryout with ltinkl" workaround:
For static content such as wallpapers it should not be such security risk to touch files (images) outside package, so we've set ServiceType to Plasma/Wallpaper for Solar backgrounds package and for packages with this type we allow access outside this packages (so symlinks are again allowed).
But bad packages still could claim they are wallpaper type.
Feel free to comment this patch. It's workaround at least for F10 - it's not easy to change this in package as it's already released. For F11 we can write wallpaper service which will support Gnome backgrounds directly (even with daytime changes of wallpaper).
Can't we automatically figure out whether it's a wallpaper from the context it's used in? That would be more secure, in addition to not having to modify the Solar theme.
Oh, and ServiceType=Plasma/Wallpaper is for wallpaper plugins/engines according to the design document you quote, not for wallpaper themes.
Sorry, a couple more questions: How does this thing interact with my plasma-default-wallpaper patch? Where exactly is Plasma::Package used for the wallpapers?
It's solved by upstream now (thanks aseigo!) and actually it looks much more better than our patch (it adds allowExternalPaths to PackageStructure and then sets it to true in BackroundPackage). It missed 4.2 but we are allowed to backport to our packages :)
it's only happen in KDE-4.2, changed Version to rawhide. it's fixed in
kdelibs-4_1_96-9_fc11, kdebase-workspace-4_1_96-4_fc11 and kde-settings-4.1-4.20090116svn-f11
This is fixed in Rawhide now, F9 and F10 (official packages) not affected, kde-redhat is already fixed too AFAIK, closing.