Spec URL: http://tuxbrewr.fedorapeople.org/subtitlecomposer/subtitlecomposer.spec SRPM URL: http://tuxbrewr.fedorapeople.org/subtitlecomposer/subtitlecomposer-0.5.2-1.fc10.src.rpm Description: A text-based subtitles editor for KDE. Build logs here: https://koji.fedoraproject.org/koji/taskinfo?taskID=1056201
initial comments from quick perusal: 1. use BR: kdelibs4-devel instead of kdelibs-devel (to avoid ambiguity) 2. omit -DCMAKE_INSTALL_PREFIX=$(kde4-config --prefix) -DCMAKE_BUILD_TYPE=debugfull not required or desired, %_cmake_kde4 macro includes both already 3. what's -DKDE4_BUILD_TESTS:BOOL=${BUILD_TESTS} for? I don't see BUILD_TESTS defined anywhere. ? 4. missing icon scriptlets
1, 2, 3 all fixed Can you give an example of what you are looking at for #4. Never used scriplets for icons b4.
example, kdetoys: http://cvs.fedoraproject.org/viewvc/devel/kdetoys/kdetoys.spec?revision=1.42&view=markup Requires(post): xdg-utils Requires(postun): xdg-utils %post xdg-icon-resource forceupdate --theme hicolor 2> /dev/null || : %postun xdg-icon-resource forceupdate --theme hicolor 2> /dev/null || :
all fixed new spec and srpm online
Looking at http://tuxbrewr.fedorapeople.org/subtitlecomposer I don't see any scriptlets. But I don't see any remaining problems or blockers, APPROVED. Cosmetic items worth fixing before building: 1. icon scriptlets (see comment #3 for an example). 2. use kde4 macros like %{_kde4_iconsdir} instead of %{_datadir}/icons %{_kde4_appsdir} instead of %{_datadir}/kde4/apps 3. drop "for KDE" in summary/description. It should work just fine outside of KDE. 4. Not sure if it's possible, but try to use a full URL for Source0. kde-apps may make this difficult to do though. :)
New Package CVS Request ======================= Package Name: subtitlecomposer Short Description: A text based subtitles editor Owners: tuxbrewr Branches: F9 F10 InitialCC:
cvs done.
Subtitle Composer not in Multimedia KDE memu but in Other.
nod, maybe: Categories=Qt;Video;AudioVideoEditing; would be better. See http://standards.freedesktop.org/menu-spec/menu-spec-1.0.html#category-registry for available categories.
I nistall subtitlecomposer-0.5.2-2 with Categories=Qt;Video;AudioVideoEditing; in desktop file but it still in Other menu.
Ugh, ok, this: Categories=Qt;AudioVideo;AudioVideoEditing; (looks like Audio and Video categories aren't used or grok'd, which isn't surprising in the presence of AudioVideo too)
subtitlecomposer-0.5.2-3.fc9 has been submitted as an update for Fedora 9. http://admin.fedoraproject.org/updates/subtitlecomposer-0.5.2-3.fc9
subtitlecomposer-0.5.2-3.fc10 has been submitted as an update for Fedora 10. http://admin.fedoraproject.org/updates/subtitlecomposer-0.5.2-3.fc10
There is in subtitlecomposer-0.5.2-2 Categories=Qt;KDE;Video;AudioVideoEditing; but it still in Other menu. If I edit /usr/share/applications/kde4/subtitlecomposer.desktop and change Video to AudioVideo it in right place in Multimedia. (In reply to comment #13) > subtitlecomposer-0.5.2-3.fc10 has been submitted as an update for Fedora 10. > http://admin.fedoraproject.org/updates/subtitlecomposer-0.5.2-3.fc10 Found Qt-Version 4.4.3 (In reply to comment #12) > subtitlecomposer-0.5.2-3.fc9 has been submitted as an update for Fedora 9. > http://admin.fedoraproject.org/updates/subtitlecomposer-0.5.2-3.fc9 Found Qt-Version 4.5.0 But Qt 4.5.0 not in updates in F-9. Is it will be work?
subtitlecomposer-0.5.2-3.fc9 has been pushed to the Fedora 9 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing-newkey update subtitlecomposer'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F9/FEDORA-2009-3223
subtitlecomposer-0.5.2-3.fc10 has been pushed to the Fedora 10 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update subtitlecomposer'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F10/FEDORA-2009-3275
subtitlecomposer-0.5.2-3.fc9 has been pushed to the Fedora 9 stable repository. If problems still persist, please make note of it in this bug report.
subtitlecomposer-0.5.2-3.fc10 has been pushed to the Fedora 10 stable repository. If problems still persist, please make note of it in this bug report.