Bug 480326 - Spacewalk Proxy packages start services
Summary: Spacewalk Proxy packages start services
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Spacewalk
Classification: Community
Component: Proxy Server
Version: 0.4
Hardware: All
OS: Linux
low
medium
Target Milestone: ---
Assignee: Miroslav Suchý
QA Contact: Red Hat Satellite QA List
URL:
Whiteboard:
Depends On:
Blocks: space05
TreeView+ depends on / blocked
 
Reported: 2009-01-16 14:24 UTC by Jan Pazdziora (Red Hat)
Modified: 2009-09-17 07:09 UTC (History)
0 users

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2009-09-17 07:09:12 UTC
Embargoed:


Attachments (Terms of Use)

Description Jan Pazdziora (Red Hat) 2009-01-16 14:24:13 UTC
Description of problem:

Spacewalk Proxy packages start services in their %post scripts.

This is against Fedora Packaging guidelines, as stated at

  https://fedoraproject.org/wiki/Packaging/SysVInitScript
  Why don't we....
         *  start the service after installation? 
         Installations can be in changeroots, in an installer
         context, or in other situations where you don't want
         the services started. 

It also means that there is SELinux AVC denial

avc:  denied  { setattr } for  pid=2880 comm="httpd" name="rhn_proxy_broker.log" dev=dm-0 ino=64845 scontext=root:system_r:httpd_t:s0 tcontext=root:object_r:httpd_log_t:s0 tclass=file

reported during configure-proxy.sh, upon package installation.

Version-Release number of selected component (if applicable):

spacewalk-proxy-broker-0.4.5-1.el5
spacewalk-proxy-tools-0.4.5-1.el5
spacewalk-proxy-redirect-0.4.5-1.el5

How reproducible:

Deterministic.

Steps to Reproduce:
1. rpm -q --scripts spacewalk-proxy-broker | grep /sbin/service
2. rpm -q --scripts spacewalk-proxy-tools | grep /sbin/service
3. rpm -q --scripts spacewalk-proxy-redirect | grep /sbin/service
  
Actual results:

# rpm -q --scripts spacewalk-proxy-broker | grep /sbin/service
/sbin/service httpd graceful > /dev/null 2>&1
# rpm -q --scripts spacewalk-proxy-tools | grep /sbin/service
    /sbin/service squid stop
    /sbin/service squid start
    /sbin/service httpd stop
    /sbin/service httpd start
    /sbin/service httpd graceful
# rpm -q --scripts spacewalk-proxy-redirect | grep /sbin/service
/sbin/service httpd graceful > /dev/null 2>&1

Expected results:

No service start not graceful start should be done.

Additional info:

Comment 1 Miroslav Suchý 2009-01-21 10:53:12 UTC
Fixed in f51c6110bc1c7296b3478c3110a30c9dca331e9b

Comment 2 Jesus M. Rodriguez 2009-04-14 14:12:16 UTC
Spacewalk 0.5 released.

Comment 3 Miroslav Suchý 2009-09-17 07:09:12 UTC
Spacewalk 0.5 has been released for long time ago.


Note You need to log in before you can comment on or make changes to this bug.