Bug 480720 - Review Request: gtkparasite - A GUI debugging tool for GTK+ applications
Review Request: gtkparasite - A GUI debugging tool for GTK+ applications
Status: CLOSED RAWHIDE
Product: Fedora
Classification: Fedora
Component: Package Review (Show other bugs)
rawhide
All Linux
medium Severity medium
: ---
: ---
Assigned To: Dan Horák
Fedora Extras Quality Assurance
:
Depends On:
Blocks:
  Show dependency treegraph
 
Reported: 2009-01-20 00:04 EST by Ignacio Vazquez-Abrams
Modified: 2009-01-20 17:22 EST (History)
2 users (show)

See Also:
Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed: 2009-01-20 17:22:22 EST
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---
dan: fedora‑review+
kevin: fedora‑cvs+


Attachments (Terms of Use)

  None (edit)
Description Ignacio Vazquez-Abrams 2009-01-20 00:04:26 EST
Spec URL: http://ivazquez.fedorapeople.org/packages/gtk2-parasite/gtk2-parasite.spec
SRPM URL: http://ivazquez.fedorapeople.org/packages/gtk2-parasite/gtk2-parasite-0-0.1.gitf485897d.src.rpm
Description: Parasite is a debugging and development tool that runs inside your GTK+ application's process. It can inspect your application, giving you detailed information on your UI, such as the hierarchy, X window IDs, widget properties, and more. You can modify properties on the fly in order to experiment with the look of your UI.

Parasite includes an embedded Python shell that lets you write new code that directly interacts with your application's UI, regardless of the language the application is written in. Create new dialogs, attach temporary signal handlers to buttons, test out new logic, and gather additional debug information.
Comment 1 Dan Horák 2009-01-20 06:10:06 EST
formal review is here, see the notes below:

OK	source files match upstream:
	    checked with diff
BAD	package meets naming and versioning guidelines.
OK	specfile is properly named, is cleanly written and uses macros consistently.
OK	dist tag is present.
BAD	license field matches the actual license.
N/A	license is open source-compatible.  XXX License text not included upstream. XXX License text included in package.
OK	latest version is being packaged.
OK	BuildRequires are proper.
OK	compiler flags are appropriate.
OK	%clean is present.
OK	package builds in mock (Rawhide/x86_64).
OK	debuginfo package looks complete.
OK	rpmlint is silent.
OK	final provides and requires look sane.
N/A	%check is present and all tests pass.
OK	no shared libraries are added to the regular linker search paths.
OK	owns the directories it creates.
OK	doesn't own any directories it shouldn't.
OK	no duplicates in %files.
OK	file permissions are appropriate.
OK	no scriptlets present.
OK	code, not content.
OK	documentation is small, so no -docs subpackage is necessary.
OK	%docs are not necessary for the proper functioning of the package.
OK	no headers.
OK	no pkgconfig files.
OK	no libtool .la droppings.
OK	not a GUI app.

- package name should reflect upstream name, eg. gtkparasite is appropriate package name here (https://fedoraproject.org/wiki/Packaging/NamingGuidelines#General_Naming)
- snapshot packages should include date in the release tag (https://fedoraproject.org/wiki/Packaging/NamingGuidelines#Snapshot_packages)
- license information is completely missing in the sources files and even GPL is symlinked from autotools, but the license tag says it should MIT as written only on the web page
- the empty run of configure should be dropped from the autogen.sh
Comment 3 Dan Horák 2009-01-20 09:33:12 EST
All issues are fixed, package is APPROVED.
Comment 4 Ignacio Vazquez-Abrams 2009-01-20 09:49:29 EST
New Package CVS Request
=======================
Package Name: gtkparasite
Short Description: A GUI debugging tool for GTK+ applications
Owners: ivazquez
Branches: F-9 F-10
Comment 5 Kevin Fenzi 2009-01-20 16:06:41 EST
cvs done.
Comment 6 Ignacio Vazquez-Abrams 2009-01-20 17:22:22 EST
Built for F9, F10, and Rawhide.

Note You need to log in before you can comment on or make changes to this bug.