Spec URL: http://oget.fedorapeople.org/review/tse3.spec SRPM URL: http://oget.fedorapeople.org/review/tse3-0.3.1-1.fc10.src.rpm Description: TSE3 is a powerful open source sequencer engine written in C++. It is a 'sequencer engine' because it provides the actual driving force elements of a sequencer but provides no form of user interface. Sequencer applications or multimedia presentation packages will incorporate the TSE3 libraries to provide a user with MIDI sequencing facilities. Koji: F-10: http://koji.fedoraproject.org/koji/taskinfo?taskID=1070317 F-11: http://koji.fedoraproject.org/koji/taskinfo?taskID=1070322 Rpmlint: silent There are 3 patches to fix compilation issues. These patches have been around (for other distros) for a while now as the project itself seems pretty much dead. I'm not sure I should bother sending them upstream again.
Created attachment 329952 [details] some trial patch For 0.3.1-1: * About Patch2: - Well, google shows that awe_voice.h was removed from kernel headers at 2.6.21 or so (i.e. around Fedora 7) I don't think it is preferrable to re-introduce macros which was defined in the header file which is no longer supported. I guess kernel supports AWE32 in other way or kernel does not support AWE32 completely any more. Are macros related to awe_voice.h really needed even now? (removing all awe32 related parts like attached does not help ? I just tried to remove all awe_voice.h related parts and did not any functionality check as I don't know how to use this software...) * Timestamps - Please consider to use ------------------------------------------------------- make install DESTDIR=%{buildroot} INSTALL="install -p" ------------------------------------------------------- to keep timestamps on installed files. * Directory structure about document files - For HTML files in devel package, I suggest that a subdirectory should be created under %_defaultdocdir/%name-devel-%version (named as "HTML", for example) and all HTML files should be moved into the directory.
Thank you. (In reply to comment #1) > > * About Patch2: > - Well, google shows that awe_voice.h was removed from > kernel headers at 2.6.21 or so (i.e. around Fedora 7) > I don't think it is preferrable to re-introduce macros > which was defined in the header file which is no longer > supported. I guess kernel supports AWE32 in other way > or kernel does not support AWE32 completely any more. > > Are macros related to awe_voice.h really needed even > now? > (removing all awe32 related parts like attached does not help ? > I just tried to remove all awe_voice.h related parts > and did not any functionality check as I don't know > how to use this software...) > Thanks for the patch. It seems like you are right. But now I am thinking of dropping the OSS support from tse3 altogether. I see other applications/libraries in Fedora built with --without-oss flag. - It will save us some dependencies, - I am not sure how functional the library will be after this patch, and - OSS is deprecated, so we won't loose much. Does that sound OK?
I think removing OSS support should be okay on Fedora.
Update: Spec URL: http://oget.fedorapeople.org/review/tse3.spec SRPM URL: http://oget.fedorapeople.org/review/tse3-0.3.1-2.fc10.src.rpm Changelog: - Move the HTML documentation into an HTML subdirectory - Use INSTALL="install -p" - Drop the oss support, and the related patch
Please provide srpm, not binary rpm :)
Uh oh. Sorry, my bad! I uploaded the appropriate SRPM file to the same place.
Okay, good. ----------------------------------------------------- This package (tse3) is APPROVED by mtasaka -----------------------------------------------------
Great. Thanks! New Package CVS Request ======================= Package Name: tse3 Short Description: MIDI Sequencer Engine Owners: oget Branches: F-9 F-10 InitialCC:
cvs done.
> Requires: %{name} == %{version}-%{release} Does that work? > %install > make install DESTDIR=%{buildroot} INSTALL="install -p" \ "rm -rf %{buildroot}" is missing as the first cmd in %install section.
(In reply to comment #10) > > Requires: %{name} == %{version}-%{release} > > Does that work? Yes (at least on F-9/10/11) > > %install > > make install DESTDIR=%{buildroot} INSTALL="install -p" \ > > "rm -rf %{buildroot}" is missing as the first cmd in %install section. Sorry for not pointing this out...
Closing.
(In reply to comment #11) > (In reply to comment #10) > > > %install > > > make install DESTDIR=%{buildroot} INSTALL="install -p" \ > > > > "rm -rf %{buildroot}" is missing as the first cmd in %install section. > > Sorry for not pointing this out... No problem. I missed this as much as you did. But this is weird because rpmlint normally warns us if one of the "rm -rf %{buildroot}" is missing (one in %install, one in %clean). Maybe we hit an rpmlint bug. I'm revoking my requests for pushing to F-9 and F-10 update-testing and rebuilding.