Spec URL: http://heffer.fedorapeople.org/review/w_scan.spec SRPM URL: http://heffer.fedorapeople.org/review/w_scan-20081106-1.fc10.src.rpm Description: The w_scan tool is similar to dvbscan from dvb-apps. However it does not require initial tuning data and thus is able to find more channels. Note that w_scan does not support DVB-S (only DVB-C/T). rpmlint is silent on this one
REVIEW: [+] = OK [-] = NOT OK [1] = SEE COMMENTS [?] = WTF? =========================== [+] source files match upstream: sha1: 8c64968feef8ac5e53790c23a52f06e476d4dfae [+] package meets naming and versioning guidelines. [+] specfile is properly named, is cleanly written and uses macros consistently. [+] dist tag is present. [+] build root is correct. [+] license field matches the actual license. [+] license is open source-compatible. GPLv2+ [+] license text included in package. [+] latest version is being packaged. [+] BuildRequires are proper. [+] compiler flags are appropriate. [+] %clean is present. [+] package builds in koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=1079863 [+] package installs properly. [+] debuginfo package looks complete. [+] rpmlint is silent. [+] final provides and requires are sane [+] no shared libraries are added to the regular linker search paths. [+] owns the directories it creates. [+] doesn't own any directories it shouldn't. [+] no duplicates in %files. [+] file permissions are appropriate. [+] no scriptlets present. [+] code, not content. [+] documentation is small, so no -docs subpackage is necessary. [+] %docs are not necessary for the proper functioning of the package. [+] no headers. [+] no pkgconfig files. [+] no libtool .la droppings. =========================== COMMENTS: Package looks good. => APPROVED
Thank you for your review. It's much appreciated! New Package CVS Request ======================= Package Name: w_scan Short Description: Tool for scanning DVB-C/T transponders Owners: heffer Branches: F-9 F-10 InitialCC:
cvs done.