Red Hat Bugzilla – Bug 481731
Review Request: resource-agents - Open Source HA Resource Agents for Red Hat Cluster
Last modified: 2013-03-13 16:40:42 EDT
Spec URL: http://fabbione.fedorapeople.org/ras/01/resource-agents.spec
SRPM URL: http://fabbione.fedorapeople.org/ras/01/resource-agents-3.0.0-1.alpha3.fc11.src.rpm
Description: Red Hat Resource Agents provides a set of scripts to interface with several services to operate in a High Availability environment.
The resource-agents are, at this point in time, released together with cluster (srpm). Upstream has been evaluating for sometime the area that receives the most frequent updates. resource agents is one of them. by separating the agents into its own tarball and rpm it makes updates a lot simpler for everybody.
This package will replace parts of rgmanager rpm once approved (see also note in the spec file). rgmanager will be update accordingly at the right time as I don't want to break rgmanager functionalities in a transition phase while this package is reviewed.
As rawhide and upstream change, new versions of spec and srpm:
Spec URL: http://fabbione.fedorapeople.org/ras/02/resource-agents.spec
SRPM URL: http://fabbione.fedorapeople.org/ras/02/resource-agents-3.0.0-1.alpha4.fc11.src.rpm
looks fine (though the scripts need separate review). There was one "should" I pointed out (add LICENSE), and Fabio said he'd address it.
In order to address the LICENSE file missing, I'll have to release a new upstream tarball. It will happen this week so i don't think is a big blocker.
Jim, thanks a lot for the review.
New Package CVS Request
Package Name: resource-agents
Short Description: Open Source HA Resource Agents for Red Hat Cluster
Can the reviewer here please set the fedora-review flag to + if they approve this package?
(Also, reviewer should assign this review to themselves and moved it to ASSIGNED).
reset fedora-cvs once thats done.
not sure this is a fall out from the new bugzilla packages but I got this email:
Jim Meyering <email@example.com> changed:
What |Removed |Added
together with Comment 2.
But even reloading the bugzilla page, the Flags (for me) were still set as fedora-review?
is this normal?
sorry I need to bother you with this again but it appears that for some reason, when I added fedora-cvs+, your fedora-review+ has been changed back to -.
I spoke to Kevin on IRC and for accounting reasons admins would prefer you to set the flag back to review+, otherwise it's all cleared up.
Fabio, no problem.
I've just set the fedora-review flag to +, again,
and listed myself in "assigned to".
But in future please include the main review conversation in bugzilla so there is some record of the review proper preserved for others to see: this is important.
1157024 build (dist-f11, /cvs/pkgs:rpms/resource-agents/devel:resource-agents-3_0_0-4_alpha5_fc11) completed successfully
Package Change Request
Package Name: resource-agents
New Branches: F-10
This was an oversight on my side (so yeah I take all the blame) from the original CVS request. The whole point of this package is to make updates simpler. So it needs to propagate into F-10 too.