Bug 481738 - Review Request: python-EnthoughtBase - Core package for the Enthought Tool Suite
Summary: Review Request: python-EnthoughtBase - Core package for the Enthought Tool Suite
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
low
medium
Target Milestone: ---
Assignee: Jochen Schmitt
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On: 481725
Blocks: 481759 482216
TreeView+ depends on / blocked
 
Reported: 2009-01-27 13:15 UTC by Rakesh Pandit
Modified: 2009-07-03 19:52 UTC (History)
3 users (show)

Fixed In Version: 3.0.1-3.fc10
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2009-06-08 05:36:20 UTC
jochen: fedora-review+
tibbs: fedora-cvs+


Attachments (Terms of Use)

Description Rakesh Pandit 2009-01-27 13:15:08 UTC
Description:

The EnthoughtBase project includes a few core packages that are used
by many other projects in the Enthought Tool Suite:

    * enthought.etsconfig: Supports configuring settings that need to
      be shared across multiple projects or programs on the same
      system.

    * enthought.logger: Provides convenience functions for creating
      logging handlers.

    * enthought.util: Provides miscellaneous utility functions.

SPEC: http://rakesh.fedorapeople.org/spec/python-EnthoughtBase.spec
SRPM: http://rakesh.fedorapeople.org/srpm/python-EnthoughtBase-3.0.1-1.fc10.src.rpm

Need for Mayavi

Comment 1 Jason Tibbitts 2009-03-07 23:09:02 UTC
Something seems wrong with the SRPM above; I download a 176128 byte file, but rpm 
complains when unpacking it:
error: unpacking of archive failed on file /home/tibbs/work/rpm/python-EnthoughtBase-3.0.1/EnthoughtBase-3.0.1.tar.gz;49b2fe7b: 
cpio: read error: python-EnthoughtBase-3.0.1-1.fc10.src.rpm cannot be installed

Comment 2 Rakesh Pandit 2009-03-08 01:37:37 UTC
Ugg, no clue why it happened

Rebuild and uploaded now:
http://rakesh.fedorapeople.org/srpm/python-EnthoughtBase-3.0.1-1.fc10.src.rpm

Comment 3 Jochen Schmitt 2009-03-12 17:35:44 UTC
Good:
+ Base file name of SPEC file fits with package name
+ Package names fits the naming guidelines
+ URL shows on proper project page
+ Package contains most recent version of the application
+ Could download upstream tar ball via spectool -g
+ Package tar ball matches with upstream
(md5sum: cc555fca3d43c6d8d9ad7a5fdf3e74a1)
+ Consistent usage of prm macros
+ Package contains a valid license tag
+ License tag state BSD and LGPLv2+ as valid OSS licenses
* Package contains verbatin copy of the license text
+ Package contains proper BuildRoot defintion
+ Package contains no patches
* Package contains no subpackages
+ Local build works fine
+ Rpmlint is silent on source package
+ Rpmlint is silent on binary package
+ BuildRoot will be cleaned at the beginning of %clean in %install
+ Package contains a %clean stanza
+ Package is build as noarch
+ Local install works fine
+ Local unisntall works fine
+ Koji build works fine
+ File has proper permission
+ File list has no duplicates
+ Files are owned by this package
+ There are no file with are owned by other package
+ %doc stanza is small
+ Package contains proper %changelog

Bad:
- Please delese the *.egg-info directory in the %prep stanza
- I think the License tag should be BSD and/or LGPLv2+ because
util/buid.py refer to both licenses
- I think you should uncompres docs/html.zip and ToolkitSelection 
ito the %doc stanza

Comment 5 Jochen Schmitt 2009-03-17 16:09:00 UTC
Good:
+ License tag contains proper value
+ Egg-info directory was deleted
+ html.zip was uncompressed and included into the %doc stanza

Bad:
- Demo application fails to run
s logger_demo_app]$ python demo.py
Traceback (most recent call last):
  File "demo.py", line 6, in <module>
    from enthought.envisage.ui.workbench.api import WorkbenchApplication
ImportError: No module named envisage.ui.workbench.api

Comment 6 Rakesh Pandit 2009-03-17 17:29:57 UTC
It seems to me these all test cases are wrongly written and whole stack seems to have a circular dependency ... I wouldn't been able to investigate much until next week. Am on holidays -- Thanks -- Will update next week for sure.

Comment 7 Jochen Schmitt 2009-04-23 17:32:31 UTC
Ping rpmandit

Comment 8 Rakesh Pandit 2009-05-02 13:54:23 UTC
https://mail.enthought.com/pipermail/enthought-dev/2009-May/021337.html

Reported this one also upstream and waiting for reason for its failure. it looks like no demo and examples are working correctly.

Comment 9 Rakesh Pandit 2009-05-02 14:03:58 UTC
https://mail.enthought.com/pipermail/enthought-dev/2009-May/021338.html

Confirmed that these demo's and examples are not correctly written. We can ignore this demo run.

These demo's and examples have dependencies with other packages .. even though package does not have those dependencies in actual.

So, we can ignore them.

Comment 10 Rakesh Pandit 2009-05-24 09:34:00 UTC
ping ? :)

Comment 11 Jochen Schmitt 2009-06-03 17:26:15 UTC
Soory, that I'M late.

I thing we can ignore the issue with the demo, but it may be nice to have a README.Fedora file in the package which explains this issues.

Comment 13 Jochen Schmitt 2009-06-04 16:47:29 UTC
It may be nice, if you can changed %default into %global if possible.

But because this is only a monor issue, I will APPROVE your package.

Comment 14 Rakesh Pandit 2009-06-05 02:27:56 UTC
Thanks :) Will change before importing.

New Package CVS Request
=======================
Package Name: python-EnthoughtBase
Short Description: Core package for the Enthought Tool Suite
Owners: rakesh
Branches: F-9 F-10 F-11
InitialCC:

Comment 15 Jason Tibbitts 2009-06-05 21:42:43 UTC
CVS done.

Comment 16 Fedora Update System 2009-06-08 05:27:02 UTC
python-EnthoughtBase-3.0.1-3.fc9 has been submitted as an update for Fedora 9.
http://admin.fedoraproject.org/updates/python-EnthoughtBase-3.0.1-3.fc9

Comment 17 Fedora Update System 2009-06-08 05:28:14 UTC
python-EnthoughtBase-3.0.1-3.fc10 has been submitted as an update for Fedora 10.
http://admin.fedoraproject.org/updates/python-EnthoughtBase-3.0.1-3.fc10

Comment 18 Fedora Update System 2009-06-08 05:29:10 UTC
python-EnthoughtBase-3.0.1-3.fc11 has been submitted as an update for Fedora 11.
http://admin.fedoraproject.org/updates/python-EnthoughtBase-3.0.1-3.fc11

Comment 19 Fedora Update System 2009-07-03 19:44:16 UTC
python-EnthoughtBase-3.0.1-3.fc9 has been pushed to the Fedora 9 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 20 Fedora Update System 2009-07-03 19:45:08 UTC
python-EnthoughtBase-3.0.1-3.fc11 has been pushed to the Fedora 11 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 21 Fedora Update System 2009-07-03 19:52:20 UTC
python-EnthoughtBase-3.0.1-3.fc10 has been pushed to the Fedora 10 stable repository.  If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.