Red Hat Bugzilla – Bug 481738
Review Request: python-EnthoughtBase - Core package for the Enthought Tool Suite
Last modified: 2009-07-03 15:52:25 EDT
The EnthoughtBase project includes a few core packages that are used
by many other projects in the Enthought Tool Suite:
* enthought.etsconfig: Supports configuring settings that need to
be shared across multiple projects or programs on the same
* enthought.logger: Provides convenience functions for creating
* enthought.util: Provides miscellaneous utility functions.
Need for Mayavi
Something seems wrong with the SRPM above; I download a 176128 byte file, but rpm
complains when unpacking it:
error: unpacking of archive failed on file /home/tibbs/work/rpm/python-EnthoughtBase-3.0.1/EnthoughtBase-3.0.1.tar.gz;49b2fe7b:
cpio: read error: python-EnthoughtBase-3.0.1-1.fc10.src.rpm cannot be installed
Ugg, no clue why it happened
Rebuild and uploaded now:
+ Base file name of SPEC file fits with package name
+ Package names fits the naming guidelines
+ URL shows on proper project page
+ Package contains most recent version of the application
+ Could download upstream tar ball via spectool -g
+ Package tar ball matches with upstream
+ Consistent usage of prm macros
+ Package contains a valid license tag
+ License tag state BSD and LGPLv2+ as valid OSS licenses
* Package contains verbatin copy of the license text
+ Package contains proper BuildRoot defintion
+ Package contains no patches
* Package contains no subpackages
+ Local build works fine
+ Rpmlint is silent on source package
+ Rpmlint is silent on binary package
+ BuildRoot will be cleaned at the beginning of %clean in %install
+ Package contains a %clean stanza
+ Package is build as noarch
+ Local install works fine
+ Local unisntall works fine
+ Koji build works fine
+ File has proper permission
+ File list has no duplicates
+ Files are owned by this package
+ There are no file with are owned by other package
+ %doc stanza is small
+ Package contains proper %changelog
- Please delese the *.egg-info directory in the %prep stanza
- I think the License tag should be BSD and/or LGPLv2+ because
util/buid.py refer to both licenses
- I think you should uncompres docs/html.zip and ToolkitSelection
ito the %doc stanza
+ License tag contains proper value
+ Egg-info directory was deleted
+ html.zip was uncompressed and included into the %doc stanza
- Demo application fails to run
s logger_demo_app]$ python demo.py
Traceback (most recent call last):
File "demo.py", line 6, in <module>
from enthought.envisage.ui.workbench.api import WorkbenchApplication
ImportError: No module named envisage.ui.workbench.api
It seems to me these all test cases are wrongly written and whole stack seems to have a circular dependency ... I wouldn't been able to investigate much until next week. Am on holidays -- Thanks -- Will update next week for sure.
Reported this one also upstream and waiting for reason for its failure. it looks like no demo and examples are working correctly.
Confirmed that these demo's and examples are not correctly written. We can ignore this demo run.
These demo's and examples have dependencies with other packages .. even though package does not have those dependencies in actual.
So, we can ignore them.
ping ? :)
Soory, that I'M late.
I thing we can ignore the issue with the demo, but it may be nice to have a README.Fedora file in the package which explains this issues.
It may be nice, if you can changed %default into %global if possible.
But because this is only a monor issue, I will APPROVE your package.
Thanks :) Will change before importing.
New Package CVS Request
Package Name: python-EnthoughtBase
Short Description: Core package for the Enthought Tool Suite
Branches: F-9 F-10 F-11
python-EnthoughtBase-3.0.1-3.fc9 has been submitted as an update for Fedora 9.
python-EnthoughtBase-3.0.1-3.fc10 has been submitted as an update for Fedora 10.
python-EnthoughtBase-3.0.1-3.fc11 has been submitted as an update for Fedora 11.
python-EnthoughtBase-3.0.1-3.fc9 has been pushed to the Fedora 9 stable repository. If problems still persist, please make note of it in this bug report.
python-EnthoughtBase-3.0.1-3.fc11 has been pushed to the Fedora 11 stable repository. If problems still persist, please make note of it in this bug report.
python-EnthoughtBase-3.0.1-3.fc10 has been pushed to the Fedora 10 stable repository. If problems still persist, please make note of it in this bug report.