Bug 481751 - Review Request: fence-agents - Fence Agents for Red Hat Cluster
Summary: Review Request: fence-agents - Fence Agents for Red Hat Cluster
Keywords:
Status: CLOSED NEXTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Jim Meyering
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2009-01-27 13:47 UTC by Fabio Massimo Di Nitto
Modified: 2013-03-13 20:41 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2009-02-24 12:55:15 UTC
Type: ---
Embargoed:
meyering: fedora-review+
kevin: fedora-cvs+


Attachments (Terms of Use)

Description Fabio Massimo Di Nitto 2009-01-27 13:47:10 UTC
Spec URL: http://fabbione.fedorapeople.org/fas/01/fence-agents.spec
SRPM URL: http://fabbione.fedorapeople.org/fas/01/fence-agents-3.0.0-1.alpha3.fc11.src.rpm
Description: Red Hat Fence Agents is a collection of scripts to handle remote  power management for several devices.

The fence-agents are, at this point in time, released together with cluster
(srpm). Upstream has been evaluating for sometime the area that receives the
most frequent updates. fence agents is one of them. by separating the agents
into its own tarball and rpm it makes updates a lot simpler for everybody.
Other projects, non cluster related, are using those agents now. This split will allow those external projects to use the agents without pulling in the whole cluster stack.

This package will replace parts of cman rpm once approved (see also note
in the spec file). cman will be update accordingly at the right time as I
don't want to break cman functionalities in a transition phase while this
package is reviewed.

thanks
Fabio

Comment 1 Fabio Massimo Di Nitto 2009-02-06 08:10:04 UTC
As rawhide and upstream change, new versions of spec and srpm:

Spec URL: http://fabbione.fedorapeople.org/fas/02/fence-agents.spec
SRPM URL: http://fabbione.fedorapeople.org/fas/02/fence-agents-3.0.0-1.alpha4.fc11.src.rpm

Thanks
Fabio

Comment 2 Jim Meyering 2009-02-20 16:57:18 UTC
Hi Fabio,

Does mock work for you?
This is in just-updated rawhide:

# mock -r fedora-rawhide-x86_64 /t/fence-agents-3.0.0-1.alpha4.fc11.src.rpm
INFO: mock.py version 0.9.14 starting...
State Changed: init plugins
State Changed: start
INFO: Start(/t/fence-agents-3.0.0-1.alpha4.fc11.src.rpm)  Config(fedora-rawhide-x86_64)
State Changed: lock buildroot
State Changed: clean
State Changed: init
State Changed: lock buildroot
Mock Version: 0.9.14
INFO: Mock Version: 0.9.14
INFO: enabled root cache
INFO: enabled yum cache
State Changed: cleaning yum metadata
INFO: enabled ccache
State Changed: running yum
State Changed: creating cache
State Changed: setup
ERROR: Exception(/t/fence-agents-3.0.0-1.alpha4.fc11.src.rpm) Config(fedora-rawhide-x86_64) 5 minutes 45 seconds
INFO: Results and/or logs in: /var/lib/mock/fedora-rawhide-x86_64/result
ERROR: Command failed:
 # /usr/bin/yum --installroot /var/lib/mock/fedora-rawhide-x86_64/root/  resolvedep  ccache  'glibc-devel' 'nss-devel' 'openaislib-devel >= 0.91-6' 'python' 'libxml2-devel' 'corosynclib-devel >= 0.92-7' 'libvirt-devel' 'nspr-devel' 'clusterlib-devel >= 3.0.0' 'xen-libs' 'perl'
Traceback (most recent call last):
  File "/usr/bin/yum", line 29, in <module>
    yummain.user_main(sys.argv[1:], exit_code=True)
  File "/usr/share/yum-cli/yummain.py", line 301, in user_main
    errcode = main(args)
  File "/usr/share/yum-cli/yummain.py", line 155, in main
    base.getOptionsConfig(args)
  File "/usr/share/yum-cli/cli.py", line 188, in getOptionsConfig
    self.conf
  File "/usr/lib/python2.6/site-packages/yum/__init__.py", line 632, in <lambda>
    conf = property(fget=lambda self: self._getConfig(),
  File "/usr/lib/python2.6/site-packages/yum/__init__.py", line 227, in _getConfig  
    self._conf = config.readMainConfig(startupconf)
  File "/usr/lib/python2.6/site-packages/yum/config.py", line 772, in readMainConfig
    yumvars['releasever'] = _getsysver(startupconf.installroot, startupconf.distroverpkg)
  File "/usr/lib/python2.6/site-packages/yum/config.py", line 848, in _getsysver
    hdr = idx.next()
StopIteration

Comment 3 Fabio Massimo Di Nitto 2009-02-20 18:55:47 UTC
Looks like a bug in mock at this point.

I manually checked all BuildRequires and are all available on the mirrors.

Dropping all of the BuildRequires still fails with the same traceback (mock still attempts to install ccache but at this point it's not fence-agents triggering it).

I understand building in mock is an absolutely required step for accepting the pacakge, so let's just wait next Monday and see if it gets fixed. It will also give me a chance to perform an alpha5 release to address the issues you already reported to me.

Jim, thanks again for all your work.

Fabio

Comment 4 Jim Meyering 2009-02-20 20:27:02 UTC
Fabio,

Fine with me.  Listed myself as ASSIGNED-TO.
Have a good weekend,

Jim

Comment 5 Jim Meyering 2009-02-20 20:28:50 UTC
corrected typo s/agentes/agents/ in title

Comment 6 manuel wolfshant 2009-02-20 23:57:00 UTC
builds fine in koji:  http://koji.fedoraproject.org/koji/taskinfo?taskID=1143654

Comment 7 Fabio Massimo Di Nitto 2009-02-23 12:21:23 UTC
Hi Jim,

Spec URL: http://fabbione.fedorapeople.org/fas/03/fence-agents.spec
SRPM URL:
http://fabbione.fedorapeople.org/fas/02/fence-agents-3.0.0-3.alpha5.fc11.src.rpm

Updated everything with new upstream tarball and incorporated the changes from upstream and packaging that you asked during the review.

Fabio

Comment 8 Jim Meyering 2009-02-23 20:14:09 UTC
Hi Fabio,
I looked at 
http://fabbione.fedorapeople.org/fas/03/fence-agents-3.0.0-3.alpha5.fc11.src.rpm
(note the s/02/03/) and see you added README.license and changed fence_vmware_helper.pl to detect write errors among other things.
However, mock still fails due to what looks like a yum bug.  If you can report that or determine that it's not a problem, I'd say just skip it.

Jim

Comment 9 Fabio Massimo Di Nitto 2009-02-23 21:36:11 UTC
Hi Jim,

yes, fixed the problems you reported for the packaging.

Jan is also taking care of fixing all the python/perl/C fence agents but that's upstream job and it has been marked blocker for 3.0.0 final release.

I am still not able to build in mock but Manuel did report in Comment #6 that it builds fine in koji and it did never fail in my local machines (that are pretty much bare installations) so I am farly confident that it does build :)

I can't force you, but i'd like to move forward with this task. Also.. koji has been offline for maintaince for over 48 hours. Tomorrow morning I'll check if a mock fix has been stalling on infrastructure and let you know.

Fabio

Comment 10 Jim Meyering 2009-02-23 21:46:21 UTC
;-) no problem.  koji's good enough for me.
(sorry to be slow today. I'm supposed to be on PTO all this week)
I flipped the fedora-review switch.

Comment 11 Fabio Massimo Di Nitto 2009-02-24 05:49:41 UTC
New Package CVS Request
=======================
Package Name: fence-agents
Short Description: Fence Agents for Red Hat Cluster
Owners: fabbione
Branches: devel
InitialCC: fabbione

Comment 12 Fabio Massimo Di Nitto 2009-02-24 05:50:30 UTC
Jim,

thanks for the review and enjoy your PTO!

Fabio

Comment 13 Jens Petersen 2009-02-24 11:17:41 UTC
cvs admin done

BTW no need to initcc yourself.

Comment 14 Fabio Massimo Di Nitto 2009-02-24 12:55:15 UTC
1157018 build (dist-f11, /cvs/pkgs:rpms/fence-agents/devel:fence-agents-3_0_0-4_alpha5_fc11) completed successfully

Comment 15 Fabio Massimo Di Nitto 2009-03-03 07:04:14 UTC
Package Change Request
======================
Package Name: fence-agents
New Branches: F-10
Owners: fabbione

This was an oversight on my side (so yeah I take all the blame) from the original CVS request. The whole point of this package is to make updates simpler. So it needs to propagate into F-10 too.

Comment 16 Kevin Fenzi 2009-03-03 20:49:16 UTC
cvs done.


Note You need to log in before you can comment on or make changes to this bug.