Hide Forgot
Spec URL: http://ausil.us/packages/perl-Network-IPv4Addr.spec SRPM URL: http://ausil.us/packages/perl-Network-IPv4Addr-0.05-12.fc10.src.rpm Description: Network::IPv4Addr provides functions for parsing IPv4 addresses both in traditional address/netmask format and in the new CIDR format. There are also methods for calculating the network and broadcast address and also to see check if a given address is in a specific network.
Review: + package builds in mock (rawhide i386). koji Build => http://koji.fedoraproject.org/koji/taskinfo?taskID=1090313 + rpmlint is silent for SRPM and for RPM. + source files match upstream url 1c4a9278ada5557a4895ee44b0312888 Network-IPv4Addr-0.05.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc is present. + BuildRequires are proper. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no headers or static libraries. + no .pc file present. + no -devel subpackage + no .la files. + no translations are available + Does owns the directories it creates. + no scriptlets present. + no duplicates in %files. + file permissions are appropriate. + make test is ok + Package perl-Network-IPv4Addr-0.05-12.fc11 => Provides: perl(Network::IPv4Addr) = 0.05 Requires: /usr/bin/perl perl(AutoLoader) perl(Carp) perl(Exporter) perl(Getopt::Long) perl(Network::IPv4Addr) perl(strict) perl(vars) Suggestions: 1) Use complete source url as http://search.cpan.org/CPAN/authors/id/F/FR/FRAJULAC/Network-IPv4Addr-0.05.tar.gz APPROVED.
Thanks for the review New Package CVS Request ======================= Package Name: perl-Network-IPv4Addr Short Description: Network-IPv4Addr Perl module Owners: dgilmore Branches: F-9 EL-5 F-10 InitialCC: perl-sig
CVS Done
New Package CVS Request ======================= Package Name: perl-Network-IPv4Addr Short Description: Network-IPv4Addr Perl module Owners: ausil Branches: F-9 EL-5 F-10 InitialCC: perl-sig use the right account name.
please remove OPTIMIZE="$RPM_OPT_FLAGS" from %build as this is noarch package.
cleaned up in -13 package commited to cvs.
perl-Network-IPv4Addr-0.05-13.fc10 has been pushed to the Fedora 10 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update perl-Network-IPv4Addr'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F10/FEDORA-2009-1356
perl-Network-IPv4Addr-0.05-13.fc9 has been pushed to the Fedora 9 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing-newkey update perl-Network-IPv4Addr'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F9/FEDORA-2009-1381