Review:
+ package builds in mock (rawhide i386).
koji Build => http://koji.fedoraproject.org/koji/taskinfo?taskID=1090315
+ rpmlint is silent for SRPM and for RPM.
+ source files match upstream url
8f9e6ba2595b07997efac1377c5484e9  XML-Generator-1.01.tar.gz
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ %doc is present.
+ BuildRequires are proper.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code, not content.
+ no headers or static libraries.
+ no .pc file present.
+ no -devel subpackage
+ no .la files.
+ no translations are available
+ Does owns the directories it creates.
+ no scriptlets present.
+ no duplicates in %files.
+ file permissions are appropriate.
+ make test gave
All tests successful.
Files=2, Tests=97,  0 wallclock secs ( 0.03 usr  0.01 sys +  0.09 cusr  0.02 csys =  0.15 CPU)
+ Package perl-XML-Generator-1.01-1.fc11 =>
  Provides:  perl(XML::Generator) = 1.01 perl(XML::Generator::cdata) perl(XML::Generator::comment) perl(XML::Generator::final) perl(XML::Generator::overload) perl(XML::Generator::pi) perl(XML::Generator::pretty) perl(XML::Generator::util)
 Requires: perl(Carp) perl(base) perl(constant) perl(overload) perl(strict) perl(vars)

Any reason for removing DOM.pm?

I honestly do not know why DOM.pm is removed. i picked up the spec from spacewalk and cleaned it up.  lets add it back.

Spec URL: http://ausil.us/packages/perl-XML-Generator.spec
SRPM URL: http://ausil.us/packages/perl-XML-Generator-1.01-2.fc10.src.rpm

Still some issues:

* The t/DOM.t test fails due to a missing XML::DOM
=> Please add
BuildRequires: perl(XML::DOM)
This should let the testsuite succeed.

* This is a noarch package.
=> No need to pass OPTIMIZE in %build
Please remove OPTIMIZE.

(In reply to comment #3)
> Still some issues:
> 
> * The t/DOM.t test fails due to a missing XML::DOM
> => Please add
> BuildRequires: perl(XML::DOM)
> This should let the testsuite succeed.
> 
> * This is a noarch package.
> => No need to pass OPTIMIZE in %build
> Please remove OPTIMIZE.

Thanks for this comment. I thought its ok not to care much for noarch packages. Thanks will take care to ask to remove OPTIMIZE for perl noarch packages.

fixed in 
Spec URL: http://ausil.us/packages/perl-XML-Generator.spec
SRPM URL: http://ausil.us/packages/perl-XML-Generator-1.01-3.fc10.src.rpm

i checked that the tests did infact complete sucessfully

Review:
+ package builds in mock (rawhide i386).
koji Build => http://koji.fedoraproject.org/koji/taskinfo?taskID=1092744
+ rpmlint is silent for SRPM and for RPM.
+ source files match upstream url
8f9e6ba2595b07997efac1377c5484e9  XML-Generator-1.01.tar.gz
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ %doc is present.
+ BuildRequires are proper.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code, not content.
+ no headers or static libraries.
+ no .pc file present.
+ no -devel subpackage
+ no .la files.
+ no translations are available
+ Does owns the directories it creates.
+ no scriptlets present.
+ no duplicates in %files.
+ file permissions are appropriate.
+ make test gave
All tests successful.
Files=2, Tests=132,  0 wallclock secs ( 0.03 usr  0.00 sys +  0.17 cusr  0.02 csys =  0.22 CPU)
+ Package perl-XML-Generator-1.01-3.fc11 =>
 Provides:
 perl(XML::Generator) = 1.01
 perl(XML::Generator::DOM) = 0.2
 perl(XML::Generator::DOM::util)
 perl(XML::Generator::cdata)
 perl(XML::Generator::comment)
 perl(XML::Generator::final)
 perl(XML::Generator::overload)
 perl(XML::Generator::pi)
 perl(XML::Generator::pretty)
 perl(XML::Generator::util)

Requires:
 perl(Carp)
 perl(XML::DOM)
 perl(XML::Generator)
 perl(base)
 perl(constant)
 perl(overload)
 perl(strict)
 perl(vars)

APPROVED.

*** Bug 485164 has been marked as a duplicate of this bug. ***

New Package CVS Request
=======================
Package Name: perl-XML-Generator
Short Description: perl module for generating XML documents
Owners: ausil
Branches: EL-5 F-9 F-10
InitialCC: perl-sig

CVS Done

Can you close this review if this package is built for all requested branches?

looks this package is already built for requested branches therefore closing this review now.

perl-XML-Generator-1.01-3.fc10 has been pushed to the Fedora 10 stable repository.  If problems still persist, please make note of it in this bug report.

perl-XML-Generator-1.01-3.fc9 has been pushed to the Fedora 9 stable repository.  If problems still persist, please make note of it in this bug report.