Red Hat Bugzilla – Bug 483026
Review Request: hatools - Improved shell scripting in High Availability environment
Last modified: 2009-02-06 00:24:55 EST
Spec URL: http://filelister.linux-kernel.at/downloads/share/hatools.spec
SRPM URL: http://filelister.linux-kernel.at/downloads/share/hatools-2.00-1.fc10.src.rpm
The HA-Tools provide some programs to improve shell scripting in a High
The halockrun program provides a simple and reliable way to implement a locking
in shell scripts. A typical usage for halockrun is to prevent cronjobs to run
simultanously. halockrun uses a lock on a file via fcntl(2) which ensures the
release of the lock even if the process gets killed via SIGKILL.
The hatimerun program provides a time-out mechanism which can be used from
I'm not sure about the GPL license... Maybe with more knowledge about licensing should take that this review...
+ Basename of the SPEC files matches with package name
+ Package contains the most current release
+ SPEC file is written in English
+ Could download source via spectool -g
+ Packaged tar ball matches with upstream
+ Package contains no patches
+ Package contains a license tag
+ Package contains a verbatin copy of the license text
+ Package contains proper BuildRoot specification
+ Consistently use of rpm macros
+ Package contains no patches
+ Package doesn't need any BRs or Reqs.
+ Package use parallel make
+ Buildroot will be cleaned at the beginning of %clean and %install
+ Local build works fine
+ Build honors $RPM_OPT_FLAGS
+ Koji build works fine
+ Debuginfo package contains source files
+ Local install works fine
+ Start of command without arguments doesn't crashed
+ Local uninstall works fine
+ Package doesn't have subpackages
+ Default files permission are ok.
+ Files have proper file permission
+ %files stanza doesn't have duplicated entries
+ All packaged files are owned by the package
+ No packaged file has a conflict with ohter packages
+ %doc stanza is small, so we don't need a separate subpackage
+ %changelog is in a proper format
- License tag says GPL as license. It's necessary to specified the
version of the used GPL. A look on the source files says, that GPLv2+
may the right specification for the license tag.
* I thing a blank line beetween the paragraph of the description
will incerease the readability of it.
Updated the spec, including TODO and BAD :-)
I did *not* increase the release number.
Thx Jochen for reviewing!
+ License tag say GPLv2+ as an OSS license wich matches with the copyright notes in the source files.
+ Adding blank lines betweens the paragraphs.
*** APPROVED ***
New Package CVS Request
Package Name: hatools
Short Description: Improved shell scripting in High Availability environment
Branches: EPEL-4 EPEL-5 F-9 F-10
hatools-2.00-1.fc10 has been pushed to the Fedora 10 stable repository. If problems still persist, please make note of it in this bug report.
hatools-2.00-1.fc9 has been pushed to the Fedora 9 stable repository. If problems still persist, please make note of it in this bug report.