Bug 483257 - resolv.conf rewritten even though PEERDNS=no
Summary: resolv.conf rewritten even though PEERDNS=no
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: initscripts
Version: rawhide
Hardware: All
OS: Linux
low
high
Target Milestone: ---
Assignee: Bill Nottingham
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2009-01-30 15:22 UTC by Jonathan Kamens
Modified: 2014-03-31 17:55 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2009-03-16 20:26:34 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)
patch to /etc/sysconfig/network-scripts/network-functions (1.09 KB, patch)
2009-02-06 01:51 UTC, Jonathan Kamens
no flags Details | Diff

Description Jonathan Kamens 2009-01-30 15:22:56 UTC
Updated this morning from Rawhide.  Rebooted.  /etc/resolv.conf was rewritten when my DHCP interface (eth0) was brought up, even though I have PEERDNS=no in /etc/sysconfig/network-scripts/ifcfg-eth0.

Comment 1 Jonathan Kamens 2009-02-06 01:50:59 UTC
This really should have been an alpha blocker.  At the very least, it should be a beta blocker.  The problem is that the source_config function in /etc/sysconfig/network-scripts/network-functions is buggy -- it assumes that the config file name isn't an absolute path.  I will attach a patch which fixes this as well as does a number of other related clean-ups.

Comment 2 Jonathan Kamens 2009-02-06 01:51:25 UTC
Created attachment 331078 [details]
patch to /etc/sysconfig/network-scripts/network-functions

Comment 3 Jonathan Kamens 2009-03-15 11:22:39 UTC
Hello?  Anybody there?  I filed this ticket over a month ago and even provided a patch, and yet nobody has done anything with it.  Surely breaking /etc/resolv.conf is a release blocker?

Comment 4 Bill Nottingham 2009-03-16 18:22:59 UTC
1) got busy with other things
2) it's not necessarily correct in that config files in random locations isn't really supposed to work. It could be easily fixed in dhclient-script too
3) it leads to the question of whether the PARENTCONFIG stuff there really is still needed

Comment 5 Jonathan Kamens 2009-03-16 18:28:35 UTC
Concerning (2), while my fix catered to the fact that there was all that weird code in the script to allow config files in random locations, that's not the bug I initially reported or fixed.  The bug is that even when the config files are all in the standard locations, dhclient changes resolv.conf even when PEERDNS is no.  This is surely a release blocker.

Comment 6 Bill Nottingham 2009-03-16 20:26:34 UTC
Sure, but while I'm looking at it, I'd like to get the whole thing right.

http://git.fedorahosted.org/git/?p=initscripts.git;a=commitdiff;h=36bda7223dab26915b7bca098f11bf180ed8e541

Will be in 8.91-1.


Note You need to log in before you can comment on or make changes to this bug.