Spec URL: http://tbzatek.fedorapeople.org/nautilus-gdu/nautilus-gdu.spec SRPM URL: http://tbzatek.fedorapeople.org/nautilus-gdu/nautilus-gdu-0.1-git20090130.1.fc11.src.rpm Description: Simple extension for formatting disks, usb sticks and other media, available from Nautilus context menu. This extension is built on top. of the gnome-disk-utility library with DeviceKit-disks as a backend. Access to physical devices is controlled by PolicyKit. - rpmlint reports no error, package builds successfully in koji
Package builds fine in mock. rpmlint output: 3 packages and 0 specfiles checked; 0 errors, 0 warnings.
requires/provides/file list look sane
package name: ok spec file name: ok packaging guidelines: ok license: ok license field: ok license file: ok spec file language: ok spec file legible: ok sources: you should probably add a comment explaining how to get the tarball from git. longer-term, we need to sort out hosting buildable: ok excludearch: ok build deps: ok locale handling: ok, no translations right now. sorting that out ties in to the hosting question... ldconfig: I don't think you need to call ldconfig in %post/%postun, since you are not installing a shared library in the linker path, just a loadable module relocatable: n/a directory ownership: ok duplicate files: ok permissions: ok %clean: ok macro use: ok permissible content: ok large docs: n/a %doc content: ok headers: n/a static libs: n/a pc files: ok shared libs: ok devel subpackage: n/a libtool archives: ok gui apps: ok file ownership: ok %install: ok utf8 filenames: ok Summary: - add source comment - remove unnecessary %post/%postun
Thanks for the review. I've added a comment how to get sources from git (by cloning the repo). Fixed files: Spec URL: http://tbzatek.fedorapeople.org/nautilus-gdu/nautilus-gdu.spec SRPM URL: http://tbzatek.fedorapeople.org/nautilus-gdu/nautilus-gdu-0.1-git20090130.1.fc11.src.rpm
looks good now. approved
New Package CVS Request ======================= Package Name: nautilus-gdu Short Description: Nautilus extension for disk formatting Owners: tbzatek Branches: devel InitialCC:
cvs done
Successfully built in rawhide: http://koji.fedoraproject.org/koji/buildinfo?buildID=81493