Spec URL: http://allisson.fedorapeople.org/packages/perl-MooseX-Iterator/perl-MooseX-Iterator.spec SRPM URL: http://allisson.fedorapeople.org/packages/perl-MooseX-Iterator/perl-MooseX-Iterator-0.09-1.fc10.src.rpm Description: This is an attempt to add smalltalk-like streams to Moose. It currently works with ArrayRefs and HashRefs.
Package Review ============== Key: - = N/A x = Check ! = Problem ? = Not evaluated === REQUIRED ITEMS === [x] Package is named according to the Package Naming Guidelines. [x] Spec file name must match the base package %{name}, in the format %{name}.spec. [x] Package meets the Packaging Guidelines including the Perl specific items [x] Package successfully compiles and builds into binary rpms on at least one supported architecture. Tested on: devel/x86_64 [x] Rpmlint output: source RPM: empty binary RPM:empty [x] Package is not relocatable. [x] Buildroot is correct (%{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)) [x] Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x] License field in the package spec file matches the actual license. License type: GPL+ or Artistic (same as perl) [x] If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x] Spec file is legible and written in American English. [x] Sources used to build the package matches the upstream source, as provided in the spec URL. SHA1SUM of package: 1e61a292c89e236b1ef39a086059724ff80b15ff MooseX-Iterator-0.09.tar.gz [x] Package is not known to require ExcludeArch [x] All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [-] The spec file handles locales properly. [-] ldconfig called in %post and %postun if required. [x] Package must own all directories that it creates. [x] Package requires other packages for directories it uses. [x] Package does not contain duplicates in %files. [x] Permissions on files are set properly. [x] Package has a %clean section, which contains rm -rf $RPM_BUILD_ROOT. [x] Package consistently uses macros. [x] Package contains code, or permissable content. [-] Large documentation files are in a -doc subpackage, if required. [x] Package uses nothing in %doc for runtime. [-] Header files in -devel subpackage, if present. [-] Static libraries in -devel subpackage, if present. [-] Package requires pkgconfig, if .pc files are present. [-] Development .so files in -devel subpackage, if present. [-] Fully versioned dependency in subpackages, if present. [x] Package does not contain any libtool archives (.la). [-] Package contains a properly installed %{name}.desktop file if it is a GUI application. [x] Package does not own files or directories owned by other packages. === SUGGESTED ITEMS === [x] Latest version is packaged. [x] Package does not include license text files separate from upstream. [-] Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x] Reviewer should test that the package builds in mock. Tested on: devel/x86_64 [-] Package should compile and build into binary rpms on all supported architectures. Tested on: standard perl module, noarch [?] Package functions as described. [-] Scriptlets must be sane, if used. [-] The placement of pkgconfig(.pc) files is correct. [-] File based requires are sane. [x] make check passes The package has some odd requires/provides: [wolfy@wolfy tmp]$ rpm -qp --provides perl-MooseX-Iterator/perl-MooseX-Iterator-0.09-1.fc11.noarch.rpm perl(Moose::Meta::Attribute::Custom::Iterable) perl(MooseX::Iterator) = 0.09 perl(MooseX::Iterator::Array) = 0.09 perl(MooseX::Iterator::Hash) = 0.09 perl(MooseX::Iterator::Meta::Iterable) = 0.09 perl(MooseX::Iterator::Role) = 0.09 perl-MooseX-Iterator = 0.09-1.fc11 [wolfy@wolfy tmp]$ rpm -qp --requires perl-MooseX-Iterator/perl-MooseX-Iterator-0.09-1.fc11.noarch.rpm perl(:MODULE_COMPAT_5.10.0) perl(Carp) perl(Moose) perl(Moose) >= 0.26 perl(Moose::Role) perl(MooseX::Iterator::Array) perl(MooseX::Iterator::Hash) perl(MooseX::Iterator::Meta::Iterable) rpmlib(CompressedFileNames) <= 3.0.4-1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 rpmlib(VersionedDependencies) <= 3.0.3-1 Is it really intended to require what itself provides?
Update package: Spec URL: http://allisson.fedorapeople.org/packages/perl-MooseX-Iterator/perl-MooseX-Iterator.spec SRPM URL: http://allisson.fedorapeople.org/packages/perl-MooseX-Iterator/perl-MooseX-Iterator-0.09-2.fc10.src.rpm Changes: * Sun Feb 01 2009 Allisson Azevedo <allisson> 0.09-2 - Fix requires.
Hi, Requires and Provides is automatically picked up by rpmbuild.
I know it does, but I think (I might be wrong, though) that in this case it is not correct and they should be filtered out. See https://fedoraproject.org/wiki/Packaging/Perl#Filtering_Requires:_and_Provides
I agree, i'll fix this.
Update package: Spec URL: http://allisson.fedorapeople.org/packages/perl-MooseX-Iterator/perl-MooseX-Iterator.spec SRPM URL: http://allisson.fedorapeople.org/packages/perl-MooseX-Iterator/perl-MooseX-Iterator-0.09-3.fc10.src.rpm Changes: * Sun Feb 01 2009 Allisson Azevedo <allisson> 0.09-3 - Added filter requires.
Seems sane now. APPROVED
Please update fedora-review flag :)
New Package CVS Request ======================= Package Name: perl-MooseX-Iterator Short Description: Iterate over collections Owners: allisson Branches: F-9 F-10
cvs done.
Package Change Request ====================== Package Name: perl-MooseX-Iterator InitialCC: perl-sig Please add perl-sig to this package with watchbugzilla and watchcommits bits on all fedora branches.
Done.